Message ID | 20190711200309.6134-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3D081B942; Thu, 11 Jul 2019 22:03:13 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by dpdk.org (Postfix) with ESMTP id 9E9112C60 for <dev@dpdk.org>; Thu, 11 Jul 2019 22:03:12 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id az7so3577952plb.5 for <dev@dpdk.org>; Thu, 11 Jul 2019 13:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e+BEnsBfKcVcYv17/izomO0GtYAEKezFa3/XB4mW91g=; b=pCboDwLMVp1l2x92clU4BmhrH8f81qdIN5cXNZDQuGfWpRdRXuUQTDN8+IEFudfTq0 wKQv9j923VX7HZP2G/qW1UlolrZeR5pmpgdnbGSUfzgwpVKPlXD33UE5ZAxvI1qVVyf1 eyxkGlRM8AWi2OzMvQrfyvpFySFvKF4cinhXcD8EU0eqWTjLHyrRn+HT5m4xdtlMZ1Kb PyXmWDm8FrdeKJa98+Ac4tZSHlhBDHgQUiJ7Nw9Wq0ZRpCTDHNp3OTYmiC0mWZY5XonT GoiX8MtkNGZuflD8stfGpXYHnjOcSuRPwMHSA5kUN88o4ICGC6KdkD6Xp1PoAZRTqmlR ehFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e+BEnsBfKcVcYv17/izomO0GtYAEKezFa3/XB4mW91g=; b=lDKw7J0md49AVbIDkLp+e0m/0mM10SN0bZUeOUUsvI6kzj21KisBSAXmHuGlYstsxt AAcor3KLdJ4eomI9BKqy24wr4hlZDevwc6rPZWlhvlWoocQnwFoxrFBEMuTx0/hEpCvF JUCPhqfKbpsoGpJ2atBx1c3SX1bQp6J816kyaY3qJgLm31Y6MyTgAlpWAoau8F7OwEjE O5mMNP7RHHsIcbLDOCl9RBgf3/EztSw8dxBYKLaMzAykOKBTeyBY5Ga1Sz7TsF77Y+DZ Sj7W/LfKsXSirEM3Fh4s2ZJAXmItc+zWxyS2rEdSkhEX8PMwzy0lYmgKLOXETmRLQOIj rFfA== X-Gm-Message-State: APjAAAXp2V6qg4jfZZSWGmA+fMkWJDWlRlxMudwqw6YLFYsteYoRIs2V vvv67ZpvqisWCSg9WiabkGC8+R3r X-Google-Smtp-Source: APXvYqwtar9vwp47HdxA6RCPTp0qyVgO0F4XN3sKbOUndcoEpVLPL/nX0A6flQEVdNyz8Lajy8SkOg== X-Received: by 2002:a17:902:27e6:: with SMTP id i35mr6637131plg.190.1562875391671; Thu, 11 Jul 2019 13:03:11 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s66sm7040083pfs.8.2019.07.11.13.03.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Jul 2019 13:03:11 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Thu, 11 Jul 2019 13:03:00 -0700 Message-Id: <20190711200309.6134-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
redundant rte_vdev_driver declarations
|
|
Message
Stephen Hemminger
July 11, 2019, 8:03 p.m. UTC
Many drivers declare the local rte_vdev_driver structure multiple times. This is unnecessary. Surprised it is so common, I guess everyone copies the same code. Stephen Hemminger (9): net/tap: remove redundant declarations net/af_packet: remove redundant rte_vdev_driver declaration net/vhost: remove redundant rte_vdev_driver declaration net/null: remove redundant rte_vdev_driver declaration net/pcap: remove redundant rte_vdev_driver declaration net/ring: remove redundant rte_vdev_drive declaration net/virtio_user: remove redundant rte_vdev_driver declaration raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration drivers/net/af_packet/rte_eth_af_packet.c | 2 -- drivers/net/null/rte_eth_null.c | 2 -- drivers/net/pcap/rte_eth_pcap.c | 2 -- drivers/net/ring/rte_eth_ring.c | 2 -- drivers/net/tap/rte_eth_tap.c | 2 -- drivers/net/vhost/rte_eth_vhost.c | 2 -- drivers/net/virtio/virtio_user_ethdev.c | 2 -- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 3 --- drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 --- 9 files changed, 20 deletions(-)
Comments
On 7/11/2019 9:03 PM, Stephen Hemminger wrote: > Many drivers declare the local rte_vdev_driver structure > multiple times. This is unnecessary. > > Surprised it is so common, I guess everyone copies the same code. > > Stephen Hemminger (9): > net/tap: remove redundant declarations > net/af_packet: remove redundant rte_vdev_driver declaration > net/vhost: remove redundant rte_vdev_driver declaration > net/null: remove redundant rte_vdev_driver declaration > net/pcap: remove redundant rte_vdev_driver declaration > net/ring: remove redundant rte_vdev_drive declaration > net/virtio_user: remove redundant rte_vdev_driver declaration > raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration > raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Series applied to dpdk-next-net/master, thanks.
On 7/15/2019 5:18 PM, Ferruh Yigit wrote: > On 7/11/2019 9:03 PM, Stephen Hemminger wrote: >> Many drivers declare the local rte_vdev_driver structure >> multiple times. This is unnecessary. >> >> Surprised it is so common, I guess everyone copies the same code. It seems it is common because a patchset explicitly added them [1] to set driver name consistently, but later when another patch removed the related code [2] the forward declarations seems forgotten to be removed. I have updated commits to include the fixes lines so that they can be backported (so that they don't cause additional conflicts for more serious patches in the future.) [1]: Fixes: 73db5badb042 ("net: align ethdev and eal driver names") [2]: Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev") >> >> Stephen Hemminger (9): >> net/tap: remove redundant declarations >> net/af_packet: remove redundant rte_vdev_driver declaration >> net/vhost: remove redundant rte_vdev_driver declaration >> net/null: remove redundant rte_vdev_driver declaration >> net/pcap: remove redundant rte_vdev_driver declaration >> net/ring: remove redundant rte_vdev_drive declaration >> net/virtio_user: remove redundant rte_vdev_driver declaration >> raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration >> raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Series applied to dpdk-next-net/master, thanks. >