[1/2] Revert "bus/pci: add Mellanox kernel driver type"
Checks
Commit Message
This reverts commit 0cb86518db57d35e0abc14d6703fad561a0310e2.
The pci bus now reports DC when faced with a device bound to an unknown
driver and, in such a case, the IOVA mode is selected against physical
address availability.
As a consequence, there is no reason for this special case for Mellanox
drivers.
Fixes: 703458e19c16 ("bus/pci: consider only usable devices for IOVA mode")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/bus/pci/linux/pci.c | 8 --------
lib/librte_eal/common/include/rte_dev.h | 1 -
2 files changed, 9 deletions(-)
Comments
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, July 11, 2019 3:19 AM
> To: dev@dpdk.org
> Cc: anatoly.burakov@intel.com; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; thomas@monjalon.net
> Subject: [EXT] [PATCH 1/2] Revert "bus/pci: add Mellanox kernel driver type"
>
> This reverts commit 0cb86518db57d35e0abc14d6703fad561a0310e2.
>
> The pci bus now reports DC when faced with a device bound to an unknown
> driver and, in such a case, the IOVA mode is selected against physical address
> availability.
>
> As a consequence, there is no reason for this special case for Mellanox
> drivers.
>
> Fixes: 703458e19c16 ("bus/pci: consider only usable devices for IOVA mode")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
@@ -329,9 +329,6 @@
dev->kdrv = RTE_KDRV_IGB_UIO;
else if (!strcmp(driver, "uio_pci_generic"))
dev->kdrv = RTE_KDRV_UIO_GENERIC;
- else if (!strcmp(driver, "mlx4_core") ||
- !strcmp(driver, "mlx5_core"))
- dev->kdrv = RTE_KDRV_NIC_MLX;
else
dev->kdrv = RTE_KDRV_UNKNOWN;
} else
@@ -591,11 +588,6 @@ enum rte_iova_mode
break;
}
- case RTE_KDRV_NIC_MLX:
- if ((pdrv->drv_flags & RTE_PCI_DRV_IOVA_AS_VA) == 0)
- iova_mode = RTE_IOVA_PA;
- break;
-
case RTE_KDRV_IGB_UIO:
case RTE_KDRV_UIO_GENERIC:
iova_mode = RTE_IOVA_PA;
@@ -63,7 +63,6 @@ enum rte_kernel_driver {
RTE_KDRV_VFIO,
RTE_KDRV_UIO_GENERIC,
RTE_KDRV_NIC_UIO,
- RTE_KDRV_NIC_MLX,
RTE_KDRV_NONE,
};