Message ID | 20190705093401.69913-1-bruce.richardson@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11D201BDED; Fri, 5 Jul 2019 11:34:14 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 69ECB1BDEB for <dev@dpdk.org>; Fri, 5 Jul 2019 11:34:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2019 02:34:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,454,1557212400"; d="scan'208";a="172608213" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.2]) by FMSMGA003.fm.intel.com with ESMTP; 05 Jul 2019 02:34:09 -0700 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: thomas@monjalon.net, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, Bruce Richardson <bruce.richardson@intel.com> Date: Fri, 5 Jul 2019 10:33:59 +0100 Message-Id: <20190705093401.69913-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [RFC PATCH 0/2] standardize rawdev names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
standardize rawdev names
|
|
Message
Bruce Richardson
July 5, 2019, 9:33 a.m. UTC
The names of the rawdev drivers and the resultant libraries they built were pretty inconsistent. In terms of directory names, some had "rawdev" in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. Also, for the built .so/.a libraries, the names were not always consistent between make and meson, as, while meson enforced a consistent naming scheme, make did not, leading to differences - especially for those drivers with "rawdev" in the directory name. This patchset attempts to make things more standardized by removing "rawdev" from all directory names - the drivers are in the "drivers/raw" directory after all - and then standardizing the library names to "librte_rawdev_<name>" for both make and meson. Bruce Richardson (2): drivers/raw: remove rawdev from driver directory names drivers/raw: standardize name format of rawdev drivers drivers/raw/Makefile | 4 ++-- drivers/raw/dpaa2_cmdif/Makefile | 4 ++-- ..._version.map => rte_rawdev_dpaa2_cmdif_version.map} | 0 drivers/raw/dpaa2_qdma/Makefile | 4 ++-- ...a_version.map => rte_rawdev_dpaa2_qdma_version.map} | 0 drivers/raw/{ifpga_rawdev => ifpga}/Makefile | 6 +++--- drivers/raw/{ifpga_rawdev => ifpga}/base/Makefile | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/README | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.h | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_compat.h | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_defines.h | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.c | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.h | 0 .../{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.c | 0 .../{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme.c | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_dperf.c | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_error.c | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_iperf.c | 0 .../raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_pr.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_hw.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_port.c | 0 .../{ifpga_rawdev => ifpga}/base/ifpga_port_error.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/meson.build | 0 .../{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.c | 0 .../{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.h | 0 .../raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.c | 0 .../raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.h | 0 .../{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.c | 0 .../{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.h | 0 .../{ifpga_rawdev => ifpga}/base/opae_intel_max10.c | 0 .../{ifpga_rawdev => ifpga}/base/opae_intel_max10.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_osdep.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.h | 0 .../base/opae_spi_transaction.c | 0 .../base/osdep_raw/osdep_generic.h | 0 .../base/osdep_rte/osdep_generic.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.c | 0 drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.h | 0 drivers/raw/{ifpga_rawdev => ifpga}/meson.build | 0 .../rte_rawdev_ifpga_version.map} | 0 drivers/raw/ioat/Makefile | 4 ++-- ...md_ioat_version.map => rte_rawdev_ioat_version.map} | 0 drivers/raw/meson.build | 6 +++--- drivers/raw/{skeleton_rawdev => skeleton}/Makefile | 4 ++-- drivers/raw/{skeleton_rawdev => skeleton}/meson.build | 0 .../rte_rawdev_skeleton_version.map} | 0 .../{skeleton_rawdev => skeleton}/skeleton_rawdev.c | 0 .../{skeleton_rawdev => skeleton}/skeleton_rawdev.h | 0 .../skeleton_rawdev_test.c | 0 mk/rte.app.mk | 10 +++++----- 59 files changed, 21 insertions(+), 21 deletions(-) rename drivers/raw/dpaa2_cmdif/{rte_pmd_dpaa2_cmdif_version.map => rte_rawdev_dpaa2_cmdif_version.map} (100%) rename drivers/raw/dpaa2_qdma/{rte_pmd_dpaa2_qdma_version.map => rte_rawdev_dpaa2_qdma_version.map} (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/Makefile (82%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/Makefile (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/README (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_api.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_compat.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_defines.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_enumerate.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_feature_dev.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_dperf.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_error.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_iperf.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_fme_pr.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_hw.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_port.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/ifpga_port_error.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/meson.build (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_at24_eeprom.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_debug.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_eth_group.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_hw_api.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_i2c.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_ifpga_hw_api.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_intel_max10.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_intel_max10.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_osdep.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/opae_spi_transaction.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/osdep_raw/osdep_generic.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/base/osdep_rte/osdep_generic.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.c (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/ifpga_rawdev.h (100%) rename drivers/raw/{ifpga_rawdev => ifpga}/meson.build (100%) rename drivers/raw/{ifpga_rawdev/rte_pmd_ifpga_rawdev_version.map => ifpga/rte_rawdev_ifpga_version.map} (100%) rename drivers/raw/ioat/{rte_pmd_ioat_version.map => rte_rawdev_ioat_version.map} (100%) rename drivers/raw/{skeleton_rawdev => skeleton}/Makefile (84%) rename drivers/raw/{skeleton_rawdev => skeleton}/meson.build (100%) rename drivers/raw/{skeleton_rawdev/rte_pmd_skeleton_rawdev_version.map => skeleton/rte_rawdev_skeleton_version.map} (100%) rename drivers/raw/{skeleton_rawdev => skeleton}/skeleton_rawdev.c (100%) rename drivers/raw/{skeleton_rawdev => skeleton}/skeleton_rawdev.h (100%) rename drivers/raw/{skeleton_rawdev => skeleton}/skeleton_rawdev_test.c (100%)
Comments
On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > The names of the rawdev drivers and the resultant libraries they built > were pretty inconsistent. In terms of directory names, some had "rawdev" > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > Also, for the built .so/.a libraries, the names were not always > consistent between make and meson, as, while meson enforced a consistent > naming scheme, make did not, leading to differences - especially for > those drivers with "rawdev" in the directory name. > > This patchset attempts to make things more standardized by removing > "rawdev" from all directory names - the drivers are in the "drivers/raw" > directory after all - and then standardizing the library names to > "librte_rawdev_<name>" for both make and meson. > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > names drivers/raw: standardize name format of rawdev drivers > Since the .so/.a files we produce are changing, would this patchset - if accepted - need a deprecation notice in 19.08 for a future 19.11 merge?
05/07/2019 11:35, Bruce Richardson: > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > The names of the rawdev drivers and the resultant libraries they built > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > Also, for the built .so/.a libraries, the names were not always > > consistent between make and meson, as, while meson enforced a consistent > > naming scheme, make did not, leading to differences - especially for > > those drivers with "rawdev" in the directory name. > > > > This patchset attempts to make things more standardized by removing > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > directory after all - and then standardizing the library names to > > "librte_rawdev_<name>" for both make and meson. > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > names drivers/raw: standardize name format of rawdev drivers > > > Since the .so/.a files we produce are changing, would this patchset - if > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? I would say we can merge it in 19.08 without prior notice. Any other opinion?
05/07/2019 11:38, Thomas Monjalon: > 05/07/2019 11:35, Bruce Richardson: > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > The names of the rawdev drivers and the resultant libraries they built > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > Also, for the built .so/.a libraries, the names were not always > > > consistent between make and meson, as, while meson enforced a consistent > > > naming scheme, make did not, leading to differences - especially for > > > those drivers with "rawdev" in the directory name. > > > > > > This patchset attempts to make things more standardized by removing > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > directory after all - and then standardizing the library names to > > > "librte_rawdev_<name>" for both make and meson. > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > names drivers/raw: standardize name format of rawdev drivers > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > I would say we can merge it in 19.08 without prior notice. > Any other opinion? Cc Neil
05/07/2019 11:39, Thomas Monjalon: > 05/07/2019 11:38, Thomas Monjalon: > > 05/07/2019 11:35, Bruce Richardson: > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > The names of the rawdev drivers and the resultant libraries they built > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > Also, for the built .so/.a libraries, the names were not always > > > > consistent between make and meson, as, while meson enforced a consistent > > > > naming scheme, make did not, leading to differences - especially for > > > > those drivers with "rawdev" in the directory name. > > > > > > > > This patchset attempts to make things more standardized by removing > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > directory after all - and then standardizing the library names to > > > > "librte_rawdev_<name>" for both make and meson. > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > I would say we can merge it in 19.08 without prior notice. > > Any other opinion? > > Cc Neil We got no more opinion. Does it mean I can merge it in 19.08-rc3?
On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > 05/07/2019 11:39, Thomas Monjalon: > > 05/07/2019 11:38, Thomas Monjalon: > > > 05/07/2019 11:35, Bruce Richardson: > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > consistent between make and meson, as, while meson enforced a consistent > > > > > naming scheme, make did not, leading to differences - especially for > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > > directory after all - and then standardizing the library names to > > > > > "librte_rawdev_<name>" for both make and meson. > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > I would say we can merge it in 19.08 without prior notice. > > > Any other opinion? > > > > Cc Neil > > We got no more opinion. > Does it mean I can merge it in 19.08-rc3? > Seems like it should be safe enough to me. Rawdevs are pretty new and not that widely used, I suspect. Any issues that do arise with the rename can be resolved via symlink, so the risk is low, I suspect. Regards, /Bruce
On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > 05/07/2019 11:39, Thomas Monjalon: > > 05/07/2019 11:38, Thomas Monjalon: > > > 05/07/2019 11:35, Bruce Richardson: > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > consistent between make and meson, as, while meson enforced a consistent > > > > > naming scheme, make did not, leading to differences - especially for > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > > directory after all - and then standardizing the library names to > > > > > "librte_rawdev_<name>" for both make and meson. > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > I would say we can merge it in 19.08 without prior notice. > > > Any other opinion? > > > > Cc Neil > > We got no more opinion. > Does it mean I can merge it in 19.08-rc3? > > > Sorry, I meant to get to this and completely forgot. I presume that this is solely a name change, and not a functional change, correct? I would think if thats the case, you could just release note the switch, and distributions could all linker files with the old names to maintain compatibility. Neil
30/07/2019 14:20, Neil Horman: > On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote: > > 05/07/2019 11:39, Thomas Monjalon: > > > 05/07/2019 11:38, Thomas Monjalon: > > > > 05/07/2019 11:35, Bruce Richardson: > > > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote: > > > > > > The names of the rawdev drivers and the resultant libraries they built > > > > > > were pretty inconsistent. In terms of directory names, some had "rawdev" > > > > > > in the name, e.g. skeleton_rawdev, ifpga_rawdev, while others didn't. > > > > > > Also, for the built .so/.a libraries, the names were not always > > > > > > consistent between make and meson, as, while meson enforced a consistent > > > > > > naming scheme, make did not, leading to differences - especially for > > > > > > those drivers with "rawdev" in the directory name. > > > > > > > > > > > > This patchset attempts to make things more standardized by removing > > > > > > "rawdev" from all directory names - the drivers are in the "drivers/raw" > > > > > > directory after all - and then standardizing the library names to > > > > > > "librte_rawdev_<name>" for both make and meson. > > > > > > > > > > > > Bruce Richardson (2): drivers/raw: remove rawdev from driver directory > > > > > > names drivers/raw: standardize name format of rawdev drivers > > > > > > > > > > > Since the .so/.a files we produce are changing, would this patchset - if > > > > > accepted - need a deprecation notice in 19.08 for a future 19.11 merge? > > > > > > > > I would say we can merge it in 19.08 without prior notice. > > > > Any other opinion? > > > > > > Cc Neil > > > > We got no more opinion. > > Does it mean I can merge it in 19.08-rc3? > > > > > > > Sorry, I meant to get to this and completely forgot. > > I presume that this is solely a name change, and not a functional change, > correct? Correct > I would think if thats the case, you could just release note the switch, and > distributions could all linker files with the old names to maintain > compatibility. I am sending a v2 (rebased with new raw drivers), and adding a note in the release notes.