mbox series

[v4,0/5] hash: fix multiple issues

Message ID 1538143869-152808-1-git-send-email-yipeng1.wang@intel.com (mailing list archive)
Headers
Series hash: fix multiple issues |

Message

Wang, Yipeng1 Sept. 28, 2018, 2:11 p.m. UTC 
  This patch set was part of extendable hash table patch
set before V2. According to Bruce's comment, this patch set
is now separated from the original patch set for easier
review and merge.
https://mails.dpdk.org/archives/dev/2018-September/112555.html

This patch set fixes multiple issues/bugs from rte_hash and hash
unit test.

V3->V4:
In first commit, per Honnappa's suggestion, added comment to explain
what value should BUCKET_SIZE be.
In third commit, fix a typo: "consecutive"

V2->V3:
As Bruce suggested:
Added a new commit to add missing file into meson.build for readwrite test.
Revised the commit message for the last commit.

Yipeng Wang (5):
  test/hash: fix bucket size in hash perf test
  test/hash: more accurate hash perf test output
  test/hash: fix rw test with non-consecutive cores
  test/hash: fix missing file in meson build file
  hash: fix unused define

 lib/librte_hash/rte_cuckoo_hash.h |  2 -
 test/test/meson.build             |  1 +
 test/test/test_hash_perf.c        | 13 ++++---
 test/test/test_hash_readwrite.c   | 78 ++++++++++++++++++++++++---------------
 4 files changed, 57 insertions(+), 37 deletions(-)

Comments

Thomas Monjalon Oct. 25, 2018, 10:04 p.m. UTC | #1 
28/09/2018 16:11, Yipeng Wang:
> This patch set was part of extendable hash table patch
> set before V2. According to Bruce's comment, this patch set
> is now separated from the original patch set for easier
> review and merge.
> https://mails.dpdk.org/archives/dev/2018-September/112555.html
> 
> This patch set fixes multiple issues/bugs from rte_hash and hash
> unit test.
> 
> V3->V4:
> In first commit, per Honnappa's suggestion, added comment to explain
> what value should BUCKET_SIZE be.
> In third commit, fix a typo: "consecutive"
> 
> V2->V3:
> As Bruce suggested:
> Added a new commit to add missing file into meson.build for readwrite test.
> Revised the commit message for the last commit.
> 
> Yipeng Wang (5):
>   test/hash: fix bucket size in hash perf test
>   test/hash: more accurate hash perf test output
>   test/hash: fix rw test with non-consecutive cores
>   test/hash: fix missing file in meson build file
>   hash: fix unused define

Applied, thanks