Message ID | 20190405132455.15468-1-marcinx.hajkowski@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AD851B4DF; Fri, 5 Apr 2019 15:28:16 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3F6771B4C8 for <dev@dpdk.org>; Fri, 5 Apr 2019 15:28:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 06:28:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,312,1549958400"; d="scan'208";a="158546445" Received: from mhajkowx-mobl.ger.corp.intel.com ([10.104.116.181]) by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2019 06:28:12 -0700 From: Hajkowski <marcinx.hajkowski@intel.com> To: david.hunt@intel.com Cc: dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com> Date: Fri, 5 Apr 2019 15:24:51 +0200 Message-Id: <20190405132455.15468-1-marcinx.hajkowski@intel.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 0/4] bidirect guest channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: 20190402082121.5472-1-marcinx.hajkowski@intel.com List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | bidirect guest channel | |
Message
Marcin Hajkowski
April 5, 2019, 1:24 p.m. UTC
From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.
---
v5:
* enhance logging
v4:
* [vm_power_manager] treat 0 as valid socket id
* [guest_manager] use user level logs
* correct code formatting
v3:
* fix global_fds[lcore_id] comparison to invalid value
* check 0 to verify if read function actually read some data
* define _NACK cmd instead of _NAK
* simplify rte_power_guest_channel_receive_msg func logic
v2:
* send ack only if power operation return positive value
* log diffent error for unexpected incoming command and
error during ack/nak cmd sending
Marcin Hajkowski (4):
power: fix invalid socket indicator value
power: extend guest channel API for reading
power: process incoming confirmation cmds
power: send confirmation cmd to vm guest
examples/vm_power_manager/channel_monitor.c | 68 +++++++++++++++--
examples/vm_power_manager/guest_cli/Makefile | 1 +
.../guest_cli/vm_power_cli_guest.c | 73 +++++++++++++++----
lib/librte_power/channel_commands.h | 5 ++
lib/librte_power/guest_channel.c | 72 ++++++++++++++++--
lib/librte_power/guest_channel.h | 35 +++++++++
lib/librte_power/rte_power_version.map | 1 +
7 files changed, 230 insertions(+), 25 deletions(-)
Comments
05/04/2019 15:24, Hajkowski: > From: Marcin Hajkowski <marcinx.hajkowski@intel.com> > > Extend guest channel API to allow bidirectional > communication. Modify power manager host and guest > side to communicate in both directions. This patchset is deferred to 19.08 because of a lack of review. Note: too many librte_power patches are not reviewed.
On 22/4/2019 9:36 PM, Thomas Monjalon wrote: > 05/04/2019 15:24, Hajkowski: >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com> >> >> Extend guest channel API to allow bidirectional >> communication. Modify power manager host and guest >> side to communicate in both directions. > This patchset is deferred to 19.08 because of a lack > of review. > > Note: too many librte_power patches are not reviewed. Hi Thomas, The four remaining patch sets for power were initially submitted after the v1 deadline, and were not expected to make it into 19.05. We will be sure to review for 19.08. Regards, Dave.
24/04/2019 10:38, Hunt, David: > On 22/4/2019 9:36 PM, Thomas Monjalon wrote: > > 05/04/2019 15:24, Hajkowski: > >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com> > >> > >> Extend guest channel API to allow bidirectional > >> communication. Modify power manager host and guest > >> side to communicate in both directions. > > This patchset is deferred to 19.08 because of a lack > > of review. > > > > Note: too many librte_power patches are not reviewed. > > > Hi Thomas, > > The four remaining patch sets for power were initially submitted after > the v1 deadline, and were not expected to make it into 19.05. We will be > sure to review for 19.08. OK thanks for the confirmation. In such case, it is better to add "19.08" in the subject prefix so it is explicit from the beginning. Thanks
24/04/2019 10:44, Thomas Monjalon: > 24/04/2019 10:38, Hunt, David: > > On 22/4/2019 9:36 PM, Thomas Monjalon wrote: > > > 05/04/2019 15:24, Hajkowski: > > >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com> > > >> > > >> Extend guest channel API to allow bidirectional > > >> communication. Modify power manager host and guest > > >> side to communicate in both directions. > > > This patchset is deferred to 19.08 because of a lack > > > of review. > > > > > > Note: too many librte_power patches are not reviewed. > > > > > > Hi Thomas, > > > > The four remaining patch sets for power were initially submitted after > > the v1 deadline, and were not expected to make it into 19.05. We will be > > sure to review for 19.08. > > OK thanks for the confirmation. > In such case, it is better to add "19.08" in the subject prefix > so it is explicit from the beginning. Thanks There was no more review since April. I guess it will miss 19.08 as well.