[v5,0/4] bidirect guest channel

Message ID 20190405132455.15468-1-marcinx.hajkowski@intel.com
Headers show
Series
  • bidirect guest channel
Related show

Message

Hajkowski April 5, 2019, 1:24 p.m.
From: Marcin Hajkowski <marcinx.hajkowski@intel.com>

Extend guest channel API to allow bidirectional
communication. Modify power manager host and guest
side to communicate in both directions.

---

v5:
* enhance logging

v4:
* [vm_power_manager] treat 0 as valid socket id
* [guest_manager] use user level logs
* correct code formatting

v3:
* fix global_fds[lcore_id] comparison to invalid value
* check 0 to verify if read function actually read some data
* define _NACK cmd instead of _NAK
* simplify rte_power_guest_channel_receive_msg func logic

v2:
* send ack only if power operation return positive value
* log diffent error for unexpected incoming command and
  error during ack/nak cmd sending


Marcin Hajkowski (4):
  power: fix invalid socket indicator value
  power: extend guest channel API for reading
  power: process incoming confirmation cmds
  power: send confirmation cmd to vm guest

 examples/vm_power_manager/channel_monitor.c   | 68 +++++++++++++++--
 examples/vm_power_manager/guest_cli/Makefile  |  1 +
 .../guest_cli/vm_power_cli_guest.c            | 73 +++++++++++++++----
 lib/librte_power/channel_commands.h           |  5 ++
 lib/librte_power/guest_channel.c              | 72 ++++++++++++++++--
 lib/librte_power/guest_channel.h              | 35 +++++++++
 lib/librte_power/rte_power_version.map        |  1 +
 7 files changed, 230 insertions(+), 25 deletions(-)

Comments

Thomas Monjalon April 22, 2019, 8:36 p.m. | #1
05/04/2019 15:24, Hajkowski:
> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> 
> Extend guest channel API to allow bidirectional
> communication. Modify power manager host and guest
> side to communicate in both directions.

This patchset is deferred to 19.08 because of a lack
of review.

Note: too many librte_power patches are not reviewed.
David Hunt April 24, 2019, 8:38 a.m. | #2
On 22/4/2019 9:36 PM, Thomas Monjalon wrote:
> 05/04/2019 15:24, Hajkowski:
>> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
>>
>> Extend guest channel API to allow bidirectional
>> communication. Modify power manager host and guest
>> side to communicate in both directions.
> This patchset is deferred to 19.08 because of a lack
> of review.
>
> Note: too many librte_power patches are not reviewed.


Hi Thomas,

  The four remaining patch sets for power were initially submitted after 
the v1 deadline, and were not expected to make it into 19.05. We will be 
sure to review for 19.08.

Regards,
Dave.
Thomas Monjalon April 24, 2019, 8:44 a.m. | #3
24/04/2019 10:38, Hunt, David:
> On 22/4/2019 9:36 PM, Thomas Monjalon wrote:
> > 05/04/2019 15:24, Hajkowski:
> >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> >>
> >> Extend guest channel API to allow bidirectional
> >> communication. Modify power manager host and guest
> >> side to communicate in both directions.
> > This patchset is deferred to 19.08 because of a lack
> > of review.
> >
> > Note: too many librte_power patches are not reviewed.
> 
> 
> Hi Thomas,
> 
>   The four remaining patch sets for power were initially submitted after 
> the v1 deadline, and were not expected to make it into 19.05. We will be 
> sure to review for 19.08.

OK thanks for the confirmation.
In such case, it is better to add "19.08" in the subject prefix
so it is explicit from the beginning. Thanks
Thomas Monjalon July 4, 2019, 7:55 p.m. | #4
24/04/2019 10:44, Thomas Monjalon:
> 24/04/2019 10:38, Hunt, David:
> > On 22/4/2019 9:36 PM, Thomas Monjalon wrote:
> > > 05/04/2019 15:24, Hajkowski:
> > >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> > >>
> > >> Extend guest channel API to allow bidirectional
> > >> communication. Modify power manager host and guest
> > >> side to communicate in both directions.
> > > This patchset is deferred to 19.08 because of a lack
> > > of review.
> > >
> > > Note: too many librte_power patches are not reviewed.
> > 
> > 
> > Hi Thomas,
> > 
> >   The four remaining patch sets for power were initially submitted after 
> > the v1 deadline, and were not expected to make it into 19.05. We will be 
> > sure to review for 19.08.
> 
> OK thanks for the confirmation.
> In such case, it is better to add "19.08" in the subject prefix
> so it is explicit from the beginning. Thanks

There was no more review since April.
I guess it will miss 19.08 as well.