From patchwork Tue Aug 13 11:28:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christian Ehrhardt X-Patchwork-Id: 57655 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7FBD1BE0C; Tue, 13 Aug 2019 13:28:49 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 590B91B952 for ; Tue, 13 Aug 2019 13:28:49 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hxUyu-0005xN-Uh; Tue, 13 Aug 2019 11:28:49 +0000 From: Christian Ehrhardt To: dev Cc: Luca Boccassi , Thomas Monjalon , Frank Heimes , Christian Ehrhardt Date: Tue, 13 Aug 2019 13:28:42 +0200 Message-Id: <20190813112843.27072-1-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 0/1] PPC64 buid error in 19.08 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A build of recent DPDK 19.08 on all Ubuntu architectures returned this on ppc64: ../drivers/net/mlx4/mlx4_rxtx.c: In function ‘mlx4_tx_burst’: ../drivers/net/mlx4/mlx4_rxtx.c:919:14: error: incompatible types when initializing type ‘__vector __bool int’ {aka ‘__vector(4) __bool int’} using type ‘int’ 919 | bool tso = txq->priv->tso && (buf->ol_flags & PKT_TX_TCP_SEG); | ^~~ ../drivers/net/mlx4/mlx4_rxtx.c:938:7: error: used vector type where scalar is required 938 | if (tso) { | ^~~ Which reminds everyone of the sad caps-lock story [1] which happened on 18.08. Back then the fix was [2] and a discussion around ppc64 support state happened, given that it wasn't even build-tested before release. We might have to have the same discussion again, but for now I provided the fix for the build fail on mlx4 implemented the same way as it was done on mlx5 [2]. [1]: https://mails.dpdk.org/archives/dev/2018-August/110472.html [2]: https://git.dpdk.org/dpdk/commit/?id=725f5dd0bfb50192a2d2341d4cc69084c2c4e03d Christian Ehrhardt (1): net/mlx4: fix build on PPC64 drivers/net/mlx4/mlx4_utils.h | 10 ++++++++++ 1 file changed, 10 insertions(+)