mbox series

[v2,0/4] get Rx/Tx packet burst mode information

Message ID 20190926145444.114485-1-haiyue.wang@intel.com (mailing list archive)
Headers
Series get Rx/Tx packet burst mode information |

Message

Wang, Haiyue Sept. 26, 2019, 2:54 p.m. UTC 
  v1 -> v2:
	1). Change the return type of dev_ops callback from 'void' to
	    'int'.
	2). Update the ice/i40 PMD patches with clear git commit log.

RFCv3 -> v1:
	https://patchwork.dpdk.org/patch/59103/
	https://patchwork.dpdk.org/patch/59104/
	https://patchwork.dpdk.org/patch/59105/
	https://patchwork.dpdk.org/patch/59106/
	1). Use the function 'rte_bsf64' to iterate the options for
	    getting the name.

Haiyue Wang (4):
  ethdev: add the API for getting burst mode information
  net/i40e: add Rx/Tx burst mode get callbacks
  net/ice: add Rx/Tx burst mode get callbacks
  app/testpmd: show the Rx/Tx burst mode description

 app/test-pmd/config.c                    | 29 +++++++++
 doc/guides/rel_notes/release_19_11.rst   |  9 +++
 drivers/net/i40e/i40e_ethdev.c           |  2 +
 drivers/net/i40e/i40e_ethdev.h           |  4 ++
 drivers/net/i40e/i40e_rxtx.c             | 76 ++++++++++++++++++++++
 drivers/net/ice/ice_ethdev.c             |  2 +
 drivers/net/ice/ice_rxtx.c               | 58 +++++++++++++++++
 drivers/net/ice/ice_rxtx.h               |  4 ++
 lib/librte_ethdev/rte_ethdev.c           | 71 ++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev.h           | 82 ++++++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev_core.h      |  5 ++
 lib/librte_ethdev/rte_ethdev_version.map |  5 ++
 12 files changed, 347 insertions(+)

Comments

Xiaolong Ye Sept. 27, 2019, 8:14 a.m. UTC | #1 
On 09/26, Haiyue Wang wrote:
>v1 -> v2:
>	1). Change the return type of dev_ops callback from 'void' to
>	    'int'.
>	2). Update the ice/i40 PMD patches with clear git commit log.
>
>RFCv3 -> v1:
>	https://patchwork.dpdk.org/patch/59103/
>	https://patchwork.dpdk.org/patch/59104/
>	https://patchwork.dpdk.org/patch/59105/
>	https://patchwork.dpdk.org/patch/59106/
>	1). Use the function 'rte_bsf64' to iterate the options for
>	    getting the name.
>
>Haiyue Wang (4):
>  ethdev: add the API for getting burst mode information
>  net/i40e: add Rx/Tx burst mode get callbacks
>  net/ice: add Rx/Tx burst mode get callbacks
>  app/testpmd: show the Rx/Tx burst mode description
>
> app/test-pmd/config.c                    | 29 +++++++++
> doc/guides/rel_notes/release_19_11.rst   |  9 +++
> drivers/net/i40e/i40e_ethdev.c           |  2 +
> drivers/net/i40e/i40e_ethdev.h           |  4 ++
> drivers/net/i40e/i40e_rxtx.c             | 76 ++++++++++++++++++++++
> drivers/net/ice/ice_ethdev.c             |  2 +
> drivers/net/ice/ice_rxtx.c               | 58 +++++++++++++++++
> drivers/net/ice/ice_rxtx.h               |  4 ++
> lib/librte_ethdev/rte_ethdev.c           | 71 ++++++++++++++++++++
> lib/librte_ethdev/rte_ethdev.h           | 82 ++++++++++++++++++++++++
> lib/librte_ethdev/rte_ethdev_core.h      |  5 ++
> lib/librte_ethdev/rte_ethdev_version.map |  5 ++
> 12 files changed, 347 insertions(+)
>
>-- 
>2.17.1
>

For series:

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Ferruh Yigit Oct. 14, 2019, 12:11 p.m. UTC | #2 
On 9/26/2019 3:54 PM, Haiyue Wang wrote:
> v1 -> v2:
> 	1). Change the return type of dev_ops callback from 'void' to
> 	    'int'.
> 	2). Update the ice/i40 PMD patches with clear git commit log.
> 
> RFCv3 -> v1:
> 	https://patchwork.dpdk.org/patch/59103/
> 	https://patchwork.dpdk.org/patch/59104/
> 	https://patchwork.dpdk.org/patch/59105/
> 	https://patchwork.dpdk.org/patch/59106/
> 	1). Use the function 'rte_bsf64' to iterate the options for
> 	    getting the name.
> 
> Haiyue Wang (4):
>   ethdev: add the API for getting burst mode information
>   net/i40e: add Rx/Tx burst mode get callbacks
>   net/ice: add Rx/Tx burst mode get callbacks
>   app/testpmd: show the Rx/Tx burst mode description

Hi Haiyue,

Overall lgtm, but what do you think adding a new feature to default.ini for
this, something like 'Burst mode info"?

And i40e and ixgbe patches can add this feature to the PMD .ini files.

Also please remind 'doc/guides/nics/features.rst' also needs to be updated with
default.ini update.

Thanks,
ferruh
Wang, Haiyue Oct. 14, 2019, 1:50 p.m. UTC | #3 
Hi, Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, October 14, 2019 20:12
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: Kinsella, Ray <ray.kinsella@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Sun,
> Chenmin <chenmin.sun@intel.com>
> Subject: Re: [PATCH v2 0/4] get Rx/Tx packet burst mode information
> 
> On 9/26/2019 3:54 PM, Haiyue Wang wrote:
> > v1 -> v2:
> > 	1). Change the return type of dev_ops callback from 'void' to
> > 	    'int'.
> > 	2). Update the ice/i40 PMD patches with clear git commit log.
> >
> > RFCv3 -> v1:
> > 	https://patchwork.dpdk.org/patch/59103/
> > 	https://patchwork.dpdk.org/patch/59104/
> > 	https://patchwork.dpdk.org/patch/59105/
> > 	https://patchwork.dpdk.org/patch/59106/
> > 	1). Use the function 'rte_bsf64' to iterate the options for
> > 	    getting the name.
> >
> > Haiyue Wang (4):
> >   ethdev: add the API for getting burst mode information
> >   net/i40e: add Rx/Tx burst mode get callbacks
> >   net/ice: add Rx/Tx burst mode get callbacks
> >   app/testpmd: show the Rx/Tx burst mode description
> 
> Hi Haiyue,
> 
> Overall lgtm, but what do you think adding a new feature to default.ini for
> this, something like 'Burst mode info"?
> 
> And i40e and ixgbe patches can add this feature to the PMD .ini files.
> 
> Also please remind 'doc/guides/nics/features.rst' also needs to be updated with
> default.ini update.
> 

No problem, I will update it in v3.

> Thanks,
> ferruh