mbox series

[v2,0/2] pdump: cleanups

Message ID 20191108164717.7708-1-stephen@networkplumber.org (mailing list archive)
Headers
Series pdump: cleanups |

Message

Stephen Hemminger Nov. 8, 2019, 4:47 p.m. UTC 
  These are a couple of small cleanups for 19.10 which
came out of work on pcapng support. Full pcapng support
and BPF are planned for DPDK 20.02.

Stephen Hemminger (2):
  pdump: use new pktmbuf copy function
  pdump: use dynamic logtype

 lib/librte_pdump/rte_pdump.c | 139 ++++++++++-------------------------
 1 file changed, 40 insertions(+), 99 deletions(-)

v2 - replace new log message from info_get as well

Comments

David Marchand Nov. 12, 2019, 8:37 p.m. UTC | #1 
On Fri, Nov 8, 2019 at 5:47 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> These are a couple of small cleanups for 19.10 which

Stephen, we might be a bit late for this release, but it is still 19.11 :-)

> came out of work on pcapng support. Full pcapng support
> and BPF are planned for DPDK 20.02.
>
> Stephen Hemminger (2):
>   pdump: use new pktmbuf copy function
>   pdump: use dynamic logtype
>
>  lib/librte_pdump/rte_pdump.c | 139 ++++++++++-------------------------
>  1 file changed, 40 insertions(+), 99 deletions(-)
>
> v2 - replace new log message from info_get as well

Overall looks good.
Reshma, review please.


Thanks.
Pattan, Reshma Nov. 15, 2019, 12:50 p.m. UTC | #2 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> Sent: Friday, November 8, 2019 4:47 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups
> 
> These are a couple of small cleanups for 19.10 which came out of work on
> pcapng support. Full pcapng support and BPF are planned for DPDK 20.02.
> 
> Stephen Hemminger (2):
>   pdump: use new pktmbuf copy function
>   pdump: use dynamic logtype
> 
>  lib/librte_pdump/rte_pdump.c | 139 ++++++++++-------------------------
>  1 file changed, 40 insertions(+), 99 deletions(-)
> 
> v2 - replace new log message from info_get as well
> 
> --
> 2.20.1
Looks good to me.
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
David Marchand Feb. 5, 2020, 8:20 p.m. UTC | #3 
On Fri, Nov 15, 2019 at 1:51 PM Pattan, Reshma <reshma.pattan@intel.com> wrote:
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> > Sent: Friday, November 8, 2019 4:47 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Subject: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups
> >
> > These are a couple of small cleanups for 19.10 which came out of work on
> > pcapng support. Full pcapng support and BPF are planned for DPDK 20.02.
> >
> > Stephen Hemminger (2):
> >   pdump: use new pktmbuf copy function
> >   pdump: use dynamic logtype
> >
> >  lib/librte_pdump/rte_pdump.c | 139 ++++++++++-------------------------
> >  1 file changed, 40 insertions(+), 99 deletions(-)
> >
> > v2 - replace new log message from info_get as well
> >
> > --
> > 2.20.1
> Looks good to me.
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Series applied, thanks.


--
David Marchand
Bill Zhou June 11, 2020, 8:46 a.m. UTC | #4 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Stephen Hemminger
> Sent: Friday, November 8, 2019 4:47 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH v2 0/2] pdump: cleanups
> 
> These are a couple of small cleanups for 19.10 which came out of work on
> pcapng support. Full pcapng support and BPF are planned for DPDK 20.02.
> 
> Stephen Hemminger (2):
>   pdump: use new pktmbuf copy function
>   pdump: use dynamic logtype

Hi luca, will this patch be in 19.11.3 stable release?