[v11,00/24] ethdev: allow unknown link speed
mbox series

Message ID 20200915190728.18143-1-i.dyukov@samsung.com
Headers show
Series
  • ethdev: allow unknown link speed
Related show

Message

Ivan Dyukov Sept. 15, 2020, 7:06 p.m. UTC
MAINTAINERS                                              |   1 +
 app/proc-info/main.c                                     |  11 ++---
 app/test-pipeline/init.c                                 |  11 ++---
 app/test-pmd/config.c                                    |   9 ++--
 app/test-pmd/testpmd.c                                   |  12 ++---
 app/test/Makefile                                        |   3 ++
 app/test/meson.build                                     |   2 +
 app/test/test_ethdev_link.c                              | 169 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 app/test/test_pmd_perf.c                                 |  17 +++----
 doc/guides/sample_app_ug/link_status_intr.rst            |  10 ++--
 drivers/net/i40e/i40e_ethdev.c                           |   5 +-
 drivers/net/i40e/i40e_ethdev_vf.c                        |  10 ++--
 drivers/net/ice/ice_ethdev.c                             |   5 +-
 drivers/net/ixgbe/ixgbe_ethdev.c                         |   6 +--
 examples/bbdev_app/main.c                                |   6 ++-
 examples/ioat/ioatfwd.c                                  |  14 +++---
 examples/ip_fragmentation/main.c                         |  13 ++----
 examples/ip_pipeline/cli.c                               |   4 +-
 examples/ip_reassembly/main.c                            |  13 ++----
 examples/ipsec-secgw/ipsec-secgw.c                       |  13 ++----
 examples/ipv4_multicast/main.c                           |  14 +++---
 examples/kni/main.c                                      |  27 ++++-------
 examples/l2fwd-crypto/main.c                             |  13 ++----
 examples/l2fwd-event/main.c                              |  13 ++----
 examples/l2fwd-jobstats/main.c                           |  13 ++----
 examples/l2fwd-keepalive/main.c                          |  13 ++----
 examples/l2fwd/main.c                                    |  13 ++----
 examples/l3fwd-acl/main.c                                |  13 ++----
 examples/l3fwd-graph/main.c                              |  15 ++----
 examples/l3fwd-power/main.c                              |  14 ++----
 examples/l3fwd/main.c                                    |  13 ++----
 examples/link_status_interrupt/main.c                    |  30 +++++-------
 examples/multi_process/client_server_mp/mp_server/init.c |  15 +++---
 examples/multi_process/symmetric_mp/main.c               |  13 ++----
 examples/ntb/ntb_fwd.c                                   |  11 +++--
 examples/performance-thread/l3fwd-thread/main.c          |  13 ++----
 examples/qos_sched/init.c                                |  12 ++---
 examples/server_node_efd/server/init.c                   |  15 ++----
 examples/vm_power_manager/main.c                         |  14 ++----
 lib/librte_ethdev/rte_ethdev.c                           |  37 +++++++++++++++
 lib/librte_ethdev/rte_ethdev.h                           |  52 +++++++++++++++++----
 lib/librte_ethdev/rte_ethdev_version.map                 |   4 ++
 42 files changed, 439 insertions(+), 272 deletions(-)


v11 changes:
* 0 Mbps =>  None
* Invalid speed => Invalid
* Change code style of rte_eth_link_speed_to_str

v10 changes:
* remove format string arg from rte_eth_link_to_str function
* add rte_eth_link_speed_to_str function
* add usage of rte_eth_link_speed_to_str in examples

v9 changes:
* remove rte_eth_link_printf function
* add ETH_LINK_MAX_STR_LEN definition
* add usage of ETH_LINK_MAX_STR_LEN in examples

v8 changes:
* rename rte_eth_link_strf to rte_eth_link_to_str
* refactor rte_eth_link_to_str according to review comments
* fix codestyle
* fix commit message in 02 patch
* fix compile error in ntb application
* merge "app" and "doc" commits

v7 changes:
* fix meson build
* change _strf function. now it does not fails in case of unknown specifiers like %d. it just copy it to target string.
* remove invalid_fmt unit test.
* add unknown specifier test.
* fix codestyle

v6 changes:
* fix spelling in comments according to checkpatch warning

v5 changes:
* rename rte_eth_link_format to rte_eth_link_strf
* add '\n' to default strings
* update remaining examples. patch with subj 'examples: new link status print format' contains examples which have no maintainers.
TBD:
update remaining nic drivers with 'unknown' speed.  It should be provided in separate patchset.

v4 changes:
* refactor rte_eth_link_format using strlcat func instead of snprintf
* added new checks to unit tests
* few minor fixes according review comments
TBD:
update examples in 'example' folder with new status printing mechanism
update remaining nic drivers with 'unknown' speed

v3 changes:
* remove rte_eth_link_prepare_text function
* add rte_eth_link_format and rte_eth_link_printf functions
* added unit tests for rte_eth_link_format function
TBD:
update examples in 'example' folder with new status printing mechanism
update remaining nic drivers with 'unknown' speed

v2 changes:
* add function which format link status to textual representation
* update drivers for Intel nics with 'unknown' speed
TBD:
update examples in 'example' folder with new status printing mechanism
update remaining nic drivers with 'unknown' speed

v1 changes:
This is initial patchset which introduces UNKNOWN speed to dpdk
applications. Also it contains changes related to printf formating.
Patchset contains changes for app/ and doc/ folders.
examples/ folder will be provided later.

Comments

Ferruh Yigit Sept. 18, 2020, 5:23 p.m. UTC | #1
On 9/15/2020 8:06 PM, Ivan Dyukov wrote:
<...>

> 
> v11 changes:
> * 0 Mbps =>  None
> * Invalid speed => Invalid
> * Change code style of rte_eth_link_speed_to_str
> 
> v10 changes:
> * remove format string arg from rte_eth_link_to_str function
> * add rte_eth_link_speed_to_str function
> * add usage of rte_eth_link_speed_to_str in examples
> 
> v9 changes:
> * remove rte_eth_link_printf function
> * add ETH_LINK_MAX_STR_LEN definition
> * add usage of ETH_LINK_MAX_STR_LEN in examples
> 
> v8 changes:
> * rename rte_eth_link_strf to rte_eth_link_to_str
> * refactor rte_eth_link_to_str according to review comments
> * fix codestyle
> * fix commit message in 02 patch
> * fix compile error in ntb application
> * merge "app" and "doc" commits
> 
> v7 changes:
> * fix meson build
> * change _strf function. now it does not fails in case of unknown specifiers like %d. it just copy it to target string.
> * remove invalid_fmt unit test.
> * add unknown specifier test.
> * fix codestyle
> 
> v6 changes:
> * fix spelling in comments according to checkpatch warning
> 
> v5 changes:
> * rename rte_eth_link_format to rte_eth_link_strf
> * add '\n' to default strings
> * update remaining examples. patch with subj 'examples: new link status print format' contains examples which have no maintainers.
> TBD:
> update remaining nic drivers with 'unknown' speed.  It should be provided in separate patchset.
> 
> v4 changes:
> * refactor rte_eth_link_format using strlcat func instead of snprintf
> * added new checks to unit tests
> * few minor fixes according review comments
> TBD:
> update examples in 'example' folder with new status printing mechanism
> update remaining nic drivers with 'unknown' speed
> 
> v3 changes:
> * remove rte_eth_link_prepare_text function
> * add rte_eth_link_format and rte_eth_link_printf functions
> * added unit tests for rte_eth_link_format function
> TBD:
> update examples in 'example' folder with new status printing mechanism
> update remaining nic drivers with 'unknown' speed
> 
> v2 changes:
> * add function which format link status to textual representation
> * update drivers for Intel nics with 'unknown' speed
> TBD:
> update examples in 'example' folder with new status printing mechanism
> update remaining nic drivers with 'unknown' speed
> 
> v1 changes:
> This is initial patchset which introduces UNKNOWN speed to dpdk
> applications. Also it contains changes related to printf formating.
> Patchset contains changes for app/ and doc/ folders.
> examples/ folder will be provided later.
> 
> 

The ethdev patch introduces 'ETH_SPEED_NUM_UNKNOWN' and driver patches 
were already merged from previous version. Will get the remaining ones.
Ferruh Yigit Sept. 18, 2020, 6:47 p.m. UTC | #2
On 9/18/2020 6:23 PM, Ferruh Yigit wrote:
> On 9/15/2020 8:06 PM, Ivan Dyukov wrote:
> <...>
> 
>>
>> v11 changes:
>> * 0 Mbps =>  None
>> * Invalid speed => Invalid
>> * Change code style of rte_eth_link_speed_to_str
>>
>> v10 changes:
>> * remove format string arg from rte_eth_link_to_str function
>> * add rte_eth_link_speed_to_str function
>> * add usage of rte_eth_link_speed_to_str in examples
>>
>> v9 changes:
>> * remove rte_eth_link_printf function
>> * add ETH_LINK_MAX_STR_LEN definition
>> * add usage of ETH_LINK_MAX_STR_LEN in examples
>>
>> v8 changes:
>> * rename rte_eth_link_strf to rte_eth_link_to_str
>> * refactor rte_eth_link_to_str according to review comments
>> * fix codestyle
>> * fix commit message in 02 patch
>> * fix compile error in ntb application
>> * merge "app" and "doc" commits
>>
>> v7 changes:
>> * fix meson build
>> * change _strf function. now it does not fails in case of unknown 
>> specifiers like %d. it just copy it to target string.
>> * remove invalid_fmt unit test.
>> * add unknown specifier test.
>> * fix codestyle
>>
>> v6 changes:
>> * fix spelling in comments according to checkpatch warning
>>
>> v5 changes:
>> * rename rte_eth_link_format to rte_eth_link_strf
>> * add '\n' to default strings
>> * update remaining examples. patch with subj 'examples: new link 
>> status print format' contains examples which have no maintainers.
>> TBD:
>> update remaining nic drivers with 'unknown' speed.  It should be 
>> provided in separate patchset.
>>
>> v4 changes:
>> * refactor rte_eth_link_format using strlcat func instead of snprintf
>> * added new checks to unit tests
>> * few minor fixes according review comments
>> TBD:
>> update examples in 'example' folder with new status printing mechanism
>> update remaining nic drivers with 'unknown' speed
>>
>> v3 changes:
>> * remove rte_eth_link_prepare_text function
>> * add rte_eth_link_format and rte_eth_link_printf functions
>> * added unit tests for rte_eth_link_format function
>> TBD:
>> update examples in 'example' folder with new status printing mechanism
>> update remaining nic drivers with 'unknown' speed
>>
>> v2 changes:
>> * add function which format link status to textual representation
>> * update drivers for Intel nics with 'unknown' speed
>> TBD:
>> update examples in 'example' folder with new status printing mechanism
>> update remaining nic drivers with 'unknown' speed
>>
>> v1 changes:
>> This is initial patchset which introduces UNKNOWN speed to dpdk
>> applications. Also it contains changes related to printf formating.
>> Patchset contains changes for app/ and doc/ folders.
>> examples/ folder will be provided later.
>>
>>
> 
> The ethdev patch introduces 'ETH_SPEED_NUM_UNKNOWN' and driver patches 
> were already merged from previous version. Will get the remaining ones.
 >

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

The comments on the patches fixed while merging.

All example patches squashed into single commit.


Series applied to dpdk-next-net/main, thanks.