[v6,0/7]
mbox series

Message ID 20200920114856.20697-1-feifei.wang2@arm.com
Headers show
Series
  • [v6,1/7] test/ring: fix wrong parameter passed to the enqueue APIs
Related show

Message

Feifei Wang Sept. 20, 2020, 11:48 a.m. UTC
Several bugs in ring unit tests were identified and fixed.

Added data validation on objects after enqueue/dequeue operations for
data integration check.

Unit tests were enhanced by checking return value of enqueue/dequeue
operations and validating data integrity of objects.

v2:
1. add check to validate the dequeued objects in test_ring.c and fix
some bugs of it. (David/Honnappa)
2. remove the patch to change the description for the param of
rte_ring_[sp/mp]_enqueue APIs. (David/Konstantin/Honnappa)

v3:
1. Adjust the 'check dequeued objects' patch from the last to the first
in the series. (Honnappa)
2. Add the new function 'test_ring_mem_cmp to replace 'memset' and print
information of enqueue/dequeue elements if validation fails. (Honnappa)
3. Add test to validate the whether the enqueue and dequeue operation is
successful for each time. (Honnappa)
4. Expand the scope of application for the macro TEST_RING_VERIF, and
replace all ring APIs check with this macro. (Honnappa)

v4:
1. Split the 'memcmp' bug fix patch into two patches, one is memcmp
issue patch, the other is to add new function 'test_ring_mem_cmp'.
(Honnappa)

v5:
1. Adjust bug fixed patches to the first of the series, to ensure that
the back porting will go smooth. (Honnappa)

v6:
1. Add extra parameter to the macro. (Konstantin)

Feifei Wang (7):
  test/ring: fix wrong parameter passed to the enqueue APIs
  test/ring: fix wrong number of enq/deq elements
  test/ring: fix wrong size used in memcmp
  test/ring: add check to validate dequeued objects
  test/ring: validate the return value of enq/deq elements
  test/ring: add new function to validate dequeue data
  test/ring: improve the application of macro

 app/test/test_ring.c | 362 ++++++++++++++++++++++---------------------
 app/test/test_ring.h |   6 +-
 2 files changed, 192 insertions(+), 176 deletions(-)

Comments

Ananyev, Konstantin Sept. 20, 2020, 3:18 p.m. UTC | #1
> Several bugs in ring unit tests were identified and fixed.
> 
> Added data validation on objects after enqueue/dequeue operations for
> data integration check.
> 
> Unit tests were enhanced by checking return value of enqueue/dequeue
> operations and validating data integrity of objects.
> 
> v2:
> 1. add check to validate the dequeued objects in test_ring.c and fix
> some bugs of it. (David/Honnappa)
> 2. remove the patch to change the description for the param of
> rte_ring_[sp/mp]_enqueue APIs. (David/Konstantin/Honnappa)
> 
> v3:
> 1. Adjust the 'check dequeued objects' patch from the last to the first
> in the series. (Honnappa)
> 2. Add the new function 'test_ring_mem_cmp to replace 'memset' and print
> information of enqueue/dequeue elements if validation fails. (Honnappa)
> 3. Add test to validate the whether the enqueue and dequeue operation is
> successful for each time. (Honnappa)
> 4. Expand the scope of application for the macro TEST_RING_VERIF, and
> replace all ring APIs check with this macro. (Honnappa)
> 
> v4:
> 1. Split the 'memcmp' bug fix patch into two patches, one is memcmp
> issue patch, the other is to add new function 'test_ring_mem_cmp'.
> (Honnappa)
> 
> v5:
> 1. Adjust bug fixed patches to the first of the series, to ensure that
> the back porting will go smooth. (Honnappa)
> 
> v6:
> 1. Add extra parameter to the macro. (Konstantin)
> 
> Feifei Wang (7):
>   test/ring: fix wrong parameter passed to the enqueue APIs
>   test/ring: fix wrong number of enq/deq elements
>   test/ring: fix wrong size used in memcmp
>   test/ring: add check to validate dequeued objects
>   test/ring: validate the return value of enq/deq elements
>   test/ring: add new function to validate dequeue data
>   test/ring: improve the application of macro
> 
>  app/test/test_ring.c | 362 ++++++++++++++++++++++---------------------
>  app/test/test_ring.h |   6 +-
>  2 files changed, 192 insertions(+), 176 deletions(-)

Series acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> --
> 2.17.1
David Marchand Sept. 23, 2020, 9:24 a.m. UTC | #2
On Sun, Sep 20, 2020 at 1:49 PM Feifei Wang <feifei.wang2@arm.com> wrote:
>
> Several bugs in ring unit tests were identified and fixed.
>
> Added data validation on objects after enqueue/dequeue operations for
> data integration check.
>
> Unit tests were enhanced by checking return value of enqueue/dequeue
> operations and validating data integrity of objects.
>

Series applied, thanks for the effort on debugging and improving this ut.