[v2,0/7] dpdk-pmdinfo: python lint cleanups
mbox series

Message ID 20201104064842.25832-1-stephen@networkplumber.org
Headers show
Series
  • dpdk-pmdinfo: python lint cleanups
Related show

Message

Stephen Hemminger Nov. 4, 2020, 6:48 a.m. UTC 
Ran dpdk-pmdinfo through Python3 lint and it had lots of complaints.
These are the obvious simple ones to fix. Skipped adding docstrings
everywhere and doing large scale variable recasing.

v2 - split out the pmdinfo specific part
     incorporate feedback from Bruce about last use of len()

Stephen Hemminger (7):
  dpdk-pmdinfo: replace string.split with split
  dpdk-pmdinfo: replace io.open with open
  dpdk-pmdinfo: remove unnecessary paren and else
  dpdk-pmdinfo: replace is False and is True
  dpdk-pmdinfo: fix indentation
  dpdk-pmdinfo: replace deprecated optparse with argparse
  dpdk-pmdinfo: do not use len(x) to test for empty

 usertools/dpdk-pmdinfo.py | 132 ++++++++++++++++++--------------------
 1 file changed, 61 insertions(+), 71 deletions(-)

Comments

Thomas Monjalon Nov. 22, 2020, 8:54 p.m. UTC | #1 
04/11/2020 07:48, Stephen Hemminger:
> Ran dpdk-pmdinfo through Python3 lint and it had lots of complaints.
> These are the obvious simple ones to fix. Skipped adding docstrings
> everywhere and doing large scale variable recasing.
> 
> v2 - split out the pmdinfo specific part
>      incorporate feedback from Bruce about last use of len()
> 
> Stephen Hemminger (7):
>   dpdk-pmdinfo: replace string.split with split
>   dpdk-pmdinfo: replace io.open with open
>   dpdk-pmdinfo: remove unnecessary paren and else
>   dpdk-pmdinfo: replace is False and is True
>   dpdk-pmdinfo: fix indentation
>   dpdk-pmdinfo: replace deprecated optparse with argparse
>   dpdk-pmdinfo: do not use len(x) to test for empty

Applied, thanks