[v1] net/iavf: remove the extra symbol '+'
Checks
Commit Message
This extra symbol '+' should be added when patch was reapplied, and the
compiler treats it as unsigned type, so the code still runs well.
Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message")
Cc: stable@dpdk.org
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, December 16, 2021 12:44 PM
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Sinha, Abhijit
> <abhijit.sinha@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>
> Subject: [PATCH v1] net/iavf: remove the extra symbol '+'
>
> This extra symbol '+' should be added when patch was reapplied, and the
> compiler treats it as unsigned type, so the code still runs well.
>
> Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel
> message")
> Cc: stable@dpdk.org
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/iavf/iavf_vchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 145b059837..8fdd6f6d91 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
> VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
> VIRTCHNL_VF_LARGE_NUM_QPAIRS |
> VIRTCHNL_VF_OFFLOAD_QOS |
> -+ VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> + VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
>
> args.in_args = (uint8_t *)∩︀
> args.in_args_size = sizeof(caps);
> --
> 2.34.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
On 12/16/2021 4:43 AM, Haiyue Wang wrote:
> This extra symbol '+' should be added when patch was reapplied, and the
> compiler treats it as unsigned type, so the code still runs well.
>
> Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message")
> Cc:stable@dpdk.org
>
> Signed-off-by: Haiyue Wang<haiyue.wang@intel.com>
> ---
> drivers/net/iavf/iavf_vchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
> index 145b059837..8fdd6f6d91 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
> VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
> VIRTCHNL_VF_LARGE_NUM_QPAIRS |
> VIRTCHNL_VF_OFFLOAD_QOS |
> -+ VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> + VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
>
> args.in_args = (uint8_t *)∩︀
> args.in_args_size = sizeof(caps);
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Thursday, December 16, 2021 1:49 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Sinha, Abhijit
> <abhijit.sinha@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>
> Subject: RE: [PATCH v1] net/iavf: remove the extra symbol '+'
>
>
>
> > -----Original Message-----
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > Sent: Thursday, December 16, 2021 12:44 PM
> > To: dev@dpdk.org
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org; Wu,
> > Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Sinha, Abhijit <abhijit.sinha@intel.com>;
> > Doherty, Declan <declan.doherty@intel.com>; Nicolau, Radu
> > <radu.nicolau@intel.com>
> > Subject: [PATCH v1] net/iavf: remove the extra symbol '+'
> >
> > This extra symbol '+' should be added when patch was reapplied, and
> > the compiler treats it as unsigned type, so the code still runs well.
> >
> > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel
> > message")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> > drivers/net/iavf/iavf_vchnl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/iavf/iavf_vchnl.c
> > b/drivers/net/iavf/iavf_vchnl.c index
> > 145b059837..8fdd6f6d91 100644
> > --- a/drivers/net/iavf/iavf_vchnl.c
> > +++ b/drivers/net/iavf/iavf_vchnl.c
> > @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
> > VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
> > VIRTCHNL_VF_LARGE_NUM_QPAIRS |
> > VIRTCHNL_VF_OFFLOAD_QOS |
> > -+ VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> > + VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> >
> > args.in_args = (uint8_t *)∩︀
> > args.in_args_size = sizeof(caps);
> > --
> > 2.34.1
>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
VIRTCHNL_VF_LARGE_NUM_QPAIRS |
VIRTCHNL_VF_OFFLOAD_QOS |
-+ VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
+ VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
args.in_args = (uint8_t *)∩︀
args.in_args_size = sizeof(caps);