diff mbox series

eventdev/eth_rx: fix memory leak when token parsing finished

Message ID tencent_7F6E319F3CF5A71211493A97DF15231B2208@qq.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series eventdev/eth_rx: fix memory leak when token parsing finished |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/github-robot: build fail github build: failed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing fail Testing issues
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-aarch64-compile-testing fail Testing issues
ci/iol-abi-testing warning Testing issues

Commit Message

Weiguo Li Feb. 2, 2022, 6:15 a.m. UTC 
  The memory get from strdup should be freed when parameter parsing
finished, and also should be freed when error occurs.

Fixes: 814d01709328 ("eventdev/eth_rx: support telemetry")
Fixes: 9e583185318f ("eventdev/eth_rx: support telemetry")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index ae1e260c08..4173a52981 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3338,6 +3338,7 @@  handle_rxa_get_queue_conf(const char *cmd __rte_unused,
 
 	token = strtok(NULL, ",");
 	if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+		free(l_params);
 		return -1;
 
 	/* Get device ID from parameter string */
@@ -3346,12 +3347,14 @@  handle_rxa_get_queue_conf(const char *cmd __rte_unused,
 
 	token = strtok(NULL, ",");
 	if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+		free(l_params);
 		return -1;
 
 	/* Get Rx queue ID from parameter string */
 	rx_queue_id = strtoul(token, NULL, 10);
 	if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
 		RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+		free(l_params);
 		return -EINVAL;
 	}
 
@@ -3359,6 +3362,8 @@  handle_rxa_get_queue_conf(const char *cmd __rte_unused,
 	if (token != NULL)
 		RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
 				 " telemetry command, ignoring");
+	/* Parsing parameter finished */
+	free(l_params);
 
 	if (rte_event_eth_rx_adapter_queue_conf_get(rx_adapter_id, eth_dev_id,
 						    rx_queue_id, &queue_conf)) {
@@ -3402,6 +3407,7 @@  handle_rxa_get_queue_stats(const char *cmd __rte_unused,
 
 	token = strtok(NULL, ",");
 	if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+		free(l_params);
 		return -1;
 
 	/* Get device ID from parameter string */
@@ -3410,12 +3416,14 @@  handle_rxa_get_queue_stats(const char *cmd __rte_unused,
 
 	token = strtok(NULL, ",");
 	if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+		free(l_params);
 		return -1;
 
 	/* Get Rx queue ID from parameter string */
 	rx_queue_id = strtoul(token, NULL, 10);
 	if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
 		RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+		free(l_params);
 		return -EINVAL;
 	}
 
@@ -3423,6 +3431,8 @@  handle_rxa_get_queue_stats(const char *cmd __rte_unused,
 	if (token != NULL)
 		RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
 				 " telemetry command, ignoring");
+	/* Parsing parameter finished */
+	free(l_params);
 
 	if (rte_event_eth_rx_adapter_queue_stats_get(rx_adapter_id, eth_dev_id,
 						    rx_queue_id, &q_stats)) {
@@ -3464,6 +3474,7 @@  handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
 
 	token = strtok(NULL, ",");
 	if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+		free(l_params);
 		return -1;
 
 	/* Get device ID from parameter string */
@@ -3472,12 +3483,14 @@  handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
 
 	token = strtok(NULL, ",");
 	if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+		free(l_params);
 		return -1;
 
 	/* Get Rx queue ID from parameter string */
 	rx_queue_id = strtoul(token, NULL, 10);
 	if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
 		RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+		free(l_params);
 		return -EINVAL;
 	}
 
@@ -3485,6 +3498,8 @@  handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
 	if (token != NULL)
 		RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
 				 " telemetry command, ignoring");
+	/* Parsing parameter finished */
+	free(l_params);
 
 	if (rte_event_eth_rx_adapter_queue_stats_reset(rx_adapter_id,
 						       eth_dev_id,