diff mbox series

[v4] raw/ntb: clear all valid DB bits when DB init

Message ID 20220210070634.689869-1-junfeng.guo@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v4] raw/ntb: clear all valid DB bits when DB init |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Junfeng Guo Feb. 10, 2022, 7:06 a.m. UTC 
  Before registering the doorbell interrupt handler callback function,
all the valid doorbell bits within the NTB private data struct should
be cleared to avoid the confusion of the handshake timing sequence
diagram when setting up the NTB connection in back-to-back mode.

Fixes: 62012a76811e ("raw/ntb: add handshake process")
Cc: stable@dpdk.org

v2: fix typo
v3: fix coding style issue
v4: add ops check before calling it

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
 drivers/raw/ntb/ntb.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jingjing Wu Feb. 10, 2022, 7:09 a.m. UTC | #1 
> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Thursday, February 10, 2022 3:07 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng <junfeng.guo@intel.com>
> Subject: [PATCH v4] raw/ntb: clear all valid DB bits when DB init
> 
> Before registering the doorbell interrupt handler callback function,
> all the valid doorbell bits within the NTB private data struct should
> be cleared to avoid the confusion of the handshake timing sequence
> diagram when setting up the NTB connection in back-to-back mode.
> 
> Fixes: 62012a76811e ("raw/ntb: add handshake process")
> Cc: stable@dpdk.org
> 
> v2: fix typo
> v3: fix coding style issue
> v4: add ops check before calling it
> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Thomas Monjalon Feb. 13, 2022, 11:26 a.m. UTC | #2 
> > Before registering the doorbell interrupt handler callback function,
> > all the valid doorbell bits within the NTB private data struct should
> > be cleared to avoid the confusion of the handshake timing sequence
> > diagram when setting up the NTB connection in back-to-back mode.
> > 
> > Fixes: 62012a76811e ("raw/ntb: add handshake process")
> > Cc: stable@dpdk.org
> > 
> > v2: fix typo
> > v3: fix coding style issue
> > v4: add ops check before calling it

The changelog should be below line of ---

> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
index 46ac02e5ab..f5e773c53b 100644
--- a/drivers/raw/ntb/ntb.c
+++ b/drivers/raw/ntb/ntb.c
@@ -1398,6 +1398,10 @@  ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev)
 
 	/* Init doorbell. */
 	hw->db_valid_mask = RTE_LEN2MASK(hw->db_cnt, uint64_t);
+	/* Clear all valid doorbell bits before registering intr handler */
+	if (hw->ntb_ops->db_clear == NULL)
+		return -ENOTSUP;
+	(*hw->ntb_ops->db_clear)(dev, hw->db_valid_mask);
 
 	intr_handle = pci_dev->intr_handle;
 	/* Register callback func to eal lib */