diff mbox series

net/ice: fix overwriting of LSE bit by DCF

Message ID 20220218115719.20471-1-michal.wilczynski@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/ice: fix overwriting of LSE bit by DCF |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Michal Wilczynski Feb. 18, 2022, 11:57 a.m. UTC 
  After enabling DCF on a VF, the ice driver stops receiving
link updates on it's Admin Receive Queue. During the init
of DCF ice_aqc_opc_get_link_status command is send to the
firmware without LSE(LINK STATUS EVENT) bit set. This prevents
the ice driver from receiving up/down events, and correspondingly
updating netdev.

Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
---
 drivers/net/ice/ice_dcf_parent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang Feb. 20, 2022, 5:04 a.m. UTC | #1 
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, February 18, 2022 9:35 PM
> To: Wilczynski, Michal <michal.wilczynski@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/ice: fix overwriting of LSE bit by DCF
> 
> > -----Original Message-----
> > From: Wilczynski, Michal <michal.wilczynski@intel.com>
> > Sent: Friday, February 18, 2022 19:57
> > To: dev@dpdk.org
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wilczynski, Michal
> > <michal.wilczynski@intel.com>
> > Subject: [PATCH] net/ice: fix overwriting of LSE bit by DCF
> >
> > After enabling DCF on a VF, the ice driver stops receiving link
> > updates on it's Admin Receive Queue. During the init of DCF
> > ice_aqc_opc_get_link_status command is send to the firmware without
> > LSE(LINK STATUS EVENT) bit set. This prevents the ice driver from
> > receiving up/down events, and correspondingly updating netdev.
> >
> > Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> > ---
> >  drivers/net/ice/ice_dcf_parent.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>

Applied to dpdk-next-net-intel after added below fixline and cc stable

Fixes: 0b02c9519432 ("net/ice: handle PF initialization by DCF")
Cc: stable@dpdk.org

Thanks
Qi
> 
> >
> > --
> > 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
index 0c8c2ed6c7..2f96dedcce 100644
--- a/drivers/net/ice/ice_dcf_parent.c
+++ b/drivers/net/ice/ice_dcf_parent.c
@@ -340,7 +340,7 @@  ice_dcf_init_parent_hw(struct ice_hw *hw)
 		goto err_unroll_alloc;
 
 	/* Initialize port_info struct with link information */
-	status = ice_aq_get_link_info(hw->port_info, false, NULL, NULL);
+	status = ice_aq_get_link_info(hw->port_info, true, NULL, NULL);
 	if (status)
 		goto err_unroll_alloc;