[v3] app/testpmd: add help messages for multi-process
Checks
Commit Message
From: Huisong Li <lihuisong@huawei.com>
This patch adds help messages for multi-process.
Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
v3,v2:
* adjust the position of parameters.
---
app/test-pmd/parameters.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> This patch adds help messages for multi-process.
>
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
> v3,v2:
> * adjust the position of parameters.
> ---
> app/test-pmd/parameters.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..44698046b4 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
> "extended statistics to show. Used with --stats-period "
> "specified or interactive commands that show Rx/Tx statistics "
> "(i.e. 'show port stats').\n");
> + printf(" --num-procs: the number of processes which will be used\n");
> + printf(" --proc-id : the id of the current process (id < num-procs)\n");
Hi Connor,
For people new to dpdk/test-pmd, it may be hard to figure out these two
parameter is related to multi-process support. What do you think updating
the description to clarify these are for multi-process support?
> printf(" --nb-cores=N: set the number of forwarding cores "
> "(1 <= N <= %d).\n", nb_lcores);
> printf(" --nb-ports=N: set the number of forwarding ports "
On Thu, Mar 3, 2022 at 4:09 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
> > From: Huisong Li <lihuisong@huawei.com>
> >
> > This patch adds help messages for multi-process.
> >
> > Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Huisong Li <lihuisong@huawei.com>
> > ---
> > v3,v2:
> > * adjust the position of parameters.
> > ---
> > app/test-pmd/parameters.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > index daf6a31b2b..44698046b4 100644
> > --- a/app/test-pmd/parameters.c
> > +++ b/app/test-pmd/parameters.c
> > @@ -61,6 +61,8 @@ usage(char* progname)
> > "extended statistics to show. Used with --stats-period "
> > "specified or interactive commands that show Rx/Tx statistics "
> > "(i.e. 'show port stats').\n");
> > + printf(" --num-procs: the number of processes which will be used\n");
> > + printf(" --proc-id : the id of the current process (id < num-procs)\n");
>
> Hi Connor,
>
> For people new to dpdk/test-pmd, it may be hard to figure out these two
> parameter is related to multi-process support. What do you think updating
> the description to clarify these are for multi-process support?
+1 not just for this but in general.
Group them and add a comment.
Or add that in the help text.
>
> > printf(" --nb-cores=N: set the number of forwarding cores "
> > "(1 <= N <= %d).\n", nb_lcores);
> > printf(" --nb-ports=N: set the number of forwarding ports "
>
Hi, Ferruh,
V4 has been sent to fix it, thanks.
在 2022/3/3 20:09, Ferruh Yigit 写道:
> On 3/1/2022 9:16 AM, Min Hu (Connor) wrote:
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>> app/test-pmd/parameters.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index daf6a31b2b..44698046b4 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,8 @@ usage(char* progname)
>> "extended statistics to show. Used with --stats-period "
>> "specified or interactive commands that show Rx/Tx
>> statistics "
>> "(i.e. 'show port stats').\n");
>> + printf(" --num-procs: the number of processes which will be
>> used\n");
>> + printf(" --proc-id : the id of the current process (id <
>> num-procs)\n");
>
> Hi Connor,
>
> For people new to dpdk/test-pmd, it may be hard to figure out these two
> parameter is related to multi-process support. What do you think updating
> the description to clarify these are for multi-process support?
>
>> printf(" --nb-cores=N: set the number of forwarding cores "
>> "(1 <= N <= %d).\n", nb_lcores);
>> printf(" --nb-ports=N: set the number of forwarding ports "
>
> .
@@ -61,6 +61,8 @@ usage(char* progname)
"extended statistics to show. Used with --stats-period "
"specified or interactive commands that show Rx/Tx statistics "
"(i.e. 'show port stats').\n");
+ printf(" --num-procs: the number of processes which will be used\n");
+ printf(" --proc-id : the id of the current process (id < num-procs)\n");
printf(" --nb-cores=N: set the number of forwarding cores "
"(1 <= N <= %d).\n", nb_lcores);
printf(" --nb-ports=N: set the number of forwarding ports "