[dpdk-dev] eal: arm64: introduce RTE_CPUFLAG_ATOMICS

Message ID 1456924859-18841-1-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Commit Message

Jerin Jacob March 2, 2016, 1:20 p.m. UTC
  armv8.1 adds support for new atomic instructions.
Linux kernel v4.3 onwards, the presence of atomic instruction
support can detect through HWCAP_ATOMICS

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 app/test/test_cpuflags.c                                 | 3 +++
 lib/librte_eal/common/arch/arm/rte_cpuflags.c            | 1 +
 lib/librte_eal/common/include/arch/arm/rte_cpuflags_64.h | 1 +
 3 files changed, 5 insertions(+)
  

Comments

Jan Viktorin March 2, 2016, 2:06 p.m. UTC | #1
On Wed, 2 Mar 2016 18:50:59 +0530
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:

> armv8.1 adds support for new atomic instructions.
> Linux kernel v4.3 onwards, the presence of atomic instruction
> support can detect through HWCAP_ATOMICS
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>
  
Thomas Monjalon March 5, 2016, 6:09 p.m. UTC | #2
2016-03-02 15:06, Jan Viktorin:
> On Wed, 2 Mar 2016 18:50:59 +0530
> Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> 
> > armv8.1 adds support for new atomic instructions.
> > Linux kernel v4.3 onwards, the presence of atomic instruction
> > support can detect through HWCAP_ATOMICS
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>

Applied, thanks
  

Patch

diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c
index e8d0ce7..d083c86 100644
--- a/app/test/test_cpuflags.c
+++ b/app/test/test_cpuflags.c
@@ -144,6 +144,9 @@  test_cpuflags(void)
 
 	printf("Check for CRC32:\t");
 	CHECK_FOR_FLAG(RTE_CPUFLAG_CRC32);
+
+	printf("Check for ATOMICS:\t");
+	CHECK_FOR_FLAG(RTE_CPUFLAG_ATOMICS);
 #endif
 
 #if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686)
diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
index f14c56a..23240ef 100644
--- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
+++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
@@ -122,6 +122,7 @@  const struct feature_entry rte_cpu_feature_table[] = {
 	FEAT_DEF(SHA1,		REG_HWCAP,    5)
 	FEAT_DEF(SHA2,		REG_HWCAP,    6)
 	FEAT_DEF(CRC32,		REG_HWCAP,    7)
+	FEAT_DEF(ATOMICS,	REG_HWCAP,    8)
 	FEAT_DEF(AARCH64,	REG_PLATFORM, 1)
 };
 #endif /* RTE_ARCH */
diff --git a/lib/librte_eal/common/include/arch/arm/rte_cpuflags_64.h b/lib/librte_eal/common/include/arch/arm/rte_cpuflags_64.h
index 810e8a0..49aead9 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_cpuflags_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_cpuflags_64.h
@@ -49,6 +49,7 @@  enum rte_cpu_flag_t {
 	RTE_CPUFLAG_SHA1,
 	RTE_CPUFLAG_SHA2,
 	RTE_CPUFLAG_CRC32,
+	RTE_CPUFLAG_ATOMICS,
 	RTE_CPUFLAG_AARCH64,
 	/* The last item */
 	RTE_CPUFLAG_NUMFLAGS,/**< This should always be the last! */