[v2] net/ixgbe: fix error of drop queue index
Checks
Commit Message
The drop queue index was not set when adding internal Flow
Director Configuration copy in ixgbe device private data.
Therefore dropped packets would be received by queue 0
which is set to drop queue.
This commit sets drop queue index as IXGBE_FDIR_DROP_QUEUE
to fix this issue.
Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director configuration")
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 1 +
1 file changed, 1 insertion(+)
Comments
> -----Original Message-----
> From: Kaiwen Deng <kaiwenx.deng@intel.com>
> Sent: Friday, November 11, 2022 2:39 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>;
> Wang, Haiyue <haiyue.wang@intel.com>; Dongdong Liu
> <liudongdong3@huawei.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Subject: [PATCH v2] net/ixgbe: fix error of drop queue index
>
> The drop queue index was not set when adding internal Flow Director
> Configuration copy in ixgbe device private data.
> Therefore dropped packets would be received by queue 0 which is set to
> drop queue.
>
> This commit sets drop queue index as IXGBE_FDIR_DROP_QUEUE to fix this
> issue.
>
> Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director
> configuration")
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -2759,6 +2759,7 @@ ixgbe_parse_fdir_filter(struct rte_eth_dev *dev,
int ret;
struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
struct rte_eth_fdir_conf *fdir_conf = IXGBE_DEV_FDIR_CONF(dev);
+ fdir_conf->drop_queue = IXGBE_FDIR_DROP_QUEUE;
if (hw->mac.type != ixgbe_mac_82599EB &&
hw->mac.type != ixgbe_mac_X540 &&