net/af_xdp: fix integer handling issues
Checks
Commit Message
Fix integer handling issues (NEGATIVE_RETURNS) reported
in coverity scan. Add a check to sock variable if the
value is negative return -1.
Coverity issue: 383245
Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration")
Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On 2/21/2023 11:14 AM, Shibin Koikkara Reeny wrote:
> Fix integer handling issues (NEGATIVE_RETURNS) reported
> in coverity scan. Add a check to sock variable if the
> value is negative return -1.
>
> Coverity issue: 383245
> Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration")
>
> Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
@@ -1508,6 +1508,8 @@ get_cni_fd(char *if_name)
memset(&server, 0, sizeof(server));
sock = init_uds_sock(&server);
+ if (sock < 0)
+ return -1;
/* Initiates handshake to CNI send: /connect,hostname */
snprintf(request, sizeof(request), "%s,%s", UDS_CONNECT_MSG, hostname);