diff mbox series

mldev: remove variable self assignment in dev init

Message ID 20230311145705.9178-1-syalavarthi@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series mldev: remove variable self assignment in dev init |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Srikanth Yalavarthi March 11, 2023, 2:57 p.m. UTC 
  Fix variable self assignment in rte_ml_devinit.
Issue reported by coverity scan.

Coverity issue: 383652
Fixes: ea80eafbd4d8 ("mldev: add PMD functions")

Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 lib/mldev/rte_mldev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Marchand March 13, 2023, 11:02 a.m. UTC | #1 
On Sat, Mar 11, 2023 at 3:57 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> Fix variable self assignment in rte_ml_devinit.
> Issue reported by coverity scan.
>
> Coverity issue: 383652
> Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>
Tyler Retzlaff March 13, 2023, 7:19 p.m. UTC | #2 
On Sat, Mar 11, 2023 at 06:57:04AM -0800, Srikanth Yalavarthi wrote:
> Fix variable self assignment in rte_ml_devinit.
> Issue reported by coverity scan.
> 
> Coverity issue: 383652
> Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

>  lib/mldev/rte_mldev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
> index eeddb8e874..50ebeb1bfe 100644
> --- a/lib/mldev/rte_mldev.c
> +++ b/lib/mldev/rte_mldev.c
> @@ -186,7 +186,6 @@ rte_ml_dev_init(size_t dev_max)
>  	}
>  
>  	ml_dev_globals.max_devs = dev_max;
> -	ml_dev_globals.devs = ml_dev_globals.devs;
>  
>  	return 0;
>  }
> -- 
> 2.17.1
David Marchand March 15, 2023, 9:49 a.m. UTC | #3 
On Mon, Mar 13, 2023 at 8:19 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> On Sat, Mar 11, 2023 at 06:57:04AM -0800, Srikanth Yalavarthi wrote:
> > Fix variable self assignment in rte_ml_devinit.
> > Issue reported by coverity scan.
> >
> > Coverity issue: 383652
> > Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > ---
>
> Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
index eeddb8e874..50ebeb1bfe 100644
--- a/lib/mldev/rte_mldev.c
+++ b/lib/mldev/rte_mldev.c
@@ -186,7 +186,6 @@  rte_ml_dev_init(size_t dev_max)
 	}
 
 	ml_dev_globals.max_devs = dev_max;
-	ml_dev_globals.devs = ml_dev_globals.devs;
 
 	return 0;
 }