diff mbox series

[v2,1/1] test/mbuf: fix mbuf autotest when mbuf debug is enabled

Message ID 20230316191456.54066-1-pivashchenko@nfware.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [v2,1/1] test/mbuf: fix mbuf autotest when mbuf debug is enabled |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/intel-Functional fail Functional issues

Commit Message

Pavel Ivashchenko March 16, 2023, 7:14 p.m. UTC 
  How to reproduce:

1. Define RTE_LIBRTE_MBUF_DEBUG
2. MALLOC_PERTURB_=178 DPDK_TEST=mbuf_autotest gdb --args obj-x86_64-linux-gnu/app/test/dpdk-test --file-prefix=mbuf_autotest

   PANIC in rte_mbuf_sanity_check():
   bad pkt_len

   ...
   #6  0x00007ffff7d3d4cc in rte_mbuf_sanity_check (m=m@entry=0x17f8c3400, is_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
   #7  0x0000555555653d57 in rte_pktmbuf_free (m=0x17f8c3400) at ../lib/mbuf/rte_mbuf.h:1385
   #8  0x000055555565c7a6 in test_nb_segs_and_next_reset () at ../app/test/test_mbuf.c:2752
   #9  test_mbuf () at ../app/test/test_mbuf.c:2967
   ...

   (gdb) frame 6
   #6  0x00007ffff7d3d4cc in rte_mbuf_sanity_check (m=m@entry=0x17f8c3400, is_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
   384			rte_panic("%s\n", reason);
   (gdb) p/d m->pkt_len
   $4 = 1500

Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
Cc: stable@dpdk.org

Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
---
v2:
 * Fixed commit title
 * Changed m0->pkt_len -= 500 to m0->pkt_len -= m2->data_len

 app/test/test_mbuf.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Olivier Matz March 17, 2023, 8:02 a.m. UTC | #1 
On Thu, Mar 16, 2023 at 10:14:56PM +0300, Pavel Ivashchenko wrote:
> How to reproduce:
> 
> 1. Define RTE_LIBRTE_MBUF_DEBUG
> 2. MALLOC_PERTURB_=178 DPDK_TEST=mbuf_autotest gdb --args obj-x86_64-linux-gnu/app/test/dpdk-test --file-prefix=mbuf_autotest
> 
>    PANIC in rte_mbuf_sanity_check():
>    bad pkt_len
> 
>    ...
>    #6  0x00007ffff7d3d4cc in rte_mbuf_sanity_check (m=m@entry=0x17f8c3400, is_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
>    #7  0x0000555555653d57 in rte_pktmbuf_free (m=0x17f8c3400) at ../lib/mbuf/rte_mbuf.h:1385
>    #8  0x000055555565c7a6 in test_nb_segs_and_next_reset () at ../app/test/test_mbuf.c:2752
>    #9  test_mbuf () at ../app/test/test_mbuf.c:2967
>    ...
> 
>    (gdb) frame 6
>    #6  0x00007ffff7d3d4cc in rte_mbuf_sanity_check (m=m@entry=0x17f8c3400, is_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
>    384			rte_panic("%s\n", reason);
>    (gdb) p/d m->pkt_len
>    $4 = 1500
> 
> Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
David Marchand March 17, 2023, 8:09 a.m. UTC | #2 
On Fri, Mar 17, 2023 at 9:03 AM Olivier Matz <olivier.matz@6wind.com> wrote:
> On Thu, Mar 16, 2023 at 10:14:56PM +0300, Pavel Ivashchenko wrote:
> > How to reproduce:
> >
> > 1. Define RTE_LIBRTE_MBUF_DEBUG
> > 2. MALLOC_PERTURB_=178 DPDK_TEST=mbuf_autotest gdb --args obj-x86_64-linux-gnu/app/test/dpdk-test --file-prefix=mbuf_autotest
> >
> >    PANIC in rte_mbuf_sanity_check():
> >    bad pkt_len
> >
> >    ...
> >    #6  0x00007ffff7d3d4cc in rte_mbuf_sanity_check (m=m@entry=0x17f8c3400, is_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
> >    #7  0x0000555555653d57 in rte_pktmbuf_free (m=0x17f8c3400) at ../lib/mbuf/rte_mbuf.h:1385
> >    #8  0x000055555565c7a6 in test_nb_segs_and_next_reset () at ../app/test/test_mbuf.c:2752
> >    #9  test_mbuf () at ../app/test/test_mbuf.c:2967
> >    ...
> >
> >    (gdb) frame 6
> >    #6  0x00007ffff7d3d4cc in rte_mbuf_sanity_check (m=m@entry=0x17f8c3400, is_header=is_header@entry=1) at ../lib/mbuf/rte_mbuf.c:384
> >    384                        rte_panic("%s\n", reason);
> >    (gdb) p/d m->pkt_len
> >    $4 = 1500
> >
> > Fixes: efc6f9104c80 ("mbuf: fix reset on mbuf free")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 6cbb03b0af..1f4dd62466 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2744,6 +2744,7 @@  test_nb_segs_and_next_reset(void)
 
 	/* split m0 chain in two, between m1 and m2 */
 	m0->nb_segs = 2;
+	m0->pkt_len -= m2->data_len;
 	m1->next = NULL;
 	m2->nb_segs = 1;