diff mbox

[dpdk-dev,04/20] thunderx/nicvf: add get_reg and get_reg_length support

Message ID 1462634198-2289-5-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Jerin Jacob May 7, 2016, 3:16 p.m. UTC 
  Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Signed-off-by: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>
Signed-off-by: Zyta Szpak <zyta.szpak@semihalf.com>
Signed-off-by: Slawomir Rosek <slawomir.rosek@semihalf.com>
Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>
---
 drivers/net/thunderx/nicvf_ethdev.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Pattan, Reshma May 12, 2016, 3:39 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> Sent: Saturday, May 7, 2016 4:16 PM
> To: dev@dpdk.org
> Cc: thomas.monjalon@6wind.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Maciej Czekaj
> <maciej.czekaj@caviumnetworks.com>; Kamil Rytarowski
> <Kamil.Rytarowski@caviumnetworks.com>; Zyta Szpak
> <zyta.szpak@semihalf.com>; Slawomir Rosek <slawomir.rosek@semihalf.com>;
> Radoslaw Biernacki <rad@semihalf.com>
> Subject: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and
> get_reg_length support
> 
> +
> +static int
> +nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info
> +*regs) {
> +	uint64_t *data = regs->data;
> +	struct nicvf *nic = nicvf_pmd_priv(dev);
> +
> +	if (data == NULL)
> +		return -EINVAL;

nicvf_reg_dump prints to stdout if data in NULL, so do we still want to return here?

Thanks,
Reshma
Jerin Jacob May 13, 2016, 8:14 a.m. UTC | #2 
On Thu, May 12, 2016 at 03:39:56PM +0000, Pattan, Reshma wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
> > Sent: Saturday, May 7, 2016 4:16 PM
> > To: dev@dpdk.org
> > Cc: thomas.monjalon@6wind.com; Richardson, Bruce
> > <bruce.richardson@intel.com>; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>; Maciej Czekaj
> > <maciej.czekaj@caviumnetworks.com>; Kamil Rytarowski
> > <Kamil.Rytarowski@caviumnetworks.com>; Zyta Szpak
> > <zyta.szpak@semihalf.com>; Slawomir Rosek <slawomir.rosek@semihalf.com>;
> > Radoslaw Biernacki <rad@semihalf.com>
> > Subject: [dpdk-dev] [PATCH 04/20] thunderx/nicvf: add get_reg and
> > get_reg_length support
> > 
> > +
> > +static int
> > +nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info
> > +*regs) {
> > +	uint64_t *data = regs->data;
> > +	struct nicvf *nic = nicvf_pmd_priv(dev);
> > +
> > +	if (data == NULL)
> > +		return -EINVAL;
> 
> nicvf_reg_dump prints to stdout if data in NULL, so do we still want to return here?

Yes as base is code common for other data plane libraries and I think in
DPDK get_regs callback perspective it makes sense to add this check as
PMD driver expected to get the data in the buffer.

Thanks for the review.
I agree with your all other review comments in another thread. Will fix it V2.
> 
> Thanks,
> Reshma
> 
> 
>
diff mbox

Patch

diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index e6f0b3e..92b08a5 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -70,6 +70,9 @@ 
 #include "nicvf_logs.h"
 
 static int nicvf_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete);
+static int nicvf_dev_get_reg_length(struct rte_eth_dev *dev);
+static int nicvf_dev_get_regs(struct rte_eth_dev *dev,
+			      struct rte_dev_reg_info *regs);
 
 static inline int
 nicvf_atomic_write_link_status(struct rte_eth_dev *dev,
@@ -167,10 +170,36 @@  nicvf_dev_link_update(struct rte_eth_dev *dev,
 	return nicvf_atomic_write_link_status(dev, &link);
 }
 
+static int
+nicvf_dev_get_reg_length(struct rte_eth_dev *dev  __rte_unused)
+{
+	return nicvf_reg_get_count();
+}
+
+static int
+nicvf_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info *regs)
+{
+	uint64_t *data = regs->data;
+	struct nicvf *nic = nicvf_pmd_priv(dev);
+
+	if (data == NULL)
+		return -EINVAL;
+
+	/* Support only full register dump */
+	if ((regs->length == 0) ||
+		(regs->length == (uint32_t)nicvf_reg_get_count())) {
+		regs->version = nic->vendor_id << 16 | nic->device_id;
+		nicvf_reg_dump(nic, data);
+		return 0;
+	}
+	return -ENOTSUP;
+}
 
 /* Initialise and register driver with DPDK Application */
 static const struct eth_dev_ops nicvf_eth_dev_ops = {
 	.link_update              = nicvf_dev_link_update,
+	.get_reg_length           = nicvf_dev_get_reg_length,
+	.get_reg                  = nicvf_dev_get_regs,
 };
 
 static int