diff mbox

[dpdk-dev,v3,18/20] thunderx/config: set max numa node to two

Message ID 1465317632-11471-19-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Jerin Jacob June 7, 2016, 4:40 p.m. UTC 
  Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit June 8, 2016, 5:54 p.m. UTC | #1 
On 6/7/2016 5:40 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
> index 7940bbd..cc12cee 100644
> --- a/config/defconfig_arm64-thunderx-linuxapp-gcc
> +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
> @@ -34,6 +34,7 @@
>  CONFIG_RTE_MACHINE="thunderx"
>  
>  CONFIG_RTE_CACHE_LINE_SIZE=128
> +CONFIG_RTE_MAX_NUMA_NODES=2
Isn't this platform level configuration? And sets max numa nodes
independent from driver, right?

Can you please add some more information why this is required?

Also does it make sense to separate this patch from driver patchset?

>  
>  #
>  # Compile Cavium Thunderx NICVF PMD driver
>
Jerin Jacob June 13, 2016, 1:11 p.m. UTC | #2 
On Wed, Jun 08, 2016 at 06:54:43PM +0100, Ferruh Yigit wrote:
> On 6/7/2016 5:40 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
> > index 7940bbd..cc12cee 100644
> > --- a/config/defconfig_arm64-thunderx-linuxapp-gcc
> > +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
> > @@ -34,6 +34,7 @@
> >  CONFIG_RTE_MACHINE="thunderx"
> >  
> >  CONFIG_RTE_CACHE_LINE_SIZE=128
> > +CONFIG_RTE_MAX_NUMA_NODES=2
> Isn't this platform level configuration? And sets max numa nodes
> independent from driver, right?
> 

Yes

> Can you please add some more information why this is required?
> 
> Also does it make sense to separate this patch from driver patchset?

Yes, I will separate this patch from the series.

Thanks Ferruh for the comprehensive review of this patch series.
I will send the v4, addressing all of your review comments.

Jerin

> 
> >  
> >  #
> >  # Compile Cavium Thunderx NICVF PMD driver
> > 
>
diff mbox

Patch

diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
index 7940bbd..cc12cee 100644
--- a/config/defconfig_arm64-thunderx-linuxapp-gcc
+++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
@@ -34,6 +34,7 @@ 
 CONFIG_RTE_MACHINE="thunderx"
 
 CONFIG_RTE_CACHE_LINE_SIZE=128
+CONFIG_RTE_MAX_NUMA_NODES=2
 
 #
 # Compile Cavium Thunderx NICVF PMD driver