[dpdk-dev,v4,02/26] eal: return error instead of panic for cpu init
Checks
Commit Message
There may be no way to gracefully recover, but the application
should be notified that a failure happened, rather than completely
aborting. This allows the user to proceed with a "slow-path" type
solution.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
Comments
On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote:
> There may be no way to gracefully recover, but the application
> should be notified that a failure happened, rather than completely
> aborting. This allows the user to proceed with a "slow-path" type
> solution.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index bf6b818..5023d0d 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void)
> }
> #endif
>
> +static void rte_eal_init_alert(const char *msg)
> +{
> + fprintf(stderr, "EAL: FATAL: %s\n", msg);
> + RTE_LOG(ERR, EAL, "%s\n", msg);
> +}
> +
> /* Launch threads, called at application init(). */
> int
> rte_eal_init(int argc, char **argv)
> @@ -767,8 +773,11 @@ rte_eal_init(int argc, char **argv)
> /* set log level as early as possible */
> rte_set_log_level(internal_config.log_level);
>
> - if (rte_eal_cpu_init() < 0)
> - rte_panic("Cannot detect lcores\n");
> + if (rte_eal_cpu_init() < 0) {
> + rte_eal_init_alert("Cannot detect lcores.");
> + rte_errno = ENOTSUP;
> + return -1;
> + }
>
> fctret = eal_parse_args(argc, argv);
> if (fctret < 0)
> --
eal.c needs to include rte_errno.h after this change, otherwise it won't
compile.
/Bruce
On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote:
> There may be no way to gracefully recover, but the application
> should be notified that a failure happened, rather than completely
> aborting. This allows the user to proceed with a "slow-path" type
> solution.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index bf6b818..5023d0d 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void)
> }
> #endif
>
> +static void rte_eal_init_alert(const char *msg)
> +{
> + fprintf(stderr, "EAL: FATAL: %s\n", msg);
> + RTE_LOG(ERR, EAL, "%s\n", msg);
> +}
Checkpatch flags the use of spaces rather than tabs here.
/Bruce
Bruce Richardson <bruce.richardson@intel.com> writes:
> On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote:
>> There may be no way to gracefully recover, but the application
>> should be notified that a failure happened, rather than completely
>> aborting. This allows the user to proceed with a "slow-path" type
>> solution.
>>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>> lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c
>> b/lib/librte_eal/linuxapp/eal/eal.c
>> index bf6b818..5023d0d 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> @@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void)
>> }
>> #endif
>>
>> +static void rte_eal_init_alert(const char *msg)
>> +{
>> + fprintf(stderr, "EAL: FATAL: %s\n", msg);
>> + RTE_LOG(ERR, EAL, "%s\n", msg);
>> +}
> Checkpatch flags the use of spaces rather than tabs here.
Yes, I caught it too late. Sorry, I'll fix it.
> /Bruce
Bruce Richardson <bruce.richardson@intel.com> writes:
> On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote:
>> There may be no way to gracefully recover, but the application
>> should be notified that a failure happened, rather than completely
>> aborting. This allows the user to proceed with a "slow-path" type
>> solution.
>>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>> lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
>> index bf6b818..5023d0d 100644
>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> @@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void)
>> }
>> #endif
>>
>> +static void rte_eal_init_alert(const char *msg)
>> +{
>> + fprintf(stderr, "EAL: FATAL: %s\n", msg);
>> + RTE_LOG(ERR, EAL, "%s\n", msg);
>> +}
>> +
>> /* Launch threads, called at application init(). */
>> int
>> rte_eal_init(int argc, char **argv)
>> @@ -767,8 +773,11 @@ rte_eal_init(int argc, char **argv)
>> /* set log level as early as possible */
>> rte_set_log_level(internal_config.log_level);
>>
>> - if (rte_eal_cpu_init() < 0)
>> - rte_panic("Cannot detect lcores\n");
>> + if (rte_eal_cpu_init() < 0) {
>> + rte_eal_init_alert("Cannot detect lcores.");
>> + rte_errno = ENOTSUP;
>> + return -1;
>> + }
>>
>> fctret = eal_parse_args(argc, argv);
>> if (fctret < 0)
>> --
> eal.c needs to include rte_errno.h after this change, otherwise it won't
> compile.
oops.. I reordered some of my original work, and the rte_errno.h change
was introduced too late. Thanks for catching this!
> /Bruce
@@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void)
}
#endif
+static void rte_eal_init_alert(const char *msg)
+{
+ fprintf(stderr, "EAL: FATAL: %s\n", msg);
+ RTE_LOG(ERR, EAL, "%s\n", msg);
+}
+
/* Launch threads, called at application init(). */
int
rte_eal_init(int argc, char **argv)
@@ -767,8 +773,11 @@ rte_eal_init(int argc, char **argv)
/* set log level as early as possible */
rte_set_log_level(internal_config.log_level);
- if (rte_eal_cpu_init() < 0)
- rte_panic("Cannot detect lcores\n");
+ if (rte_eal_cpu_init() < 0) {
+ rte_eal_init_alert("Cannot detect lcores.");
+ rte_errno = ENOTSUP;
+ return -1;
+ }
fctret = eal_parse_args(argc, argv);
if (fctret < 0)