diff mbox

[dpdk-dev,02/39] app/test: fix eventdev reconfigure test

Message ID 1488562101-6658-3-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob March 3, 2017, 5:27 p.m. UTC 
  Minimum value of nb_event_ports and/or nb_event_queues
should be one before reconfiguring the event device.

Fixes: 4c9a26e419a7 ("app/test: unit test case for eventdev APIs")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 app/test/test_eventdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Van Haaren, Harry March 15, 2017, 5:28 p.m. UTC | #1 
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Friday, March 3, 2017 5:28 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 02/39] app/test: fix eventdev reconfigure test
> 
> Minimum value of nb_event_ports and/or nb_event_queues
> should be one before reconfiguring the event device.
> 
> Fixes: 4c9a26e419a7 ("app/test: unit test case for eventdev APIs")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Jerin Jacob March 23, 2017, 10:11 a.m. UTC | #2 
On Wed, Mar 15, 2017 at 05:28:35PM +0000, Van Haaren, Harry wrote:
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Friday, March 3, 2017 5:28 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 02/39] app/test: fix eventdev reconfigure test
> > 
> > Minimum value of nb_event_ports and/or nb_event_queues
> > should be one before reconfiguring the event device.
> > 
> > Fixes: 4c9a26e419a7 ("app/test: unit test case for eventdev APIs")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.

> 
>
diff mbox

Patch

diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c
index 042a446..e087af2 100644
--- a/app/test/test_eventdev.c
+++ b/app/test/test_eventdev.c
@@ -244,8 +244,8 @@  test_eventdev_configure(void)
 
 	/* re-configure */
 	devconf_set_default_sane_values(&dev_conf, &info);
-	dev_conf.nb_event_ports = info.max_event_ports/2;
-	dev_conf.nb_event_queues = info.max_event_queues/2;
+	dev_conf.nb_event_ports = RTE_MAX(info.max_event_ports/2, 1);
+	dev_conf.nb_event_queues = RTE_MAX(info.max_event_queues/2, 1);
 	ret = rte_event_dev_configure(TEST_DEV_ID, &dev_conf);
 	TEST_ASSERT_SUCCESS(ret, "Failed to re configure eventdev");