From patchwork Fri Sep 29 15:37:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 29438 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A73B1B1A0; Fri, 29 Sep 2017 17:38:09 +0200 (CEST) Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 4D5E39FE for ; Fri, 29 Sep 2017 17:38:05 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id k193so3637pgc.8 for ; Fri, 29 Sep 2017 08:38:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=SATAPy4YvGp5UwfRtm/M/7g/gcnHsvQ4U+C+StmzK7U=; b=lP6P9+22CfRzJEg2yN/X4KVm/9cTI19ilbVZdrLsWw/hdGNg8eTNqPiYew7OgmAUgE sd/8a07e1TaCYSlxyY+/ekFBBrwJZwlejNCTqPGIb1EFJ3rjDYnLHJiqq97cSBRrs0g9 JkrL5bwNmxWwR+j/tBCD7aFNIK7s3EPqcuFnFdGSFrfkEeJOAszkOw5FPTOEL4aQuxgB kxvPnhCH6UBxFNh6eSK4RxvYRRk2/OEOU+EwEr2EoWGGP2PxYi49Ze3fRqv+T0yiBMmj 3PzPcz9w2YLAjYFXVj513r/83zHfTPUilA7TdAa1kNAYYgJyHs1TRlRrVkV9Xs1a/bHs 7Bew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SATAPy4YvGp5UwfRtm/M/7g/gcnHsvQ4U+C+StmzK7U=; b=OiQRLNWzTmr1SZh/DPfjwyX2PyUksQwMYZVZsA/atXKZucwSv+4KvaKR1/zl7X6ndK F6RCutbFN+p4qxYZ5Y9G9/EU5pk845ZL4MYVhFMKuJMsDEs+TmRSlGUVmQeNJ95UwHHr hTD4+aX/n8zW0FGh3gEFNsOpJrlZijhneYc4BMQZVFGXPFwkCfXcLyDZDIxqFGIN1ppC Oy1P+CJSLNPgeKHOfIoPngWU7iTqkSQMm3QZMkUKP2RdaZrI+h2qkaFtO499GmkwRIeO Y6BiclBwC9O4yc4NBW2Z3RKpwV99mPwgTIOrhrbS53rI76yPNwP936pmZHw/rieMx5kF FJAg== X-Gm-Message-State: AHPjjUgA4QKxpSnRfRQeQ6a3C0dBwdAqNLnH8qsLaAVKyH9x/J8aM1I7 WfHCnzJESr9UMp+N3QoHh4ODgK/dmmY= X-Google-Smtp-Source: AOwi7QDy2HCOlKAhWSUyBWI+U5eiaMBHznUdulM53DQn7yoG7xyEdqBf/JNv8pmOoJyKgIMjuo4+qg== X-Received: by 10.84.132.66 with SMTP id 60mr7400070ple.158.1506699484290; Fri, 29 Sep 2017 08:38:04 -0700 (PDT) Received: from xeon-e3.lan (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id g25sm7332074pfg.166.2017.09.29.08.38.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Sep 2017 08:38:03 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Fri, 29 Sep 2017 08:37:49 -0700 Message-Id: <20170929153749.9806-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Linux kernel style policy about strings is that strings should be always put on one line. This makes sense since a typical use case is for a user to type the error message into a search engine or grep, and it won't be found if split across lines. This patch just re-enables that check. Yes, lots of DPDK code now splits strings, that doesn't make it right. Signed-off-by: Stephen Hemminger Acked-by: Luca Boccassi --- devtools/checkpatches.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index a56c41a301c0..3e6081dd673e 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -44,7 +44,6 @@ options="$options --show-types" options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ -SPLIT_STRING,LONG_LINE_STRING,\ LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ NEW_TYPEDEFS,COMPARISON_TO_NULL"