[dpdk-dev,9/9] tools: use SPDX tag for Cavium copyright files
Checks
Commit Message
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
devtools/build-tags.sh | 30 ++----------------------------
1 file changed, 2 insertions(+), 28 deletions(-)
Comments
On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> devtools/build-tags.sh | 30 ++----------------------------
> 1 file changed, 2 insertions(+), 28 deletions(-)
>
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index 942da2bae..d775b17e9 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -1,35 +1,9 @@
> #!/bin/sh -e
> # Generate tags or gtags or cscope or etags files
> #
> -# BSD LICENSE
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2017 Cavium, Inc
Hi Jerin,
All your patches are ok except this one.
It is not aligned with the policy.
SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.
you can move the comments ("Generate tags...") after the copyrights.
Regards,
Hemant
-----Original Message-----
> Date: Sun, 7 Jan 2018 14:24:11 +0530
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
> CC: thomas@monjalon.net
> Subject: Re: [PATCH 9/9] tools: use SPDX tag for Cavium copyright files
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
> Thunderbird/45.8.0
>
> On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > devtools/build-tags.sh | 30 ++----------------------------
> > 1 file changed, 2 insertions(+), 28 deletions(-)
> >
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> > index 942da2bae..d775b17e9 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -1,35 +1,9 @@
> > #!/bin/sh -e
> > # Generate tags or gtags or cscope or etags files
> > #
> > -# BSD LICENSE
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2017 Cavium, Inc
>
> Hi Jerin,
> All your patches are ok except this one.
> It is not aligned with the policy.
> SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.
>
> you can move the comments ("Generate tags...") after the copyrights.
Thanks Hemant. I will move the comments and send the v2.
>
> Regards,
> Hemant
@@ -1,35 +1,9 @@
#!/bin/sh -e
# Generate tags or gtags or cscope or etags files
#
-# BSD LICENSE
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2017 Cavium, Inc
#
-# Copyright 2017 Cavium, Inc
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in
-# the documentation and/or other materials provided with the
-# distribution.
-# * Neither the name of Cavium, Inc nor the names of its
-# contributors may be used to endorse or promote products derived
-# from this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
verbose=false
linux=true