From patchwork Mon Feb 12 05:54:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 35123 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBD9D1B305; Mon, 12 Feb 2018 06:55:21 +0100 (CET) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0061.outbound.protection.outlook.com [104.47.42.61]) by dpdk.org (Postfix) with ESMTP id 102BF1B304 for ; Mon, 12 Feb 2018 06:55:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OQ1LYz5iNXDzpQ8wsFr+JL3vSK3ylvBh03f3HZNVhrQ=; b=DAop3kMoKQWMZwTs3HvPO6ge0GHX1qDm8bJ0CVQQS/QxzCwMKr7z/9b32cqfzvYe02xXLf/pLYDkEg+cwDM3L+zvkO5lTkWCVHOZX9vVXyk+xkKnhn9zDBRH/MGRUAbTO4ReSPelzL4EdW6PyRKw5jvojtYmZ21iXo6T9klJwUY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin.domain.name (122.178.220.11) by SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 05:55:15 +0000 From: Jerin Jacob To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Jerin Jacob , Matan Azrad , Thomas Monjalon , Konstantin Ananyev , Pavan Nikhilesh Date: Mon, 12 Feb 2018 11:24:39 +0530 Message-Id: <20180212055439.6462-1-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com> References: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [122.178.220.11] X-ClientProxiedBy: PN1PR0101CA0053.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::15) To SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e04e7324-1d3d-49a2-b9fe-08d571dd31c9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 3:18CTncbFohTYqme9aunyNd4Tv/jEBl8+WKvcpsZ7afHqAVvnEZuKWY1OPJRtYeo0ZoStpbCl6cD7aeV9wOojlNQgddcPe4+rbJwj8pFZsdQLC5INBMad1DOSl1l57EqehmaNK9IEvvjZattgZH4s4p2VbSA0sgyEXzY7xTOB8MUAJ7tA62F1L8vFBIG6THcDUZRTNUHypOWUyIyuQxAMSIGpxgE6TtHbkLq9sgtgtU4D6wIwcRLdMH4wy3Oj5WDi; 25:+W0doru9K1otcXOV50w3MKjrJ24AVB/njdLFobSxgzOTVTYZu7Ize/bCUpcxVD+3BHgot47YQbO6GYDzCw7g7xZ+Tr6WujeaZb+rC+Iq8AvtwndoI5KIZTwCTPEBwlcdSw/qkkT/bWzuH9JcNeRil+S5fQR3cy93oeZxGHucnzrb8kq91vb7P42ED2McVzna1REZGHdtxjT1s3++DCWDyyxuZaygN4MHTiQD8xHGO3v/RZLzAgN8XfU01SzCxD5uy1YqwTTYz7SQmsR6K9dhWzD+EPWr0pWSGDLS2nSUR4AVrnrgepeRUbjHj7H6ynZUelONeXsNgnGsuSWxQuJCqQ==; 31:7H91QPYp69Sz9qrvV5QeL6RPNThKClqQXxuKibyklXQ4D1UN4OI6HINozxmYiH8vvR1WguLZoJ9NUowTj4b4cDdkBVTKNzkJTObk8L3wpgMhSAfSVpB+FJfyic2fSfweOXDMGm6krqBz98O62XmK7eMTvywl5elifxZaDki2NTmtkDEVWQ9bYMOxrP4hp2aLuLqyXCq7VLZIfzeXRP/0T+r+YrP74TOBC0p4bAgKqeU= X-MS-TrafficTypeDiagnostic: SN2PR07MB2528: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 20:GyrJ6yG+/keoiw0CDUwkcLoZ/xzGVQd19YCjlc/GD159LhwhpQP6GUXunK12lxolik9s0pUhAmqSwNeYvvFN7TjxOQQhk4IAVsvUlKAoNu7TlKsyy3gDlq2c7U1tF5GaBUNt7Ku8u2T5ZR6E/vl6AwFlMqsQY4cHX2J7NY/5LOSZcQwwLoYw0+i535sA0rb8e8Q+Cvyj68Q0nu/z+xD85RlZj5ZKbAX5Z7s7T+l94zLFYApSbyFg3GAW83STV8o3YI53Ryy/Qepa8BufsjZZq2KZ6sQC6kJ466D0Bi7h8ueqECJqmzpfz1wc/VfmqQSPiFPnOGt4pNQtVIV74vDf/6EsWQ54KvFSbWT+cOJ+0NOwxT3GURFMRGPX4BsefkIC4siOx8m3NMifc7SkYBxwum49Si8qF86aPAeKHeSpCVL1guwrjnOFGRljl4+BRKbKhH7iMH12y6ZoNxpPl0xLkVnIqezJrfJU3ZsB91Ku/kEz50PzmO1smaWSy+PywKMjzbVB/Oe0Ok5x+b8EmPjQdHFf21g9hyiJYijtJ8r+cY5yBloGZs9gCoqrhIuouUUOjJLQpzCr66vifRxez6oftFsvutHqxOnAIJsIpLcB5ss= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(60795455431006)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(2400082)(944501161)(93006095)(10201501046)(3002001)(6041288)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN2PR07MB2528; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 4:9dfA/XhSNfrksnaMDF4Ds8DVQTgx62ITMWQd0BiWXBmDq/pQMDyPPDsC/a3V7Squu+SeJq/ACeIlYP1klULs9OuXmq9meLRUfpIn6nG0UAORwpio2ErDH66cCTPqG/VaH8hMadro2eEN9rRvAsOkeHkX1iSUee8tAekam/04bx03QNxxTxP2bqLU2gitFdk3VlL/Ql1YYeIaw3+pzUWGFdBnUayPWQb7QpxDca3wkNB99NGtQKUaoLvKUKoD9b4HCTe7+AJI/XmPISVB84IkXoUYXMuYcZmRCVVfspV39vDjQ5rVLgA1Z0RbA7vbUwbCa8+MuLjCtAFvX9hn9L7WZH5Fe0srEVQRugduDqOHwdE= X-Forefront-PRVS: 0581B5AB35 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39850400004)(39380400002)(346002)(396003)(376002)(189003)(199004)(66066001)(1857600001)(16586007)(1076002)(3846002)(97736004)(105586002)(16526019)(47776003)(48376002)(6116002)(2906002)(316002)(2950100002)(186003)(42882006)(5660300001)(54906003)(106356001)(6916009)(6666003)(59450400001)(6506007)(69596002)(26005)(966005)(478600001)(52116002)(51416003)(50466002)(76176011)(386003)(68736007)(72206003)(6306002)(107886003)(2361001)(6512007)(81156014)(53936002)(36756003)(305945005)(50226002)(8936002)(53416004)(7736002)(4326008)(81166006)(2351001)(25786009)(8676002)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:jerin.domain.name; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2528; 23:DjrSVIUuhdy0rIHEOIJcOwC5dQoKNFrb0f7HEii45?= nmiEECBm/VTq+qTZe9jWX4xj1niA4Ono6RiLyHlN0cnPRaElvJKkhRDKyYhYwi3exOC9PnRLgI6fBSdSfVPIEVSskKdjc6sp27j4tc1kH9yuaFrMqsH0WVD3YIcm7nSm93pCMpAxxdEPP5kJ4TCZpUs9Ma34l5UPSbkZU32iWnoH0WIoFzHTuQpGJAtLMiXcF4zOqRJQ59MXzL8/vG4im9dV15HezkPGXDLIEqEApqP6+5M7R/KsRu6N+I+v7NejpaD4Ax2/YlUbsp3Hs5t21Ti8BCKA2KRLY0rg9WpLoW0uPzPQY5uHCJIuFDO4ApIzRVzjcQKggKiEQIsag7RTbKrpDlazXawbV4dJFqg2eT9//PInOM2OxOhuftq6GN2FeTeqgJwpaQbK4T7oFJlpv+0fXgF8HfX/JJ/nLIqbyclHtPUI/vfMJ6WMBxSzKsG4y4X5pccIwfGd0amnnsi6DwROMDWqQQ0+b+hxA79JzxJrMRIWZ7ORXqJmixmbpe+xMvyRoT5xcJUnBEQ88LkIEqVblRFkl71giWO4C3NoI2GXkBIqQL8F7s8L+QBcdb8JJ8m70kydyA5wIrXs1OSoyVqS5FnrJXqruUW6g61FgqkLISwTwnFkaBroour/tTSAKVgUFHpzrQ0GDHvGsw5XhIrcPWrLfRnpPSXeDj6+jLgxBL/ORt47d+ci6qYrlwnZTTvHs+jiT4l9Y8E26qLN9kC/nh3FQ0Nezzgu/Cl5uN0Pv1iEREPycC68JvOvpsyyA8ak4GcB2gwOeppzTJCLgilHtgbicvSc1w/muq1jwfcFrzBSDuNGxnbc2Jgt8hAM84m+kKtOAbhAWlOX3GV1anC7+wa2sPO4fUPfytHu1h1ZYKOyZAjanBiPBzfGYYn1STNg6AG0NswM9+REEdQPxHDouYTIj2tuZ0OQYXdTSSyv5dBP/ugj79mZGCrsjXj/rz27Q3gT0CP2mak7NgaSeY5pvSSiVIIi5qDUvwFBuK5n9DcomBX4l8tx0knJcqQfc4ja4bQ4t4mpMR2FCZ6en+eWc0uAV2WvaYjVStrIeikPkNTiSm6l9Tv/Jj0eOU5XYXw/1C2tHAW4zfeZjwAjo0H/Opy/0SsUn0fj194wEsigwXdnnznLbvRJfokjeYho4mRdX/29keEHcwnI47zonFwCsyn0TXDV+j6maPVqqzsQbq+sJfZKtDlAzbPMPZTR1TBW9j2DKKC/yL5WorcIbqOHpyXvZ6NAu6OsY+IpfV2TRoCwbwDQPl6lvP06K0C57r7NkVY0uDQWS/fn2a5xwM4xfd1aWexDysRHgHUFCaVkg== X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 6:izRmrlDUKeL/TCIdCM3PEfSgSKcMZwqAhpHK1sKK/XFYw4hYDTfCL+jc5KxVJOHfonUVgnx5/jq7/7M/g7o17bTEaJNMqye2I+64ns1qEoewtO/8sE5K4Tk1qo3GD206LgtV0ilPKk4meaxdWegzIgL0Nwb8t5bhxa/Rh3069K2Sj5dsDDMmum3vlONrvEzXoCJ2nwnAORl0spuWRmUEABltWLGt8wRo5RZ4JvjqHAGDD8Flk3c9RrRsVj/Iy/PM79QsANvn3P7qZGK4K4tOlPK7/tufEYLzO7JRqlbzDpNe7NuCbC9MSTElZMkM+4MDs0MRt6J8O8nrSCq0kEbBvov0O9doVNy5JOAF5D2U0OU=; 5:yMev1BCd6vd8BlblxNWvQyv//FCSFaSZDktauPGt5fqvU9vrd8lRECcFbRGP+7xhsBLZILm02+yzk4CW1PWg0Io5pMuwvmXWENuHADwM8wkY3Y77zau64g+XlP+HY0nK7JTZNS4hSTNrXpvxbw3cy6dYBunujbHldY3oyMm/3xI=; 24:U5v6f0f5/WWqeN/+cJkWQxst5mq2Zd7jDsyET29bVrB9hN3YIdz/lrtD7+UvN3FUSr0p0oF8HmZNFKHO3QMkyhrHbL5WLRVd7nTB3Pw/SII=; 7:i8xjGgZwyYjonMGsthid/Lfz0ZG8wTrGP7NV8UomLhStgiKJ7d8xKjiAJPIcj7BXcCiOb/6h0VqZ7JjB4RhHt4GxQSKqEP1DLLjJQ8uNgTcTWrZEmCnmAECo9JdCYH9WTRVULoq8pfew5mlcu+1YNSZJB1yYl5ks5eKUy41njdYf+InHSUZGIvURCfdXn0FEkX+e+vsCk8abC5Gft1T7a3yYq6yPf+ZyeSwsPpt3cJ8thMpVgmj1un39dqMCGFvK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2018 05:55:15.1995 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e04e7324-1d3d-49a2-b9fe-08d571dd31c9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528 Subject: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since struct rte_eth_dev_data used in the fast path, making it as cache aligned. Fixes: af75078fece3 ("first public release") Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: Matan Azrad Cc: Thomas Monjalon Cc: Konstantin Ananyev Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- v2: - Change the git comments based on Matan's feedback https://dpdk.org/dev/patchwork/patch/35104/ - Some platform like thunderx + l3fwd showed 1% regression in the performance with 5b7ba31148a8 ("ethdev: add port ownership") in one port setup. - If there are no objection for this change then request to take it for v18.02 release. --- lib/librte_ether/rte_ethdev_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev_core.h b/lib/librte_ether/rte_ethdev_core.h index 315b31723..e5681e466 100644 --- a/lib/librte_ether/rte_ethdev_core.h +++ b/lib/librte_ether/rte_ethdev_core.h @@ -601,7 +601,7 @@ struct rte_eth_dev_data { struct rte_vlan_filter_conf vlan_filter_conf; /**< VLAN filter configuration. */ struct rte_eth_dev_owner owner; /**< The port owner. */ -}; +} __rte_cache_aligned; /** * @internal