[dpdk-dev,4/4] net/ena: enable WC

Message ID 1523455637-31719-5-git-send-email-rk@semihalf.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rafal Kozik April 11, 2018, 2:07 p.m. UTC
  Write combining (wc) increase NIC performenca by making better
utilization of PCI bus. ENA support this feature.

To enable it load igb driver with wc_activate set to 1.

Signed-off-by: Rafal Kozik <rk@semihalf.com>
---
 drivers/net/ena/ena_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Thomas Monjalon June 27, 2018, 4:11 p.m. UTC | #1
11/04/2018 16:07, Rafal Kozik:
> Write combining (wc) increase NIC performenca by making better
> utilization of PCI bus. ENA support this feature.
> 
> To enable it load igb driver with wc_activate set to 1.

typo: igb -> igb_uio

> Signed-off-by: Rafal Kozik <rk@semihalf.com>
> ---
>  drivers/net/ena/ena_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Please rebase this patch, thanks.
  
Rafal Kozik June 28, 2018, 1:04 p.m. UTC | #2
Hello Thomas,

I will fix type, rebase and provide new patch set.

Best regards,
Rafal Kozik

2018-06-27 18:11 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> 11/04/2018 16:07, Rafal Kozik:
>> Write combining (wc) increase NIC performenca by making better
>> utilization of PCI bus. ENA support this feature.
>>
>> To enable it load igb driver with wc_activate set to 1.
>
> typo: igb -> igb_uio
>
>> Signed-off-by: Rafal Kozik <rk@semihalf.com>
>> ---
>>  drivers/net/ena/ena_ethdev.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Please rebase this patch, thanks.
>
>
  

Patch

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 34b2a8d..415d89d 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1889,7 +1889,8 @@  static int eth_ena_pci_remove(struct rte_pci_device *pci_dev)
 
 static struct rte_pci_driver rte_ena_pmd = {
 	.id_table = pci_id_ena_map,
-	.drv_flags = RTE_PCI_DRV_NEED_MAPPING,
+	.drv_flags = RTE_PCI_DRV_NEED_MAPPING |
+		     RTE_PCI_DRV_WC_ACTIVATE,
 	.probe = eth_ena_pci_probe,
 	.remove = eth_ena_pci_remove,
 };