[dpdk-dev] eventdev: remove ethdev Rx adapter event type
diff mbox

Message ID 20180520164843.4386-1-jerin.jacob@caviumnetworks.com
State Rejected, archived
Delegated to: Jerin Jacob
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob May 20, 2018, 4:48 p.m. UTC
The initial thought was to create a separate event type
for each adapter, in order to make consistency with
new event adapters, remove RTE_EVENT_TYPE_ETH_RX_ADAPTER
event type and use RTE_EVENT_TYPE_ETHDEV event type instead
like other event adapters.

Cc: Nikhil Rao <nikhil.rao@intel.com>
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
 lib/librte_eventdev/rte_eventdev.h             | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Jerin Jacob May 20, 2018, 5:21 p.m. UTC | #1
-----Original Message-----
> Date: Sun, 20 May 2018 22:18:43 +0530
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Nikhil Rao
>  <nikhil.rao@intel.com>
> Subject: [dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type
> X-Mailer: git-send-email 2.17.0
> 
> The initial thought was to create a separate event type
> for each adapter, in order to make consistency with
> new event adapters, remove RTE_EVENT_TYPE_ETH_RX_ADAPTER
> event type and use RTE_EVENT_TYPE_ETHDEV event type instead
> like other event adapters.
> 
> Cc: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>


Self - NACK.
external PCIe NW cards + HW eventdev case will failing this case,
as RTE_EVENT_TYPE_ETHDEV identifier was used for converting to mbuf
in eventdev_dequeue case.

> ---
>  lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
>  lib/librte_eventdev/rte_eventdev.h             | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 6f7050952..8b9887b3d 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -468,7 +468,7 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
>  		ev->op = RTE_EVENT_OP_NEW;
>  		ev->sched_type = sched_type;
>  		ev->queue_id = qid;
> -		ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
> +		ev->event_type = RTE_EVENT_TYPE_ETHDEV;
>  		ev->sub_event_type = 0;
>  		ev->priority = priority;
>  		ev->mbuf = m;
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index b6fd6ee7f..cef0a55d8 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -948,8 +948,6 @@ rte_event_dev_close(uint8_t dev_id);
>  /**< The event generated from cpu for pipelining.
>   * Application may use *sub_event_type* to further classify the event
>   */
> -#define RTE_EVENT_TYPE_ETH_RX_ADAPTER   0x4
> -/**< The event generated from event eth Rx adapter */
>  #define RTE_EVENT_TYPE_MAX              0x10
>  /**< Maximum number of event types */
>  
> -- 
> 2.17.0
>

Patch
diff mbox

diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 6f7050952..8b9887b3d 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -468,7 +468,7 @@  fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
 		ev->op = RTE_EVENT_OP_NEW;
 		ev->sched_type = sched_type;
 		ev->queue_id = qid;
-		ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
+		ev->event_type = RTE_EVENT_TYPE_ETHDEV;
 		ev->sub_event_type = 0;
 		ev->priority = priority;
 		ev->mbuf = m;
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index b6fd6ee7f..cef0a55d8 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -948,8 +948,6 @@  rte_event_dev_close(uint8_t dev_id);
 /**< The event generated from cpu for pipelining.
  * Application may use *sub_event_type* to further classify the event
  */
-#define RTE_EVENT_TYPE_ETH_RX_ADAPTER   0x4
-/**< The event generated from event eth Rx adapter */
 #define RTE_EVENT_TYPE_MAX              0x10
 /**< Maximum number of event types */