mk: disable OcteonTx for buggy compilers only on arm64
diff mbox series

Message ID 20180903093110.3340-1-jerin.jacob@caviumnetworks.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • mk: disable OcteonTx for buggy compilers only on arm64
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob Sept. 3, 2018, 9:31 a.m. UTC
Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal
compiler error" for aarch64. The GCC "internal compiler error" was
observed only for arm64 architecture so disable the PMD only
for arm64.

Cc: stable@dpdk.org
Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 mk/toolchain/gcc/rte.toolchain-compat.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit Sept. 3, 2018, 1:32 p.m. UTC | #1
On 9/3/2018 10:31 AM, Jerin Jacob wrote:
> Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal
> compiler error" for aarch64. The GCC "internal compiler error" was
> observed only for arm64 architecture so disable the PMD only
> for arm64.
> 
> Cc: stable@dpdk.org
> Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Sept. 16, 2018, 8:04 a.m. UTC | #2
03/09/2018 15:32, Ferruh Yigit:
> On 9/3/2018 10:31 AM, Jerin Jacob wrote:
> > Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal
> > compiler error" for aarch64. The GCC "internal compiler error" was
> > observed only for arm64 architecture so disable the PMD only
> > for arm64.
> > 
> > Cc: stable@dpdk.org
> > Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

Patch
diff mbox series

diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 1e4434fa9..44904295c 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -79,11 +79,13 @@  else
 		CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV=d
 	endif
 
-	# Disable octeontx event PMD for gcc < 4.8.6
+	# Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64
+	ifeq ($(CONFIG_RTE_ARCH), arm64)
 	ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1)
 		CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
 		CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d
 		CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
 	endif
+	endif
 
 endif