| Message ID | 20181002133547.20526-1-jerin.jacob@caviumnetworks.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
> -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 2, 2018 2:36 PM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com> > Cc: dev@dpdk.org; Jerin Jacob <jerin.jacob@caviumnetworks.com>; > olivier.matz@6wind.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix csum parse-tunnel command > invocation > > Based on the documentation and help print, the sub command for csum suppose > to be "parse-tunnel" instead of "parse_tunnel". > > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org > > Fixes: 64fc36064dc3 ("app/testpmd: add csum parse-tunnel command") > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
On 10/2/2018 3:49 PM, Iremonger, Bernard wrote: > > >> -----Original Message----- >> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] >> Sent: Tuesday, October 2, 2018 2:36 PM >> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing >> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com> >> Cc: dev@dpdk.org; Jerin Jacob <jerin.jacob@caviumnetworks.com>; >> olivier.matz@6wind.com; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH] app/testpmd: fix csum parse-tunnel command >> invocation >> >> Based on the documentation and help print, the sub command for csum suppose >> to be "parse-tunnel" instead of "parse_tunnel". >> >> Cc: olivier.matz@6wind.com >> Cc: stable@dpdk.org >> >> Fixes: 64fc36064dc3 ("app/testpmd: add csum parse-tunnel command") >> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Acked-by: Bernard Iremonger <bernard.iremonger@intel.com> Applied to dpdk-next-net/master, thanks.
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 0c5399dc4..3376a665c 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -4367,7 +4367,7 @@ cmdline_parse_token_string_t cmd_csum_tunnel_csum = csum, "csum"); cmdline_parse_token_string_t cmd_csum_tunnel_parse = TOKEN_STRING_INITIALIZER(struct cmd_csum_tunnel_result, - parse, "parse_tunnel"); + parse, "parse-tunnel"); cmdline_parse_token_string_t cmd_csum_tunnel_onoff = TOKEN_STRING_INITIALIZER(struct cmd_csum_tunnel_result, onoff, "on#off"); @@ -4378,7 +4378,7 @@ cmdline_parse_token_num_t cmd_csum_tunnel_portid = cmdline_parse_inst_t cmd_csum_tunnel = { .f = cmd_csum_tunnel_parsed, .data = NULL, - .help_str = "csum parse_tunnel on|off <port_id>: " + .help_str = "csum parse-tunnel on|off <port_id>: " "Enable/Disable parsing of tunnels for csum engine", .tokens = { (void *)&cmd_csum_tunnel_csum,
Based on the documentation and help print, the sub command for csum suppose to be "parse-tunnel" instead of "parse_tunnel". Cc: olivier.matz@6wind.com Cc: stable@dpdk.org Fixes: 64fc36064dc3 ("app/testpmd: add csum parse-tunnel command") Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)