From patchwork Mon Oct 8 16:09:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 46282 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F4B01B39F; Mon, 8 Oct 2018 18:10:44 +0200 (CEST) Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0044.outbound.protection.outlook.com [104.47.38.44]) by dpdk.org (Postfix) with ESMTP id 26EAE1B205 for ; Mon, 8 Oct 2018 18:10:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a+pn9jIrPC6i4rChxyWpG4+keJq2SEXpO50RVhNhDCg=; b=ESOfyTbdx/13ZVaM1PXZTbCVcpoA+6obL7jV+8xp2UaVY64IC4CgXPrNRmJWXIKNQlA72SMs7MqN39CbO/v+arqfuO79bAHyNovqkO/vXTrL1LLRkz503DxyN/Y7M5FTHfOGJ/8zgjr4ZzImX2mYXD2rj+V2zlXOdNc4C0LhEds= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin.8.8.4.4 (122.167.112.78) by SN6PR07MB5005.namprd07.prod.outlook.com (2603:10b6:805:ac::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.28; Mon, 8 Oct 2018 16:10:37 +0000 From: Jerin Jacob To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, olivier.matz@6wind.com, Jerin Jacob Date: Mon, 8 Oct 2018 21:39:52 +0530 Message-Id: <20181008160953.32510-3-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181008160953.32510-1-jerin.jacob@caviumnetworks.com> References: <20181003181657.32236-1-jerin.jacob@caviumnetworks.com> <20181008160953.32510-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [122.167.112.78] X-ClientProxiedBy: MA1PR01CA0087.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::27) To SN6PR07MB5005.namprd07.prod.outlook.com (2603:10b6:805:ac::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bea2d00c-a7f8-417c-20ed-08d62d389852 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5005; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5005; 3:c0JKNO9PO6T4CJ4pkkhyVu2jpKEm5ZiEq3Ey+HJgfdpvFHlee+sb5M4nFV1Exrcqx3vanicbE/zls/3jX5yRhb9jzWz7+cBxRod2nBb4mAatF1wned32t8Bl+siM7fn3s821vr4XiSbquB2TRDcpwNBF1q9dlBDllskznwKr0rXMlN7Azz7nuZFQ2IO79iiE+Gbn+HDzc/g1yA+nybCUjbsvmmkw51R0yDLYxS/EhImCRNUxPLzapTm1ODglrMHW; 25:UNmkh7T2Vupgh4g4RB3YjMBsuJh5mjVPsEy0J9ZqkZaZ1fUd+zZd3qa7KQobOZM8N8INlJK7l17qbsucRh7XDkBb2b0wEXqJ9elLZY8q5Urrelaynb9lMcHiQ1hSs4UsWreR7rIIyigeW9/1Q+BV4Fa0qPUAAWhwZ5WBaqbbCBIsmJjUx6ivjAsaO5yklyvIKOPoMLuZJMDPhF0pWd9lkREXq8uXMrE1fHodm6wBeROzRRefK770obwqcDDvMYC8NMxIYHEtPP8wurohrz8EhuL8GCudkvyFyRolT9oCQiZvlRfPEjN+XgxslI6d4NBN9g1HfdByPo7TI2CbeR4W6w==; 31:wydcC2jPcqHfQ+IFqPAcEL58FncmV5UUAY8+oZkxNg7F9Jq7SsR9ohqYIi7ZOY8AXwLwmtEzB210VFMs7IjKVSvx2VGMlqZMj0wiE0CvkzcWIKIIauTFoqpgnz3A3wXdaR9o/3xFaZKG6x4gwfL02EJ0aBkcfC/xgiWUkUU7PG0k4V7EXptpEkBylsSciNyl/JuPD3zDU3pALyeT2SBrgGLST7TawgJ1ahbkVho8Cnc= X-MS-TrafficTypeDiagnostic: SN6PR07MB5005: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5005; 20:XZzD5/PNmhx3+cjOPlyglrtScjuZJYuaQOCiD8SZ6GYquEKHznmiRhGN45F0rtURIc2DF4geavYGFTVXpR/odKUZnU+fi7swrqvstGrG5xPjce2oN+ttdRZ7/BTaLBjERMDUZiFG0jjTXa9rBJ3zh3NWjC9Djm1ZGrBWnyffB+Wcb2ntJrIQPYPnh7Uyx81l5AmDo7/I/jDmwvC82JG4Tlx2vM/6MLfvaREWNbLOq8r6bnJfwclWHDV+3uHrMmSQ8LkSWwLCm/QIDvS/vgF2u8EbRKNt19ziBGGZgGcoJ8ExhmzsUjF5B0/Qrp6rGal/SiXd786Nda3NDCEcz6oHvsycxqZaFbXKUJHFdJw5bIeHKmzQ60JwbwIdM3h0avFHgQLZDTDnwIcihNoGjle8vKi3/NQTXIZL0xT4cjdYz3P+l1IhZjmtxaYRVyBVGMyzYNTYOIQJi3444Qf1eIpMu56654TXc1Hc0h/5LIDSeMNqGmc7tQGeAbY5KbqzJIrWThczE+JQKcBglTMNpVZ+O2ULchBT+riqNiLW8rusN0t77AoDafnFPnXYarwCcrj6S2YKwofDjqpVEdMuhjzied2Dynzwoh00xoqZsAjV8aQ=; 4:uHP3/nUCTRS+eeP7DLWlQKMu8v+jFjLnitjwIcIdjdxYwc9IPx6kpdRTOgn2wKryt0ID4+mqwNbWKtF3kTNOgDf+LRechEXfvc+3zMlmvc0lPubZ5nvfESZ74hbyWi6hmQm0P34vZ/DZ9iJ6vsUZbBGv2znAS4hUzq1xpe6soeRpnB04SDoNBpBT3hGqmOp0u3RJRjdq7+LR9k34UGEVvvgciRMnn75JflsZhOoYvXiDY4EbBhrPhx9+B1yCY3u6dEV/eaWiliSxsC5UV2kuHAy5P/YJRH2vcKeB8j3cTFfiTXJM1FriSW8K1TOjP+qX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051); SRVR:SN6PR07MB5005; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5005; X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(136003)(366004)(396003)(346002)(376002)(189003)(199004)(36756003)(305945005)(2870700001)(72206003)(25786009)(42882007)(97736004)(956004)(476003)(5660300001)(7736002)(2616005)(11346002)(446003)(478600001)(6666003)(2906002)(44832011)(486006)(4326008)(14444005)(3846002)(6116002)(48376002)(50466002)(105586002)(66066001)(26005)(1857600001)(16526019)(186003)(106356001)(47776003)(1076002)(53936002)(107886003)(316002)(76176011)(52116002)(68736007)(51416003)(110136005)(8676002)(50226002)(8936002)(7416002)(81156014)(81166006)(386003)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5005; H:jerin.8.8.4.4; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5005; 23:o6IqWp3zvU+/rAqRPQT7bOX57MpFrNPP64YaFdaeA?= uCodC9I4zAa0vB35amO9coQKw7ZHnf+ERgvZvHLdaQSBWeXPGipXRcqJvOuoTSV3MwPgMbZWI6q8+eMmxxJXH1+ADkV4LRzOgHmg6QOEkH6UF9sHdOa2MYv//nM3YxdrbRpvZ3maUng12oiZJDqES0BBAZwo9Ots9WbwL3MQgmwbOYubWPNPtVkkhGBPvfSQZBLBjgkuD9yWO/ki5FqReb8IQuS8rd+HalkfM5Yr0zBX4UVD/4jMZ87PxnhwlCdhGWxUZq8I3HcPZ7gt9hvHP039Y/UHBrd1aKbr2kZtKmsE4ARQb55RCSE1Z4oiju+3Te+2pev/LdsNXnWTlwQScmdHQkCqd54yhSf9IrFIUPXyQjTEx0SZOUhb7O7uo1NZKSSw8WZcTW/n1+NHrYpE2FshfCpmRE14FmOCOOcadmXAUqBuWpoh1avtGDheLYIubmCecglV/rsCh3lGbKRgCxAVzQ2JkhitNZ645EkE3AYY6rtMpDeekaXhlgWFaliPtF29dSscWtGQX+SNyakyR+14Tr1n/jvT9QzKKLl4WBoCmafnMkrn/6OJvvqy3tqBJoFptPsTucdT44188a0tnmsMmhR3qJsRQJmVQEjBBf6rD92rh/fOQxdDEva+XDBRb81aZ4i1Sj/a1AlPtL72v5QQPH0+hJDkgZq6rc2kv7y1K2Q7feZqa/4jVYsMH3WYvj5pU2dod1nixNC/s2/7BcscwA4KLmS+0bK/81nm8dCQBbGBGP72lrMF20gGrJVB9ot2MjbeMEvB95Si5YjEffR2M/G2gPjC9CvG1I4CoBkffWTbaWqD+jTFs+hYOGeG0mhXLoL+hje/sQLTXqxIpZBMQGCdg9qb4Lj0Q4afb82uobVSVT/+eHpaW/NXzkgnuyaVMr9+nsBhUA9hDZHAjLB0YdLIM+b1yIhl5UW1Kv9Bz9D2ZlQ2RFR6mOY1xXoHeLYGoItW26MHSap9kVzGvEinbMQ0fpoMrFEMiiSaCZWgw9NJs8JMBuN9Eg5puVbbwAcHLGNuE+fAOLFoWjm57XtrkGr+lUDh3UnAbM956+CANliHkAGNpzTm5EYnvnUZl7BIeCYugJP8L5v71oIgpDa/Z0rak59U8bITCCWAe7kQYJrSuZ0w9Kchg//fu6Bxc4OqRyzTm3ifCkPRG6YTdemdeeLJ00gUTIflb3MC1JUZo0ZKkiRtxrLZjFAblfaVNhgMztzYqA7I838zYt2kgyiutLrZG3e8JiUuPK9rlMgHA== X-Microsoft-Antispam-Message-Info: 1J3e/3nk1fxA7htFx+sIJqSMV32q7/07YCEp1VycXRYttdGNJZBzytOTnKzFtVxdlY2aX9gPtnHVxmN4gnEJ96DJuPu7i8O/vDp4BFnMG269qpizO7zkLFZwPs4MoLT0kk/frEJdmQdyjDTjrPd4aw1C163i9dLcJv9lFt+GjJN6ZOTnIThPyWlJhNdb6DWTPGXMwI0HeIASoz95r03Ps975P0z/yCDDMSLKmYCCzDVSF/B0lF5N05ZcAO0+aDXEiMImGD9Bj9y3Qf/5oQR6P7SwwHSo3i8VeXZUbQlWWAAYffI1bt5eFS0UF5eAo9NSzCciTAFa719733PhlHbdhlcoSHRTnEnP4A3w/GsK5I4= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5005; 6:dUGzUJv3fIRQhHsHchCffyouqrcP5eQ/KVKnPm+rFrgZDKerOFO3f1Aw6LAOm8vwl5ow+XqbGT/M7kaiULgZoXRrTrllBq+ZJ1MgsceuMFgjeWY/iiJ//VvxbLoikxX+HzyQJTk/exLTl41fZ8Pq8pSpzI8EUQspUh+JGcZIvBykDLjY0GIsf1OIjcsKpLTZi/18arQ3TkjNxKcjeeBikF4qZzfVZHmkGDfLBx6eQu+aK4tNwTadrFM3M5JsATkxub0vLKScprkOcUnVuOufSilcj7Fn1dZRDdGsmlhv8cSf2yCo4Oc+VTBdspV9Syw0gfPLjBkSwvXQ6bZcKWiOriN3C0y2MD1uhJlv/4ypxqUjJ8Gc6JX3ao7kuTaQsdDUDESBX6A0hqqYvlBuZaUytR4ZLB40QB8rLZnQ/oJL1OItnCI68tPDjfHevwdnEELbE4r4zaRufC5ptnYMskapEA==; 5:OV2cT6wTOJXHgZvfEIqH/QaT9J+YRaELZ8PgjZdMLXicmhPbiL6jLvW+VZYGAH8cn7hXGjMIwbo7ZX8w18Phr/dE/tCslvNxM3yWIep/Qe3z4acDoK+JnMu4Nk9H8MVtpSqYAiHemajHVc4Nt3RDK6RrWKVAPcFelVvyS7gz5G8=; 7:vkMJgwf9SIJD4m/vDZr9+h/cZ0HQATa2GHdqopChEj6td5tb7JcJE+Y10thdcf8Kta6aK1zSY0MjczqCh7BaGHmkJQ/Dq/HmmsHCKyhkxrGg4UQqedNvtVBosx3iLxlRsPBPcoT5imNYglR5RfvzIhwviSaUEBEZuqFtuY3MoUjk8deqaxKjoFI7e81B8ZMhxagJ0ENv3ov/yO+OzBba4GvB/aTADdjQRn0vZhwjWXrUsf6w8j+Ghn7uja23xRSo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 16:10:37.6203 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bea2d00c-a7f8-417c-20ed-08d62d389852 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5005 Subject: [dpdk-dev] [PATCH v4 3/4] app/testpmd: add outer UDP HW checksum support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Added outer-udp Tx HW checksum support for csum forward engine if device supports DEV_TX_OFFLOAD_OUTER_UDP_CKSUM. Signed-off-by: Jerin Jacob Acked-by: Bernard Iremonger --- v3: - Added Acked-by: Bernard Iremonger v2: - Added outer-udp support for csum engine --- app/test-pmd/cmdline.c | 24 ++++++++++++++++++--- app/test-pmd/csumonly.c | 13 +++++++++-- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++++-- 3 files changed, 38 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 0c5399dc4..2fd007423 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -397,12 +397,13 @@ static void cmd_help_long_parsed(void *parsed_result, " Disable hardware insertion of a VLAN header in" " packets sent on a port.\n\n" - "csum set (ip|udp|tcp|sctp|outer-ip) (hw|sw) (port_id)\n" + "csum set (ip|udp|tcp|sctp|outer-ip|outer-udp) (hw|sw) (port_id)\n" " Select hardware or software calculation of the" " checksum when transmitting a packet using the" " csum forward engine.\n" " ip|udp|tcp|sctp always concern the inner layer.\n" " outer-ip concerns the outer IP layer in" + " outer-udp concerns the outer UDP layer in" " case the packet is recognized as a tunnel packet by" " the forward engine (vxlan, gre and ipip are supported)\n" " Please check the NIC datasheet for HW limits.\n\n" @@ -4177,6 +4178,8 @@ csum_show(int port_id) (tx_offloads & DEV_TX_OFFLOAD_SCTP_CKSUM) ? "hw" : "sw"); printf("Outer-Ip checksum offload is %s\n", (tx_offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) ? "hw" : "sw"); + printf("Outer-Udp checksum offload is %s\n", + (tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) ? "hw" : "sw"); /* display warnings if configuration is not supported by the NIC */ rte_eth_dev_info_get(port_id, &dev_info); @@ -4205,6 +4208,12 @@ csum_show(int port_id) printf("Warning: hardware outer IP checksum enabled but not " "supported by port %d\n", port_id); } + if ((tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) && + (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) + == 0) { + printf("Warning: hardware outer UDP checksum enabled but not " + "supported by port %d\n", port_id); + } } static void @@ -4273,6 +4282,15 @@ cmd_csum_parsed(void *parsed_result, printf("Outer IP checksum offload is not " "supported by port %u\n", res->port_id); } + } else if (!strcmp(res->proto, "outer-udp")) { + if (hw == 0 || (dev_info.tx_offload_capa & + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) { + csum_offloads |= + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM; + } else { + printf("Outer UDP checksum offload is not " + "supported by port %u\n", res->port_id); + } } if (hw) { @@ -4296,7 +4314,7 @@ cmdline_parse_token_string_t cmd_csum_mode = mode, "set"); cmdline_parse_token_string_t cmd_csum_proto = TOKEN_STRING_INITIALIZER(struct cmd_csum_result, - proto, "ip#tcp#udp#sctp#outer-ip"); + proto, "ip#tcp#udp#sctp#outer-ip#outer-udp"); cmdline_parse_token_string_t cmd_csum_hwsw = TOKEN_STRING_INITIALIZER(struct cmd_csum_result, hwsw, "hw#sw"); @@ -4307,7 +4325,7 @@ cmdline_parse_token_num_t cmd_csum_portid = cmdline_parse_inst_t cmd_csum_set = { .f = cmd_csum_parsed, .data = NULL, - .help_str = "csum set ip|tcp|udp|sctp|outer-ip hw|sw : " + .help_str = "csum set ip|tcp|udp|sctp|outer-ip|outer-udp hw|sw : " "Enable/Disable hardware calculation of L3/L4 checksum when " "using csum forward engine", .tokens = { diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 494829266..ea5b112d6 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -468,10 +468,15 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info, if (info->outer_l4_proto != IPPROTO_UDP) return ol_flags; + /* Skip SW outer UDP checksum generation if HW supports it */ + if (tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) { + ol_flags |= PKT_TX_OUTER_UDP_CKSUM; + return ol_flags; + } + udp_hdr = (struct udp_hdr *)((char *)outer_l3_hdr + info->outer_l3_len); - /* outer UDP checksum is done in software as we have no hardware - * supporting it today, and no API for it. In the other side, for + /* outer UDP checksum is done in software. In the other side, for * UDP tunneling, like VXLAN or Geneve, outer UDP checksum can be * set to zero. * @@ -826,6 +831,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) if (info.tunnel_tso_segsz || (tx_offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || + (tx_offloads & + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) || (tx_ol_flags & PKT_TX_OUTER_IPV6)) { m->outer_l2_len = info.outer_l2_len; m->outer_l3_len = info.outer_l3_len; @@ -898,6 +905,8 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) if (info.is_tunnel == 1) { if ((tx_offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || + (tx_offloads & + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) || (tx_ol_flags & PKT_TX_OUTER_IPV6)) printf("tx: m->outer_l2_len=%d " "m->outer_l3_len=%d\n", diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 3a73000a6..cfcabf6f0 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -857,7 +857,7 @@ csum set Select hardware or software calculation of the checksum when transmitting a packet using the ``csum`` forwarding engine:: - testpmd> csum set (ip|udp|tcp|sctp|outer-ip) (hw|sw) (port_id) + testpmd> csum set (ip|udp|tcp|sctp|outer-ip|outer-udp) (hw|sw) (port_id) Where: @@ -867,6 +867,10 @@ Where: as a tunnel packet by the forwarding engine (vxlan, gre and ipip are supported). See also the ``csum parse-tunnel`` command. +* ``outer-udp`` relates to the outer UDP layer in the case where the packet is recognized + as a tunnel packet by the forwarding engine (vxlan, vxlan-gpe are + supported). See also the ``csum parse-tunnel`` command. + .. note:: Check the NIC Datasheet for hardware limits. @@ -940,7 +944,7 @@ Consider a packet in packet like the following:: * If parse-tunnel is enabled, the ``ip|udp|tcp|sctp`` parameters of ``csum set`` command relate to the inner headers (here ``ipv4_in`` and ``tcp_in``), and the - ``outer-ip parameter`` relates to the outer headers (here ``ipv4_out``). + ``outer-ip|outer-udp`` parameter relates to the outer headers (here ``ipv4_out`` and ``udp_out``). * If parse-tunnel is disabled, the ``ip|udp|tcp|sctp`` parameters of ``csum set`` command relate to the outer headers, here ``ipv4_out`` and ``udp_out``.