| Message ID | 20181023085217.18548-1-alialnu@mellanox.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Thomas Monjalon |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08B931B3C0; Tue, 23 Oct 2018 10:52:34 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) by dpdk.org (Postfix) with ESMTP id 68F755B38 for <dev@dpdk.org>; Tue, 23 Oct 2018 10:52:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Gp2xNrlWhLb6lmNyiDfM6USZ/TAAgsG1jAiV+jiJ+w=; b=JE/w/Ggv5oO/Y/icUGePoTgbVwYioQxG6wzCIW/eg6RGeaY+S6DSEs3Q8+O5w91NF4rVKNcSk5Xqi5h74F99QLf45+LvOAm756/Dy9WIK7IcIhuWPKhn89F1Q4sz1ZYkZWUHT9fBELAlNvjbVpaTb7rNHeki88/LgzS89cn1s2E= Received: from VI1PR05MB4269.eurprd05.prod.outlook.com (52.133.12.22) by VI1PR05MB1917.eurprd05.prod.outlook.com (10.166.44.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 08:52:30 +0000 Received: from VI1PR05MB4269.eurprd05.prod.outlook.com ([fe80::68d6:1233:5e0c:143a]) by VI1PR05MB4269.eurprd05.prod.outlook.com ([fe80::68d6:1233:5e0c:143a%4]) with mapi id 15.20.1250.028; Tue, 23 Oct 2018 08:52:30 +0000 From: Ali Alnubani <alialnu@mellanox.com> To: "dev@dpdk.org" <dev@dpdk.org> CC: Thomas Monjalon <thomas@monjalon.net> Thread-Topic: [PATCH] devtools: disable coloring of git-log output Thread-Index: AQHUaq27dMsntGL44kmc48mNLw12NQ== Date: Tue, 23 Oct 2018 08:52:30 +0000 Message-ID: <20181023085217.18548-1-alialnu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.19.1 x-clientproxiedby: LO2P265CA0344.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::20) To VI1PR05MB4269.eurprd05.prod.outlook.com (2603:10a6:803:40::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=alialnu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1917; 6:LnOcIfk5BiGh4BL7TV+ye5sC6PUP/OlX6y1jSqa5NhnEbT12qmOaAeY6KWqIPK949c/pd/WWpWEAIeOCx7OtAr5bow/HRQXz5KGmzBFpyfivy6vyEXwSNEtkKJoIbumH/FW16RAboSFvDghEmad5rSdUM2CgXdPIzfGTxF0Ria85Ui72fDKWCYUMxOBzguHHTD1fFeC7JBGXn5T/d/BSXlXlD5L0SYyysPcFUVPPuEaizad/P9SbdM5jNCWZg9jdTR9aXPvdY7NxaO7X3ufPu3q1DrhVuYdz58ofBrhSTeaJeAKPq0KJwBFykI7CpjQtFVejc+SQj9iVbRbkNlqy0NNpdg4Z8siTglJAwuTRcfrz4fSYHGnHrwmpl8ZKnSAP+U3B8M9oQdivViCY0N+dMqCrYpPwTV9ssH9+gsJeoGlyZ/zOJWktkphHJBY4iIuBTvoFvyLh0hX4cZrUcrJqsg==; 5:Ci+L6x1TkoNb8AdWb80pxJJweFHPyg4wCu/wz1BY4ONsjVZGEXjefkj6chBDa5m+Sl6QFxmo1koRIM5aE3Lji57Rl5Gbf8j5JdnO9gL37QfKPnHRPSZSrqm9+pGuZ+sllKCTn0aIBUNrHaOUhCgQ5fJtcBHtv+Slb+bOtJo8tm0=; 7:YcvmYKQFHFF0jZnehIaa6wYwW+ZNu/Gk/iY6xRgMq/g9HFCu6cohXz3jVz3FvwP2uzmul3GPGjQfszxlERLwX+JNLIcqXeDoWhfwz59lgzg4opFPNn4jt5zV46qO//HgXIc5VaJdHF92bUl+sBXlOKYCmXrPLLUU72Nyg7T2sEg5DgHRbZaZa/3g8mkL8dtnHO4peVV0VPWJ06TpyUTw4c5IzyJ+sfnzdzDi7buW5lM/SpQ0LIHF7q/YHSP4xyi8 x-ms-office365-filtering-correlation-id: e2748179-f2c1-45b2-2b21-08d638c4dd6e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB1917; x-ms-traffictypediagnostic: VI1PR05MB1917: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: <VI1PR05MB1917B253AF715CF565D9021CD7F50@VI1PR05MB1917.eurprd05.prod.outlook.com> x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:VI1PR05MB1917; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB1917; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(366004)(346002)(39860400002)(199004)(189003)(66066001)(26005)(102836004)(2616005)(105586002)(6916009)(1857600001)(6506007)(386003)(97736004)(186003)(68736007)(476003)(6116002)(2900100001)(53936002)(3846002)(6512007)(7736002)(52116002)(99286004)(1076002)(6486002)(6436002)(5640700003)(486006)(86362001)(575784001)(81166006)(81156014)(478600001)(5250100002)(256004)(14454004)(1730700003)(4326008)(2501003)(305945005)(2351001)(36756003)(50226002)(8676002)(5660300001)(8936002)(316002)(71200400001)(71190400001)(14444005)(106356001)(25786009)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1917; H:VI1PR05MB4269.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: fV1EEFvaxOOPUGhhDfl+Rk4c8paI7o0u2N/Fwa/hwvYPDjKpSyiEz+6xTPf/dnBmPhTTKfjsO95BUslhm78M047d6Z1Uxci6qni7x7cClr6EeUvsMkEmwcsA32s4VaQZjEqIpsSgRlCxNSXefq6q/8qGmRI9azdOqQ2+Gr4WekveDqyLnxsI0NLv36C4y7ivzxbE1q9CoV2X+hfDOVBmehTIkeLpJ77+yA5rwT88EayZL+zAImQwp/8sqT/2f8eslYcFkASY84BWPA92w7xOpN+9DCazeZ6diPjLLg84GQTB8miGbk1y0nDm99e/e45zmb6uqoRugAca5xJvIT5m5Zzdw4u7WxFA+xaMIbpa4rU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2748179-f2c1-45b2-2b21-08d638c4dd6e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 08:52:30.6577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1917 Subject: [dpdk-dev] [PATCH] devtools: disable coloring of git-log output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
devtools: disable coloring of git-log output
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
| ci/ci/checkpatch | success | coding style OK |
Commit Message
Ali Alnubani
Oct. 23, 2018, 8:52 a.m. UTC
Colored git-log outputs will have escape characters
appended to hashes, causing check-git-log.sh to fail
with `error: malformed object name ?[33m<hash>?[m` when doing
`git tag -l --contains <colored_hash>`.
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
devtools/git-log-fixes.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
23/10/2018 10:52, Ali Alnubani: > Colored git-log outputs will have escape characters > appended to hashes, causing check-git-log.sh to fail > with `error: malformed object name ?[33m<hash>?[m` when doing > `git tag -l --contains <colored_hash>`. I guess it is due to a config specifying to color "always". > Signed-off-by: Ali Alnubani <alialnu@mellanox.com> > --- > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > -git log --oneline --reverse $range | > +git log --no-color --oneline --reverse $range | There are a lot more "git log" calls in this script. I wonder whether we should add this option everywhere.
diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh index e37ee2260..464b0a41a 100755 --- a/devtools/git-log-fixes.sh +++ b/devtools/git-log-fixes.sh @@ -94,7 +94,7 @@ stable_tag () # <hash> fi } -git log --oneline --reverse $range | +git log --no-color --oneline --reverse $range | while read id headline ; do origins=$(origin_filter $id) stable=$(stable_tag $id)