app/testpmd: fix qinq strip display option
diff mbox series

Message ID 20181026124000.538-1-jerin.jacob@caviumnetworks.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • app/testpmd: fix qinq strip display option
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob Oct. 26, 2018, 12:40 p.m. UTC
Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.

Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")

Cc: shahafs@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 app/test-pmd/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Oct. 26, 2018, 2:34 p.m. UTC | #1
On 10/26/2018 1:40 PM, Jerin Jacob wrote:
> Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.

I think this is not typo but confusion caused by DEV_RX_OFFLOAD_VLAN_EXTEND ...

> 
> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
> 
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Oct. 26, 2018, 3:11 p.m. UTC | #2
On 10/26/2018 3:34 PM, Ferruh Yigit wrote:
> On 10/26/2018 1:40 PM, Jerin Jacob wrote:
>> Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.
> 
> I think this is not typo but confusion caused by DEV_RX_OFFLOAD_VLAN_EXTEND ...
> 
>>
>> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
>>
>> Cc: shahafs@mellanox.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

Patch
diff mbox series

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 169662321..fb79dd0be 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -583,7 +583,7 @@  port_offload_cap_display(portid_t port_id)
 	if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_QINQ_STRIP) {
 		printf("Double VLANs stripped:         ");
 		if (ports[port_id].dev_conf.rxmode.offloads &
-		    DEV_RX_OFFLOAD_VLAN_EXTEND)
+		    DEV_RX_OFFLOAD_QINQ_STRIP)
 			printf("on\n");
 		else
 			printf("off\n");