From patchwork Thu Nov 1 08:46:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 47644 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86F984CB5; Thu, 1 Nov 2018 09:46:46 +0100 (CET) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-eopbgr810051.outbound.protection.outlook.com [40.107.81.51]) by dpdk.org (Postfix) with ESMTP id 1EEF110A3; Thu, 1 Nov 2018 09:46:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kEiK5duQbKFGMuh6bcJeAbzJmtNQXpFvEHuwsq1oGt8=; b=hN/FJ9zWFcoXCcIMWgM0OBwOm35q6ZFuQ7Tw2y22+I9saHCTCQfJncALlU751O74peFzdaxG30Pe5OXJpdX9JeVJtQ0R5DJe3wsVYTUYBkDsVIbZPFtN1mUfcVyZurn9Vi5xR9PAw0uEi1hWdz7Y3LPy8m28zNgPZn1aPfuJDLM= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB5719.namprd07.prod.outlook.com (20.178.0.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.31; Thu, 1 Nov 2018 08:46:42 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::2d56:eab:242f:fdfc%2]) with mapi id 15.20.1273.027; Thu, 1 Nov 2018 08:46:42 +0000 From: Jerin Jacob To: John McNamara , Marko Kovacevic CC: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "olivier.matz@6wind.com" , "Jacob, Jerin" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: clarify TSO Tx offload prerequisite Thread-Index: AQHUcb9pQgmYraTf3kmows1PEaJ0yg== Date: Thu, 1 Nov 2018 08:46:42 +0000 Message-ID: <20181101084546.4393-1-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-clientproxiedby: BM1PR0101CA0036.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::22) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5719; 6:HcoFcUiMuTuVbMaV0xWwr970yXeTSaNESFdULGlu9chwRMr10mz/tlv3BEfDJ7adLdnT9jaNgoAW5quHY2eOzNSMpNMAQXyXzXColC31k/LhgfMnOhDh95qwWO9+ll1y4LYt/tRBQn8qWF9Gv4sa3ikQihXMc0/PZs9g2U89iAbQ6h/kU1E/tYKd5qSOptnwQKXvJ2vPeWPA+bgpv1BVnmUdSkJOtKXUSsxlD6ACqejjfR3GwB4BADAy2FILQTKTbaELLTH/jd4DWMrHoC1mFgFbu0I9yXFETga6/i5fa7vDmGEjHytuCklYhJLXgQ0Ww8kBrxVGGO0tQVpNKNsXhySC0Hoy3JPGwZRAMVOKEGLn4OVrh3yNCZv31TOje7PC4PxGkQefHx2vLX7zjLRw66JaEqT2/L5oOjpPC76/1nLhets7c6oUMAJ+JU2XiSaS1QViVsJtr6v4Vl9fL1DHVg==; 5:PrczlWVa9r9qs3JsOPwmVdVBkEPHpjg7pWr4rjt+Vxfl56ikO6AdrvhxHSIcVGBVU+zQwWuDxKKEqQKkfMl8Ti1yJo7Sa12gJhr0torVNoEz9KjIxgQlEPNlwVCpCFPVeR9pehrdso+x6qT7+YyLe8kXW3+jT3qpo11V4Mb7yPY=; 7:O9JafInmznd8tivWr5CcrNeRTk2zIEQ/iHNp7n4SJX3b/+nd1bsDcRwbC5roIrnaj0+SJqzxyLsyxiS3c8DXS5JXMzh27cS64zEGYOQTj8SB7KaNtELe9BcBNTmKSYFvGgxLfaSXx2KD9aBibEW/SvRny/A3yKh4kFBdz7eoFR/Xu411yBT/yg87K0BvVLx1GflV8GYYvjIqeEpm1FDr3oLkCV1q5/iov6+GAeOPttuPM8phO/acR0HXY3jhyrfu x-ms-office365-filtering-correlation-id: 995e1573-e24b-4929-f152-08d63fd68b71 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5719; x-ms-traffictypediagnostic: BYAPR07MB5719: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB5719; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5719; x-forefront-prvs: 0843C17679 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(136003)(366004)(39860400002)(346002)(189003)(199004)(2616005)(52116002)(256004)(386003)(68736007)(8676002)(7736002)(14454004)(4326008)(476003)(186003)(14444005)(26005)(99286004)(305945005)(54906003)(66066001)(6116002)(106356001)(102836004)(8936002)(55236004)(81166006)(1857600001)(42882007)(6506007)(110136005)(1076002)(6306002)(2906002)(81156014)(478600001)(486006)(3846002)(72206003)(5660300001)(105586002)(71190400001)(36756003)(6486002)(6436002)(2900100001)(25786009)(97736004)(5250100002)(966005)(6512007)(316002)(53936002)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5719; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: xVghF/RS5Syq+ubj+LcRFqZFK+8wf1VHXFk7DgMuaX0571dUSgv5e96KF2qhs4GKUThW1TogUdUNGrBf4acjzq6X38EK746h9Qr1Rt0NoTWM+KbJZ6KlaP6dMpIPBXy0W/A9IPHCYOxLro3Vv87/YcutCUbkkdaJqQUheXxar9xSFW8AnvJMSMQGfwR+gHkcZFULJHXqJC4VjQIoXURIZDj2ORr5j7ULGHSAcbDdEddd9ExDv5MZWssuQLYtj/4nr2wvwdINcsXNJHe9j7H+qiCwfxmZVP/DqCwILYCSXJtVclluFLk1VUzcVKqN8SrHqcJWQAbhqSkMyDc61x1YAXSq8vmdG8CvUcO6MUkyBTs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 995e1573-e24b-4929-f152-08d63fd68b71 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2018 08:46:42.6274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5719 Subject: [dpdk-dev] [PATCH] doc: clarify TSO Tx offload prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Based on the PKT_TX_TCP_SEG definition, the application needs to update PKT_TX_IPV4 or PKT_TX_IPV6 based on IPV4 or IPV6 packet and PKT_TX_IP_CKSUM ol_flags to enable Tx TSO offload. Fixes: dad1ec72a377 ("doc: document NIC features") Cc: stable@dpdk.org Signed-off-by: Jerin Jacob Acked-by: Ferruh Yigit --- Definition of PKT_TX_TCP_SEG https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n289 --- doc/guides/nics/features.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 3fa5cb745..d3f904839 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -208,7 +208,7 @@ Supports TCP Segmentation Offloading. * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_TCP_TSO``. * **[uses] rte_eth_desc_lim**: ``nb_seg_max``, ``nb_mtu_seg_max``. -* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_TCP_SEG``. +* **[uses] mbuf**: ``mbuf.ol_flags:`` ``PKT_TX_TCP_SEG``, ``PKT_TX_IPV4``, ``PKT_TX_IPV6``, ``PKT_TX_IP_CKSUM``. * **[uses] mbuf**: ``mbuf.tso_segsz``, ``mbuf.l2_len``, ``mbuf.l3_len``, ``mbuf.l4_len``. * **[implements] datapath**: ``TSO functionality``. * **[provides] rte_eth_dev_info**: ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_TCP_TSO,DEV_TX_OFFLOAD_UDP_TSO``.