From patchwork Sat Nov 3 14:58:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 47787 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12ED4A49; Sat, 3 Nov 2018 15:58:59 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690073.outbound.protection.outlook.com [40.107.69.73]) by dpdk.org (Postfix) with ESMTP id EC656201; Sat, 3 Nov 2018 15:58:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Yo4Un9es8LMvX4ow3uXGYMGJ2PYcDs9K+tgkcnE+Eo=; b=AGVEtAREiM5ojUd0lWaLjBGHCbOcmEyhWR0Ro6QpTHviUz/nukoJm9JvLtTZPyg8d1c7v3tOe0v7NtTn93XrLeQWadEUkGAGfAbanz2GrE0ZL7oeTKfzyjjZ0Y86Q7okyBCMtQkcyWpd9JJQqHX7FF4C57xMUXy8Ew7tqkMIDmo= Received: from SN6PR07MB5008.namprd07.prod.outlook.com (52.135.121.74) by SN6PR07MB5423.namprd07.prod.outlook.com (52.135.120.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Sat, 3 Nov 2018 14:58:54 +0000 Received: from SN6PR07MB5008.namprd07.prod.outlook.com ([fe80::913d:1a21:cb40:16de]) by SN6PR07MB5008.namprd07.prod.outlook.com ([fe80::913d:1a21:cb40:16de%3]) with mapi id 15.20.1294.027; Sat, 3 Nov 2018 14:58:54 +0000 From: Jerin Jacob To: "dev@dpdk.org" , Fan Zhang CC: "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "Jacob, Jerin" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/scheduler: fix build with gcc 8.2 Thread-Index: AQHUc4W8Puc/UGTug0eVIMKt36W6EA== Date: Sat, 3 Nov 2018 14:58:53 +0000 Message-ID: <20181103145828.24564-1-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-clientproxiedby: BM1PR0101CA0062.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::24) To SN6PR07MB5008.namprd07.prod.outlook.com (2603:10b6:805:ad::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB5423; 6:66wmDEpVAe6WBHh4Ohsk5hdc7XxuzSNjnM2ZYIOkZ4FNcLnBagruTAhyHTHzAnMTx+7n1Ugor2PkWb6v1otEV2s2KIRNSqRUNwlIFwpsxpV1F7bCO6IZXW3MmGWTzK21fzAhoDoLETapLepj9IWOgTPXbQ3JJuGwFD1VtVkugjrAXeUm4GcnEGmFALa9vcPtcL5kcYe7FOy4XvukXUN0dotnmcgoZDiE1v9onIVoebuWuk2j+SuJleXQxGZ9+KWoD+UvvkYzbFx43J9qpTn+cCDqkCdGMP/NJvJNg5/DZ7J+dOz18YPsdZnermz0N8qHCCpKhWwszQHQgShJ/d/qSork+cSv28vxzer+TJPogB1cnWCsV3rVT/UXInNlc00RlvSjGCviiggEJ8ZNlYjinrm/eVGiYWnO0qYljDP8Zqv+Z556jw09cKZkIIRkJfvjuN80jqW0lAmt/uq4OmOubQ==; 5:FgUMAfevv/kGDzeNlfY/+89Bk7DMxcWDfVcG6XiEvrsGcnL+6/rH2WxNPj1gswAWucEZ9G1FOMB+cWp0YWk96jcCsk/t7j58yNIKkQVaPNKCSKSHXFi6yTeT2Svd+pyM+0zSwXD4eP3csTJ2So/IdYpxgAhVKxH3u57y2R+DhQE=; 7:yzTPE0wWmXfp1y1EAOKbMzmBGw43Y5Q13YkaDPsQPJqIQBQdaY7L130cdctu5ioMoCkJPQnoXFFP+yZMpLocxi81K/O11eryFRGtcTxeYVpr/Qix9f7n9HNX2T+swilBVdJmKWuSYaEqy8/IBFVsTw== x-ms-office365-filtering-correlation-id: 29ebdf13-fe54-4f0c-844a-08d6419cded9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5423; x-ms-traffictypediagnostic: SN6PR07MB5423: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(3231382)(944501410)(52105095)(148016)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB5423; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5423; x-forefront-prvs: 08457955C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(39850400004)(366004)(136003)(199004)(189003)(14454004)(3846002)(6116002)(2501003)(8936002)(71190400001)(71200400001)(1076002)(6486002)(81156014)(5660300001)(81166006)(8676002)(97736004)(105586002)(68736007)(478600001)(2906002)(66066001)(316002)(110136005)(54906003)(72206003)(106356001)(305945005)(7736002)(6512007)(1857600001)(486006)(14444005)(476003)(2616005)(2900100001)(256004)(26005)(36756003)(42882007)(186003)(53936002)(4326008)(99286004)(52116002)(25786009)(6436002)(102836004)(55236004)(386003)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5423; H:SN6PR07MB5008.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: SFbFheKZfHKk+rPTdHY9efnBGv6lUX5I4F8Am3IDpmhb5Gen2GQgwyjuYitjeztQ8atWBG3gOUF7R8dFjQVvvZmJbUeSXnb4mdwTh118QjA4sSntFXUJsDGx9zkZCLfyz81dKHtr5fa/afwv31p7ohYwMrXEgWysC3V0MjFmZdkMKRiisvnKxwvAUsKPyUDQxI6om6vN6bFOIYk3oCwZj3nWuLzziMYXZl3D22zex7zRz+XTNRGl0ziQgu9lWOQJwzD50qVOOQicHozqiBDE+Z24jE+Yj7lhaa3YFZGKZ0VG+fw4LRjrzq4WPWbTxkS5+4vjdl40+FCEuBgq4+Wdy7Cj79sweMsEYfJAGS2jltw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <55156FF3A1EF9042905328C82BFED887@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29ebdf13-fe54-4f0c-844a-08d6419cded9 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2018 14:58:54.0132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5423 Subject: [dpdk-dev] [PATCH] crypto/scheduler: fix build with gcc 8.2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" build_error: drivers/crypto/scheduler/scheduler_pmd.c: In function ‘parse_name_arg’: drivers/crypto/scheduler/scheduler_pmd.c:372:2: error: ‘strncpy’ specified bound 64 equals destination size [-Werror=stringop-truncation] strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ strncpy may result a not null-terminated string, replaced it with strlcpy Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") Cc: stable@dpdk.org Signed-off-by: Jerin Jacob --- drivers/crypto/scheduler/scheduler_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index 20198ccb0..a1632a2b9 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -369,7 +369,7 @@ parse_name_arg(const char *key __rte_unused, return -EINVAL; } - strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); + strlcpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); return 0; }