[v2,3/3] net/ixgbe: update API version

Message ID 1547614920-59680-4-git-send-email-wei.zhao1@intel.com
State Superseded
Delegated to: Qi Zhang
Headers show
Series
  • net/ixgbe: promiscuous mode enable on VF
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Wei Zhao Jan. 16, 2019, 5:02 a.m.
There is need to update to latest API version in order for
negotiation between pf and vf, then new API message can be
supported.

Fixes: 88fccb7a05c6 ("ixgbevf: fix jumbo frame")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 drivers/net/ixgbe/ixgbe_pf.c     | 1 +
 2 files changed, 2 insertions(+)

Comments

Zhang, Qi Z Feb. 13, 2019, 3:43 a.m. | #1
I think this patch should be merged with PATCH 2/3, since "ixgbe_mbox_api_13" is already be referenced on that patch.

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, January 16, 2019 1:02 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2 3/3] net/ixgbe: update API version
> 
> There is need to update to latest API version in order for negotiation between pf
> and vf, then new API message can be supported.
> 
> Fixes: 88fccb7a05c6 ("ixgbevf: fix jumbo frame")
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
>  drivers/net/ixgbe/ixgbe_pf.c     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index e8a2c6e..a25178a 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1512,6 +1512,7 @@ ixgbevf_negotiate_api(struct ixgbe_hw *hw)
> 
>  	/* start with highest supported, proceed down */
>  	static const enum ixgbe_pfvf_api_rev sup_ver[] = {
> +		ixgbe_mbox_api_13,
>  		ixgbe_mbox_api_12,
>  		ixgbe_mbox_api_11,
>  		ixgbe_mbox_api_10,
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index
> c9d1a1c..a6d8501 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -569,6 +569,7 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev,
> uint32_t vf, uint32_t *msgbuf)
>  	case ixgbe_mbox_api_10:
>  	case ixgbe_mbox_api_11:
>  	case ixgbe_mbox_api_12:
> +	case ixgbe_mbox_api_13:
>  		vfinfo[vf].api_version = (uint8_t)api_version;
>  		return 0;
>  	default:
> --
> 2.7.5
Wei Zhao Feb. 14, 2019, 1:22 a.m. | #2
Hi, qi 
   New v3 has been commit as your request, thanks.

> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, February 13, 2019 11:44 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: RE: [PATCH v2 3/3] net/ixgbe: update API version
> 
> I think this patch should be merged with PATCH 2/3, since
> "ixgbe_mbox_api_13" is already be referenced on that patch.
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, January 16, 2019 1:02 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v2 3/3] net/ixgbe: update API version
> >
> > There is need to update to latest API version in order for negotiation
> > between pf and vf, then new API message can be supported.
> >
> > Fixes: 88fccb7a05c6 ("ixgbevf: fix jumbo frame")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> >  drivers/net/ixgbe/ixgbe_pf.c     | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index e8a2c6e..a25178a 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -1512,6 +1512,7 @@ ixgbevf_negotiate_api(struct ixgbe_hw *hw)
> >
> >  	/* start with highest supported, proceed down */
> >  	static const enum ixgbe_pfvf_api_rev sup_ver[] = {
> > +		ixgbe_mbox_api_13,
> >  		ixgbe_mbox_api_12,
> >  		ixgbe_mbox_api_11,
> >  		ixgbe_mbox_api_10,
> > diff --git a/drivers/net/ixgbe/ixgbe_pf.c
> > b/drivers/net/ixgbe/ixgbe_pf.c index
> > c9d1a1c..a6d8501 100644
> > --- a/drivers/net/ixgbe/ixgbe_pf.c
> > +++ b/drivers/net/ixgbe/ixgbe_pf.c
> > @@ -569,6 +569,7 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev,
> > uint32_t vf, uint32_t *msgbuf)
> >  	case ixgbe_mbox_api_10:
> >  	case ixgbe_mbox_api_11:
> >  	case ixgbe_mbox_api_12:
> > +	case ixgbe_mbox_api_13:
> >  		vfinfo[vf].api_version = (uint8_t)api_version;
> >  		return 0;
> >  	default:
> > --
> > 2.7.5

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index e8a2c6e..a25178a 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1512,6 +1512,7 @@  ixgbevf_negotiate_api(struct ixgbe_hw *hw)
 
 	/* start with highest supported, proceed down */
 	static const enum ixgbe_pfvf_api_rev sup_ver[] = {
+		ixgbe_mbox_api_13,
 		ixgbe_mbox_api_12,
 		ixgbe_mbox_api_11,
 		ixgbe_mbox_api_10,
diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index c9d1a1c..a6d8501 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -569,6 +569,7 @@  ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
 	case ixgbe_mbox_api_10:
 	case ixgbe_mbox_api_11:
 	case ixgbe_mbox_api_12:
+	case ixgbe_mbox_api_13:
 		vfinfo[vf].api_version = (uint8_t)api_version;
 		return 0;
 	default: