[v2] compressdev: add feature flag to specify where processing is done

Message ID 1547746583-13832-1-git-send-email-fiona.trahe@intel.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • [v2] compressdev: add feature flag to specify where processing is done
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Trahe, Fiona Jan. 17, 2019, 5:36 p.m.
A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
is added. A PMD should set this if the bulk of the
processing is done during the dequeue. It should leave it
cleared if the bulk of the processing is done during the
enqueue (default).
Applications can use this as a hint for tuning.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 lib/librte_compressdev/rte_compressdev.c | 2 ++
 lib/librte_compressdev/rte_compressdev.h | 6 ++++++
 2 files changed, 8 insertions(+)

Comments

Shally Verma Feb. 20, 2019, 4 p.m. | #1
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Fiona Trahe
>Sent: 17 January 2019 23:06
>To: dev@dpdk.org
>Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com; akhil.goyal@nxp.com; paul.e.luse@intel.com
>Subject: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done
>
>External Email
>
>A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
>is added. A PMD should set this if the bulk of the
>processing is done during the dequeue. It should leave it
>cleared if the bulk of the processing is done during the
>enqueue (default).
>Applications can use this as a hint for tuning.
>
>Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Shally Verma <shally.verma@marvell.com>

Thanks
Shally
Akhil Goyal March 22, 2019, 3:09 p.m. | #2
On 2/20/2019 9:30 PM, Shally Verma wrote:
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Fiona Trahe
>> Sent: 17 January 2019 23:06
>> To: dev@dpdk.org
>> Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com; akhil.goyal@nxp.com; paul.e.luse@intel.com
>> Subject: [dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done
>>
>> External Email
>>
>> A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE
>> is added. A PMD should set this if the bulk of the
>> processing is done during the dequeue. It should leave it
>> cleared if the bulk of the processing is done during the
>> enqueue (default).
>> Applications can use this as a hint for tuning.
>>
>> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: Shally Verma <shally.verma@marvell.com>
>
> Thanks
> Shally
Applied to dpdk-next-crypto

Thanks.

Patch

diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib/librte_compressdev/rte_compressdev.c
index 10101ebbe..338134bdf 100644
--- a/lib/librte_compressdev/rte_compressdev.c
+++ b/lib/librte_compressdev/rte_compressdev.c
@@ -66,6 +66,8 @@  rte_compressdev_get_feature_name(uint64_t flag)
 		return "CPU_AVX512";
 	case RTE_COMPDEV_FF_CPU_NEON:
 		return "CPU_NEON";
+	case RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE:
+		return "OP_DONE_IN_DEQ";
 	default:
 		return NULL;
 	}
diff --git a/lib/librte_compressdev/rte_compressdev.h b/lib/librte_compressdev/rte_compressdev.h
index 7b68170a5..d3c0000f0 100644
--- a/lib/librte_compressdev/rte_compressdev.h
+++ b/lib/librte_compressdev/rte_compressdev.h
@@ -73,6 +73,12 @@  rte_compressdev_capability_get(uint8_t dev_id,
 /**< Utilises CPU SIMD AVX512 instructions */
 #define	RTE_COMPDEV_FF_CPU_NEON			(1ULL << 5)
 /**< Utilises CPU NEON instructions */
+#define RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE	(1ULL << 6)
+/**< A PMD should set this if the bulk of the
+ * processing is done during the dequeue. It should leave it
+ * cleared if the processing is done during the enqueue (default).
+ * Applications can use this as a hint for tuning.
+ */
 
 /**
  * Get the name of a compress device feature flag.