[v6,5/5] build: use integers for numerical options

Message ID 20190206170848.19059-5-bluca@debian.org
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [v6,1/5] build: bump minimum Meson version to 0.47.1
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Luca Boccassi Feb. 6, 2019, 5:08 p.m.
Now that the minimum Meson version has been bumped past 0.45 we can use
integer as an option type directly.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v6: added following Bruce's suggestion

 meson_options.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bruce Richardson Feb. 8, 2019, 2:44 p.m. | #1
On Wed, Feb 06, 2019 at 05:08:48PM +0000, Luca Boccassi wrote:
> Now that the minimum Meson version has been bumped past 0.45 we can use
> integer as an option type directly.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> v6: added following Bruce's suggestion
> 
Since I suggested it, I naturally think this is a brilliant idea! :-)

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Patch

diff --git a/meson_options.txt b/meson_options.txt
index 574054597..4e178178f 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -18,9 +18,9 @@  option('lib_musdk_dir', type: 'string', value: '',
 	description: 'path to the MUSDK library installation directory')
 option('machine', type: 'string', value: 'native',
 	description: 'set the target machine type')
-option('max_lcores', type: 'string', value: '128',
+option('max_lcores', type: 'integer', value: 128,
 	description: 'maximum number of cores/threads supported by EAL')
-option('max_numa_nodes', type: 'string', value: '4',
+option('max_numa_nodes', type: 'integer', value: 4,
 	description: 'maximum number of NUMA nodes supported by EAL')
 option('per_library_versions', type: 'boolean', value: true,
 	description: 'true: each lib gets its own version number, false: DPDK version used for each lib')