[v2,3/3] test: add result field to mod exp and mod inv

Message ID 20190208111338.4544-4-arkadiuszx.kusztal@intel.com
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series
  • crypotodev: add result field to modular operations
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Kusztal, ArkadiuszX Feb. 8, 2019, 11:13 a.m.
This patch adds result field to modular exponentiation and
modular multiplicative inverse tests

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 test/test/test_cryptodev_asym.c      | 6 ++++++
 test/test/test_cryptodev_asym_util.h | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

Comments

Shally Verma Feb. 12, 2019, 11 a.m. | #1
>-----Original Message-----
>From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Sent: 08 February 2019 16:44
>To: dev@dpdk.org
>Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; shally.verma@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Subject: [PATCH v2 3/3] test: add result field to mod exp and mod inv
>
>External Email
>
>This patch adds result field to modular exponentiation and
>modular multiplicative inverse tests
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>---
Acked-by: Shally Verma <shallyv@marvell.com>

Thanks
Shally

Patch

diff --git a/test/test/test_cryptodev_asym.c b/test/test/test_cryptodev_asym.c
index 0f6fc57..a779e8f 100644
--- a/test/test/test_cryptodev_asym.c
+++ b/test/test/test_cryptodev_asym.c
@@ -940,6 +940,7 @@  test_mod_inv(void)
 	const struct rte_cryptodev_asymmetric_xform_capability *capability;
 	uint8_t input[TEST_DATA_SIZE] = {0};
 	int ret = 0;
+	uint8_t result[sizeof(mod_p)] = { 0 };
 
 	if (rte_cryptodev_asym_get_xform_enum(
 		&modinv_xform.xform_type, "modinv") < 0) {
@@ -993,6 +994,8 @@  test_mod_inv(void)
 	memcpy(input, base, sizeof(base));
 	asym_op->modinv.base.data = input;
 	asym_op->modinv.base.length = sizeof(base);
+	asym_op->modinv.result.data = result;
+	asym_op->modinv.result.length = sizeof(result);
 
 	/* attach asymmetric crypto session to crypto operations */
 	rte_crypto_op_attach_asym_session(op, sess);
@@ -1055,6 +1058,7 @@  test_mod_exp(void)
 	const struct rte_cryptodev_asymmetric_xform_capability *capability;
 	uint8_t input[TEST_DATA_SIZE] = {0};
 	int ret = 0;
+	uint8_t result[sizeof(mod_p)] = { 0 };
 
 	if (rte_cryptodev_asym_get_xform_enum(&modex_xform.xform_type,
 		"modexp")
@@ -1109,6 +1113,8 @@  test_mod_exp(void)
 	memcpy(input, base, sizeof(base));
 	asym_op->modex.base.data = input;
 	asym_op->modex.base.length = sizeof(base);
+	asym_op->modex.result.data = result;
+	asym_op->modex.result.length = sizeof(result);
 	/* attach asymmetric crypto session to crypto operations */
 	rte_crypto_op_attach_asym_session(op, sess);
 
diff --git a/test/test/test_cryptodev_asym_util.h b/test/test/test_cryptodev_asym_util.h
index dff0c2a..b3d9fb4 100644
--- a/test/test/test_cryptodev_asym_util.h
+++ b/test/test/test_cryptodev_asym_util.h
@@ -20,8 +20,8 @@  static inline int rsa_verify(struct rsa_test_data *rsa_param,
 static inline int verify_modinv(uint8_t *mod_inv,
 		struct rte_crypto_op *result_op)
 {
-	if (memcmp(mod_inv, result_op->asym->modinv.base.data,
-				result_op->asym->modinv.base.length))
+	if (memcmp(mod_inv, result_op->asym->modinv.result.data,
+				result_op->asym->modinv.result.length))
 		return -1;
 	return 0;
 }
@@ -29,8 +29,8 @@  static inline int verify_modinv(uint8_t *mod_inv,
 static inline int verify_modexp(uint8_t *mod_exp,
 		struct rte_crypto_op *result_op)
 {
-	if (memcmp(mod_exp, result_op->asym->modex.base.data,
-				result_op->asym->modex.base.length))
+	if (memcmp(mod_exp, result_op->asym->modex.result.data,
+				result_op->asym->modex.result.length))
 		return -1;
 	return 0;
 }