diff mbox series

[v6] doc/patches: add meson build to contributing guide

Message ID 20190213054106.45163-1-vipin.varghese@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v6] doc/patches: add meson build to contributing guide |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Varghese, Vipin Feb. 13, 2019, 5:41 a.m. UTC 
  Patches has to be validated for meson devtool script for
code and document changes. Updating documentation for meson
build steps in checking Compilation category.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
Tested-by: Marko Kovacevic <marko.kovacevic@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
---

V6:
 added 'Makefile' sub-header - Thomas Monjalon
 reword the content - Thomas Monjalon

V5:
 create sub section to Compilation - Thomas Monjalon
 remove Linux and BSD references - Thomas Monjalon
 reword tool chain to toolchain - Thomas Monjalon

V4:
 spelling correction for Compilation - Thomas Monjalon
 restored double space for new header - Thomas Monjalon
 reword the meson compilation content - Vipin Varghese
 added 'tested' and 'acked' from - Marko Kovacevic

V3:
 removed extra character - Vipin Varghese

V2:
 updated the meson build options - Bruce Richardson
---
 doc/guides/contributing/patches.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Thomas Monjalon Feb. 27, 2019, 11:41 a.m. UTC | #1 
13/02/2019 06:41, Vipin Varghese:
> Patches has to be validated for meson devtool script for
> code and document changes. Updating documentation for meson
> build steps in checking Compilation category.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Tested-by: Marko Kovacevic <marko.kovacevic@intel.com>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied, thanks
Varghese, Vipin Feb. 27, 2019, 12:13 p.m. UTC | #2 
Thanks

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, February 27, 2019 5:11 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic,
> Marko <marko.kovacevic@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Padubidri, Sanjay A
> <sanjay.padubidri@intel.com>; Patel, Amol <amol.patel@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v6] doc/patches: add meson build to
> contributing guide
> 
> 13/02/2019 06:41, Vipin Varghese:
> > Patches has to be validated for meson devtool script for code and
> > document changes. Updating documentation for meson build steps in
> > checking Compilation category.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > Tested-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
> 
> Applied, thanks
> 
>
diff mbox series

Patch

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index a64bb0368..211a5cdc7 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -431,6 +431,9 @@  Where the range is a ``git log`` option.
 Checking Compilation
 --------------------
 
+Makefile System
+~~~~~~~~~~~~~~~
+
 Compilation of patches and changes should be tested using the ``test-build.sh`` script in the ``devtools``
 directory of the DPDK repo::
 
@@ -473,6 +476,14 @@  The recommended configurations and options to test compilation prior to submitti
    export DPDK_DEP_PCAP=y
    export DPDK_DEP_SSL=y
 
+Meson System
+~~~~~~~~~~~~
+
+Compilation of patches is to be tested with ``devtools/test-meson-builds.sh`` script.
+
+The script internally checks for dependencies, then builds for several
+combinations of compilation configuration.
+
 
 Sending Patches
 ---------------