diff mbox series

[1/2] bus/vdev: fix debug message on probing

Message ID 20190221190125.24140-2-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series small fixes for vdev hotplug |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon Feb. 21, 2019, 7:01 p.m. UTC 
  The log was printing the device name two times,
first one being supposed to be the driver name.
As we don't know yet the driver name, the log is simplified.

Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option")
Cc: ferruh.yigit@intel.com

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/bus/vdev/vdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Rami Rosen Feb. 22, 2019, 5:06 a.m. UTC | #1 
Reviewed-by: Rami Rosen <ramirose@gmail.com>

בתאריך יום ה׳, 21 בפבר׳ 2019, 21:01, מאת Thomas Monjalon ‏<
thomas@monjalon.net>:

> The log was printing the device name two times,
> first one being supposed to be the driver name.
> As we don't know yet the driver name, the log is simplified.
>
> Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option")
> Cc: ferruh.yigit@intel.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/bus/vdev/vdev.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 2c03ca4185..7225411791 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -144,9 +144,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)
>         int ret;
>
>         name = rte_vdev_device_name(dev);
> -
> -       VDEV_LOG(DEBUG, "Search driver %s to probe device %s", name,
> -               rte_vdev_device_name(dev));
> +       VDEV_LOG(DEBUG, "Search driver to probe device %s", name);
>
>         if (vdev_parse(name, &driver))
>                 return -1;
> --
> 2.20.1
>
>
Andrew Rybchenko Feb. 25, 2019, 7:45 a.m. UTC | #2 
On 2/21/19 10:01 PM, Thomas Monjalon wrote:
> The log was printing the device name two times,
> first one being supposed to be the driver name.
> As we don't know yet the driver name, the log is simplified.
>
> Fixes: 9bf4901d1a11 ("bus/vdev: remove probe with driver name option")
> Cc: ferruh.yigit@intel.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
diff mbox series

Patch

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 2c03ca4185..7225411791 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -144,9 +144,7 @@  vdev_probe_all_drivers(struct rte_vdev_device *dev)
 	int ret;
 
 	name = rte_vdev_device_name(dev);
-
-	VDEV_LOG(DEBUG, "Search driver %s to probe device %s", name,
-		rte_vdev_device_name(dev));
+	VDEV_LOG(DEBUG, "Search driver to probe device %s", name);
 
 	if (vdev_parse(name, &driver))
 		return -1;