bus/dpaa: fix Rx discard mask register

Message ID 20190222100825.7478-1-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series bus/dpaa: fix Rx discard mask register |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal Feb. 22, 2019, 10:09 a.m. UTC
  From: Shreyansh Jain <shreyansh.jain@nxp.com>

Current value of 'fmbm_rfsdm' register (0x010CE3F0) doesn't include
the bit to drop colored (red) packets. New value (0x010EE3F0) fixes
this.
Check with 'fmbm_rffc' register of fm_port_bmi_regs.

Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
DPDK-1574
---
 drivers/bus/dpaa/base/fman/fman_hw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Thomas Monjalon March 29, 2019, 1:10 p.m. UTC | #1
22/02/2019 11:09, Hemant Agrawal:
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> Current value of 'fmbm_rfsdm' register (0x010CE3F0) doesn't include
> the bit to drop colored (red) packets. New value (0x010EE3F0) fixes
> this.
> Check with 'fmbm_rffc' register of fm_port_bmi_regs.
> 
> Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Cc: stable@dpdk.org

Applied, thanks
  

Patch

diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c
index 4ebbc3d34..9ab8e835d 100644
--- a/drivers/bus/dpaa/base/fman/fman_hw.c
+++ b/drivers/bus/dpaa/base/fman/fman_hw.c
@@ -603,9 +603,9 @@  fman_if_discard_rx_errors(struct fman_if *fm_if)
 	out_be32(fmbm_rfsem, 0);
 
 	/* Configure the discard mask to discard the error packets which have
-	 * DMA errors, Frame size error, Header error etc. The mask 0x010CE3F0
+	 * DMA errors, Frame size error, Header error etc. The mask 0x010EE3F0
 	 * is to configured discard all the errors which come in the FD[STATUS]
 	 */
 	fmbm_rfsdm = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rfsdm;
-	out_be32(fmbm_rfsdm, 0x010CE3F0);
+	out_be32(fmbm_rfsdm, 0x010EE3F0);
 }