[07/12] net/mlx5: fix incorrect rxq errors stat

Message ID 1551698315-2611-8-git-send-email-david.marchand@redhat.com
State New
Delegated to: Ferruh Yigit
Headers show
Series
  • rxq q_errors[] statistics fixes
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand March 4, 2019, 11:18 a.m.
Transmit errors must not be reported in q_errors[] which is for
reception.

Fixes: 87011737b715 ("mlx5: add software counters")
Fixes: 9f9a48eb2978 ("net/mlx5: fix Tx stats error counter definition")
Cc: stable@dpdk.org
Cc: Shahaf Shuler <shahafs@mellanox.com>
Cc: Yongseok Koh <yskoh@mellanox.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/mlx5/mlx5_stats.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Shahaf Shuler March 5, 2019, 8:18 a.m. | #1
Monday, March 4, 2019 1:19 PM, David Marchand:
> Subject: [PATCH 07/12] net/mlx5: fix incorrect rxq errors stat
> 
> Transmit errors must not be reported in q_errors[] which is for reception.
> 
> Fixes: 87011737b715 ("mlx5: add software counters")
> Fixes: 9f9a48eb2978 ("net/mlx5: fix Tx stats error counter definition")
> Cc: stable@dpdk.org
> Cc: Shahaf Shuler <shahafs@mellanox.com>
> Cc: Yongseok Koh <yskoh@mellanox.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/mlx5/mlx5_stats.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
> index 6906dc8..ef7bc14 100644
> --- a/drivers/net/mlx5/mlx5_stats.c
> +++ b/drivers/net/mlx5/mlx5_stats.c
> @@ -409,7 +409,6 @@
>  			tmp.q_opackets[idx] += txq->stats.opackets;
>  			tmp.q_obytes[idx] += txq->stats.obytes;  #endif
> -			tmp.q_errors[idx] += txq->stats.oerrors;
>  		}
>  #ifdef MLX5_PMD_SOFT_COUNTERS
>  		tmp.opackets += txq->stats.opackets;
> --
> 1.8.3.1

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Patch

diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
index 6906dc8..ef7bc14 100644
--- a/drivers/net/mlx5/mlx5_stats.c
+++ b/drivers/net/mlx5/mlx5_stats.c
@@ -409,7 +409,6 @@ 
 			tmp.q_opackets[idx] += txq->stats.opackets;
 			tmp.q_obytes[idx] += txq->stats.obytes;
 #endif
-			tmp.q_errors[idx] += txq->stats.oerrors;
 		}
 #ifdef MLX5_PMD_SOFT_COUNTERS
 		tmp.opackets += txq->stats.opackets;