[v3,38/38] net/ice/base: fix set UDP PTYPEs

Message ID 20190311070441.5501-39-qi.z.zhang@intel.com
State Changes Requested, archived
Delegated to: Qi Zhang
Headers show
Series
  • ice share code update.
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Zhang, Qi Z March 11, 2019, 7:04 a.m.
Set the UDP PTYPEs to inner-last for non-tunneled packats according
to data sheet.

This also fix the issue that IPv4 TCP RSS does not work if
RSS for IPv6 UDP is also configured.

Fixes: aa1cd410fa64 ("net/ice/base: add flow module")

Vignesh Sridhar <vignesh.sridhar@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Zhang, Qi Z March 11, 2019, 7:27 a.m. | #1
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, March 11, 2019 3:05 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v3 38/38] net/ice/base: fix set UDP PTYPEs
> 
> Set the UDP PTYPEs to inner-last for non-tunneled packats according to data
> sheet.
> 
> This also fix the issue that IPv4 TCP RSS does not work if RSS for IPv6 UDP is also
> configured.
> 
> Fixes: aa1cd410fa64 ("net/ice/base: add flow module")
> 
> Vignesh Sridhar <vignesh.sridhar@intel.com>

Missing "Signed-off-by", will add when applied the patch.

> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/ice/base/ice_flow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
> index be819e0e9..e3c34ba89 100644
> --- a/drivers/net/ice/base/ice_flow.c
> +++ b/drivers/net/ice/base/ice_flow.c
> @@ -467,8 +467,8 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params
> *params)
>  				       ICE_FLOW_PTYPE_MAX);
>  			hdrs &= ~ICE_FLOW_SEG_HDR_ICMP;
>  		} else if (hdrs & ICE_FLOW_SEG_HDR_UDP) {
> -			src = !i ? (const ice_bitmap_t *)ice_ptypes_udp_of :
> -				(const ice_bitmap_t *)ice_ptypes_udp_il;
> +			src = !i ? (const ice_bitmap_t *)ice_ptypes_udp_il :
> +				(const ice_bitmap_t *)ice_ptypes_udp_of;
>  			ice_and_bitmap(params->ptypes, params->ptypes, src,
>  				       ICE_FLOW_PTYPE_MAX);
>  			hdrs &= ~ICE_FLOW_SEG_HDR_UDP;
> --
> 2.13.6

Patch

diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index be819e0e9..e3c34ba89 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -467,8 +467,8 @@  ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
 				       ICE_FLOW_PTYPE_MAX);
 			hdrs &= ~ICE_FLOW_SEG_HDR_ICMP;
 		} else if (hdrs & ICE_FLOW_SEG_HDR_UDP) {
-			src = !i ? (const ice_bitmap_t *)ice_ptypes_udp_of :
-				(const ice_bitmap_t *)ice_ptypes_udp_il;
+			src = !i ? (const ice_bitmap_t *)ice_ptypes_udp_il :
+				(const ice_bitmap_t *)ice_ptypes_udp_of;
 			ice_and_bitmap(params->ptypes, params->ptypes, src,
 				       ICE_FLOW_PTYPE_MAX);
 			hdrs &= ~ICE_FLOW_SEG_HDR_UDP;