From patchwork Tue Mar 12 15:25:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 51130 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7412C5B16; Tue, 12 Mar 2019 16:25:11 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770082.outbound.protection.outlook.com [40.107.77.82]) by dpdk.org (Postfix) with ESMTP id 1AE5756A3 for ; Tue, 12 Mar 2019 16:25:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ipuTH0c4InD4UNeJ540Sdqni4fRPmh8Pjb4kzF/gsGY=; b=Kok20R4CmEVdzsoELjNdua0zRhF+kgvxmrMsVvN26+WBllYTiMSdrRAXgTFIYcRXdruJwmg2V0JfdFjaK7KbANSbkiiD2HJq4fwEL7hE0fAVuHVKXiRPlv6+DR3FZUXMkDF6LFWFAMtv2tbCpFgGOpyw92Y1eNU54d9Haax0Oc0= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3068.namprd11.prod.outlook.com (20.177.218.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.19; Tue, 12 Mar 2019 15:25:05 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1686.021; Tue, 12 Mar 2019 15:25:05 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH v3 08/10] net/atlantic: eliminate excessive log levels on Rx/Tx Thread-Index: AQHU2OfFtHZo2ocufUC8Ux6X24aGlg== Date: Tue, 12 Mar 2019 15:25:05 +0000 Message-ID: <87513983880d4f283bc0b3dbda4f2d15709828e8.1552402263.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR0901CA0050.eurprd09.prod.outlook.com (2603:10a6:3:45::18) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f48c7b45-31f8-4a92-9512-08d6a6fee75f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3068; x-ms-traffictypediagnostic: DM6PR11MB3068: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3068; 23:0j7UJnmb5zsSwJOh/PKAERHUXe0pKSqi0Qv3uAE?= =?iso-8859-1?q?phl9h8Ra/k/DxeP3wCW+1feWl?= =?iso-8859-1?q?kVfTvKCKdFnyBbkFcpHwLLjMrJvCEREWuRHYw3G2ZcTpHPwu8K9?= =?iso-8859-1?q?oanyCDPACRCvzEuR/nIEbSuYo1bUQCE7hEC//8e8+ne1+lMu2KN?= =?iso-8859-1?q?ODUAdPfOuIKXzpvR9VeA7zxaFv9c/fixFG5ut/q/1ijp/pYdy+0?= =?iso-8859-1?q?g2E+odgWqnl8vnjFzxaLKxIVXTxM3fBdI021X+88RX137gqV3XS?= =?iso-8859-1?q?Stqv7sSjv3kPT/Xiiz3YG5KN0wW5RYHTW89nYUam6b+HncPFoXd?= =?iso-8859-1?q?Yzq5eCAI89IrBJpHa8c7Bgy0Nw46SGGaPCYAcIsWOmAT/E13Oa7?= =?iso-8859-1?q?lkOcnjdglcmVmd+espaH9Tj25J3szOlJSKmCZ1WCFwN8ZEzA3gA?= =?iso-8859-1?q?E89WowxLEDtMSWr8iE1Nd/5QYjMm7puyrQx7lAdHf2JI/iz17zO?= =?iso-8859-1?q?EEOPPkaoBdgNBIkPvm3/9BZk+Rbvavpe3TZN7MRhRsSa9CG/d1v?= =?iso-8859-1?q?Fz+83/Qh3S5JvH2ldBZY4OlOQ2c4Vcsi+lRO1FoacZBgrrUIfpw?= =?iso-8859-1?q?l52hKMqjAhNQeRj9DeZSzh3kS0i2teeero4IYkwM5k20D2TmPnQ?= =?iso-8859-1?q?QtggUVecAQETrrMhXwDXLt/H0yo+09sIADPk2SkQGiwyNPsl8xo?= =?iso-8859-1?q?DxM9FSPKs7ChNZZRR8D2Z2IVU6ASlLpshIYEx/tKrC4XUFmz4Kf?= =?iso-8859-1?q?t4hhp1o2B9qz+K/9P1dgjZYCx2Kf4/3w9mLzx9qFw/TDHHF0Z+V?= =?iso-8859-1?q?oAulyZBrk+eSbsqrYg51kyXET/8eCuarb8/ckSXLEOOcp4K776b?= =?iso-8859-1?q?PQQpnqSXfOmODxNsjW6fdxL3q9ueGJ2YWSPYpD83Vk8WLBxK1U6?= =?iso-8859-1?q?xmREzxXf7ySHBDsaKJXTAWu4iN7jo1nEyqAWJfcpiGJMPtGWOip?= =?iso-8859-1?q?cbJbsADHfPcTGwFt880M/oRwI3cGW+Jee2ap6+zlL9954V1cZAD?= =?iso-8859-1?q?uYt/7iDxr6PYFLP1MV0LHV+Fj6ShK8+4h0bhRYJwMNLC4PcklVh?= =?iso-8859-1?q?9LlhV/rg4t45BI4ke1EZVv19IckHnt1FK5KYubEiKqXPuHuYfzz?= =?iso-8859-1?q?rFLMjhxnB/SmFoB3hnnwoljV60QrXh8KtIknTYaPka1tK1HMBxq?= =?iso-8859-1?q?g6Oz3VBfQ7uJTJtDubN0bJ3u2VwzqEdp1nHA9VL6a5+6TDyCJrr?= =?iso-8859-1?q?8WY2I+mjfvpYbOI5/g9JPLnnOOV53V8OCykghxKe+V+SWEBTWSj?= =?iso-8859-1?q?azMbRpACx2zzSdS9u8PaVrT3Ut3B9tEjZWGKba/5Mgy6U/CteBc?= =?iso-8859-1?q?XCdClI/OxdYqanbj+46JuuYV19u2OamY9sINiswIdGmU35FRgM4?= =?iso-8859-1?q?7XThpnkFTxZWcmBflI4EvAvlJMg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(72206003)(97736004)(4326008)(14454004)(81166006)(2906002)(5660300002)(6916009)(8676002)(71200400001)(478600001)(25786009)(118296001)(71190400001)(86362001)(256004)(1730700003)(3846002)(81156014)(36756003)(68736007)(6116002)(305945005)(54906003)(316002)(446003)(8936002)(44832011)(53936002)(5640700003)(26005)(11346002)(476003)(76176011)(66066001)(106356001)(99286004)(2616005)(105586002)(186003)(386003)(52116002)(7736002)(107886003)(6436002)(6486002)(2351001)(6506007)(2501003)(6512007)(102836004)(50226002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3068; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HBWjx3MFHwokOvtPtJ6kWgVtRlykUb3uRvz2++o46rjcIo68JSWU7woREq221A47XE+8iWNAnB0KFrjyU53wgV7NIMXXgaSQ9eJW+/bOkqEriq7ZBZZC5/dGZMwkDw0v5GOASV0R7TFOX/Lzmn0lgIFNJ57d9gKDNnZH6qybtE4P1nwqSo4aWI/eEtxZcTrq0DWDIOTvvhZizjoDoZefmJ7HnIQgrjAQ13Zb2NiA7CxhbRABD6OlmvSLIwXH5vVPbpll1sel67kUgt3UnyfAH04Rm+2UP7Bi0nmXxiISSFwB72KYaa5HCZ+bAq4WH9aKRbKYmaZH7K9Vg+Z/5Q3nIMlXgHVHftoqxqdV0WTr5rDZl3a/1pkxvTC0C+agm59y7N81ZOQyVP8uzU6Fl9Rieg/daWUSUaCAfrONbMOnuW4= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f48c7b45-31f8-4a92-9512-08d6a6fee75f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 15:25:05.7421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3068 Subject: [dpdk-dev] [PATCH v3 08/10] net/atlantic: eliminate excessive log levels on Rx/Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Default rxtx logging used ERR level, that caused logger to always trigger. That may cause perf degradation even if logger was not enabled but compiled in. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index aea58c0d5b83..f1519594adad 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -946,7 +946,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) break; } - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u tail=%u " "eop=0x%x pkt_len=%u hash=0x%x hash_type=0x%x", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, @@ -981,7 +981,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) while (true) { new_mbuf = rte_mbuf_raw_alloc(rxq->mb_pool); if (new_mbuf == NULL) { - PMD_RX_LOG(ERR, + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed port_id=%u " "queue_id=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id); @@ -1084,7 +1084,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) adapter->sw_stats.q_ibytes[rxq->queue_id] += rx_mbuf_first->pkt_len; - PMD_RX_LOG(ERR, "add mbuf segs=%d pkt_len=%d", + PMD_RX_LOG(DEBUG, "add mbuf segs=%d pkt_len=%d", rx_mbuf_first->nb_segs, rx_mbuf_first->pkt_len); } @@ -1104,7 +1104,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) */ nb_hold = (uint16_t)(nb_hold + rxq->nb_rx_hold); if (nb_hold > rxq->rx_free_thresh) { - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u rx_tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u " "nb_hold=%u nb_rx=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, (unsigned int)tail, (unsigned int)nb_hold, @@ -1129,8 +1129,6 @@ atl_xmit_cleanup(struct atl_tx_queue *txq) struct hw_atl_txd_s *txd; int to_clean = 0; - PMD_INIT_FUNC_TRACE(); - if (txq != NULL) { sw_ring = txq->sw_ring; int head = txq->tx_head; @@ -1181,11 +1179,7 @@ atl_tso_setup(struct rte_mbuf *tx_pkt, union hw_atl_txc_s *txc) uint32_t tx_cmd = 0; uint64_t ol_flags = tx_pkt->ol_flags; - PMD_INIT_FUNC_TRACE(); - if (ol_flags & PKT_TX_TCP_SEG) { - PMD_DRV_LOG(DEBUG, "xmit TSO pkt"); - tx_cmd |= tx_desc_cmd_lso | tx_desc_cmd_l4cs; txc->cmd = 0x4; @@ -1240,8 +1234,6 @@ atl_xmit_pkt(struct aq_hw_s *hw, struct atl_tx_queue *txq, u32 tx_cmd = 0U; int desc_count = 0; - PMD_INIT_FUNC_TRACE(); - tail = txq->tx_tail; txc = (union hw_atl_txc_s *)&txq->hw_ring[tail];