rte_ring: add newline to error message
Checks
Commit Message
Log message should end with newline.
Fixes: 4e32101f9b01 ("ring: support freeing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_ring/rte_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Fri, Mar 22, 2019 at 1:04 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
22/03/2019 00:03, Stephen Hemminger:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> - RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
> + RTE_LOG(ERR, RING,
> + "Cannot free ring (not created with rte_ring_create()\n");
While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)
* therefore, there is no memzone to free.
*/
if (r->memzone == NULL) {
- RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+ RTE_LOG(ERR, RING,
+ "Cannot free ring (not created with rte_ring_create()\n");
return;
}