| Message ID | 20190406132852.14862-1-jerinj@marvell.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Thomas Monjalon |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44B7537A8; Sat, 6 Apr 2019 15:29:57 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 06BF8239; Sat, 6 Apr 2019 15:29:55 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x36DP1er006674; Sat, 6 Apr 2019 06:29:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Ldt3OdW/G75ZjBkyMuWUrM9F7PuOTGAvYQol0SkSHhY=; b=ldExnUse0FJ0kU3/A//BYWYa6gatBauPCsZshliruT9De+wMF3/da4v8H9ygxCj3fQZM 9ClWtRg/dlkLrTO2F/YaA5aUT0F+CIoV2De9PNMYi3bjpu26/LJV5Wlaftufl2W9DDjI XJuAtC4YG/VQntMlcpR840VDu4noAO+IRgWnHtymu75VF695Jp8EarL7UHQ++9IUWiLL J4a1n4AjCzxGzUzyv5ZH38N8VGWxh82qdYtIqiUkgs+s1B/3XNXbAi5/0ifkwtvJ/oua LrBSNy2vHg+SyvDogGKoy7x2RC76/zhpyRtn2zMRhEtplxBGkBPZUZIUGhT/3oClo6U2 eQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2rpumj8b77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 06 Apr 2019 06:29:52 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 6 Apr 2019 06:29:51 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.51) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 6 Apr 2019 06:29:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ldt3OdW/G75ZjBkyMuWUrM9F7PuOTGAvYQol0SkSHhY=; b=m0c0/8aWHmb7FKHpEaQdMtXwPuiw/TJQFWLBa3E4Ra+Itjrt2Kq2zXALk74YptiSdol2NXYuZSfdmzUMP+qaH9HREezDW0vmtVnF/oNaUoeKS+byGyk5pt3/pIHd5DYtWsM12nWLhf2bow1ALSjSjnmTPSL6NRiE/rxyGoeanOc= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2517.namprd18.prod.outlook.com (20.179.92.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Sat, 6 Apr 2019 13:29:42 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::6dd3:c056:b23b:ab4e%7]) with mapi id 15.20.1771.019; Sat, 6 Apr 2019 13:29:42 +0000 From: Jerin Jacob Kollanukkaran <jerinj@marvell.com> To: Cristian Dumitrescu <cristian.dumitrescu@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "Gavin Hu" <gavin.hu@arm.com>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection Thread-Index: AQHU7HzKAt1g42Pvq0a+snCQCqZhtQ== Date: Sat, 6 Apr 2019 13:29:41 +0000 Message-ID: <20190406132852.14862-1-jerinj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR02CA0040.apcprd02.prod.outlook.com (2603:1096:3:18::28) To BYAPR18MB2424.namprd18.prod.outlook.com (2603:10b6:a03:130::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [223.226.40.87] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35609fda-9a5a-4342-4d56-08d6ba93ecba x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2517; x-ms-traffictypediagnostic: BYAPR18MB2517: x-microsoft-antispam-prvs: <BYAPR18MB251772977625D09EB9FC70D4C8520@BYAPR18MB2517.namprd18.prod.outlook.com> x-forefront-prvs: 0999136621 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(366004)(136003)(39850400004)(376002)(199004)(189003)(3846002)(102836004)(25786009)(55236004)(81166006)(6116002)(99286004)(54906003)(4744005)(6916009)(316002)(71190400001)(86362001)(50226002)(81156014)(8936002)(6506007)(386003)(5660300002)(71200400001)(2906002)(478600001)(14454004)(6512007)(2616005)(105586002)(53936002)(476003)(26005)(7736002)(66066001)(52116002)(4326008)(68736007)(36756003)(1076003)(6436002)(97736004)(14444005)(256004)(106356001)(186003)(486006)(305945005)(8676002)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2517; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GpAaofDns3APIJE6yRhzRw72GsjCNjsRqG7f9+nVOyyPP81hk4Y5HVbJ1fWnUXxfGabCPrI5kBTBGSN3+UpSoC+kN4bVQUHORp4DL2q1n0Nr8IvvA6p53w7IiN6Ur20Nit53Z5gP6UU8s6B7E9U80ye90ThlxJb8ay6lewb3FhgzHd89grdx9wI5pg12/9Z5PwgT1PK/H8FeJYp8n+5FPfmEvsIuNbdWT/6jxfh7Kop856JnR6sOMiiuFRdrDc2I0ojpqtu45kT6v5av7EkNEnrJgSetlQmO2BsvnZFyEAmgMrYmD1obtc/7LWQvT04DSYmSC6c1R9VpyPmEAgWdleJyv0G+q7mynsPfGjH3Zoc34ocCUFt3Xz0PHb3ZiL7oNcWp2wnO3yqoeBidGASme//jAWbUDz6bXRIjqlGg2OA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 35609fda-9a5a-4342-4d56-08d6ba93ecba X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2019 13:29:41.9458 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2517 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-06_12:, , signatures=0 Subject: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
lib/librte_table: fix arm64 hash function selection
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
| ci/intel-Performance-Testing | success | Performance Testing PASS |
| ci/mellanox-Performance-Testing | success | Performance Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
Commit Message
Jerin Jacob Kollanukkaran
April 6, 2019, 1:29 p.m. UTC
From: Jerin Jacob <jerinj@marvell.com> Use CRC32 instruction only when it is available to avoid the build issue like below. {standard input}:16: Error: selected processor does not support `crc32cx w3,w3,x0' Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers") Cc: Gavin Hu <gavin.hu@arm.com> Cc: stable@dpdk.org Signed-off-by: Jerin Jacob <jerinj@marvell.com> --- lib/librte_table/rte_table_hash_func.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Jerin Jacob Kollanukkaran [mailto:jerinj@marvell.com] > Sent: Saturday, April 6, 2019 2:30 PM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Cc: dev@dpdk.org; thomas@monjalon.net; Jerin Jacob Kollanukkaran > <jerinj@marvell.com>; Gavin Hu <gavin.hu@arm.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function > selection > > From: Jerin Jacob <jerinj@marvell.com> > > Use CRC32 instruction only when it is available to avoid > the build issue like below. > > {standard input}:16: Error: > selected processor does not support `crc32cx w3,w3,x0' > > Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers") > Cc: Gavin Hu <gavin.hu@arm.com> > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob <jerinj@marvell.com> > --- > lib/librte_table/rte_table_hash_func.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > From: Jerin Jacob <jerinj@marvell.com> > > > > Use CRC32 instruction only when it is available to avoid > > the build issue like below. > > > > {standard input}:16: Error: > > selected processor does not support `crc32cx w3,w3,x0' > > > > Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers") > > Cc: Gavin Hu <gavin.hu@arm.com> > > Cc: stable@dpdk.org > > > > Signed-off-by: Jerin Jacob <jerinj@marvell.com> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Applied, thanks
diff --git a/lib/librte_table/rte_table_hash_func.h b/lib/librte_table/rte_table_hash_func.h index 02296eabe..11ea5a90e 100644 --- a/lib/librte_table/rte_table_hash_func.h +++ b/lib/librte_table/rte_table_hash_func.h @@ -40,7 +40,7 @@ rte_crc32_u64(uint64_t crc, uint64_t v) return _mm_crc32_u64(crc, v); } -#elif defined(RTE_ARCH_ARM64) +#elif defined(RTE_ARCH_ARM64) && defined(RTE_MACHINE_CPUFLAG_CRC32) #include "rte_table_hash_func_arm64.h" #else