| Message ID | 20190409094543.26751-1-pbhagavatula@marvell.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 490235F20; Tue, 9 Apr 2019 11:45:53 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id B34B65F1D for <dev@dpdk.org>; Tue, 9 Apr 2019 11:45:51 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x399fMwB010111; Tue, 9 Apr 2019 02:45:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Nd1YyN9+mSYSCzPdi8pOXJqEkX3TEQ/vvtCKUidy6p0=; b=jKWrMY9/loe9UqTrCY/VFB3rZschCOjXFZRWZvRTD9wFhOT9JJxvaRRzCkfWxrB0LWIk b6FZJJIRp5duzQ7RRylVr4aNl+QMOtPV2gtpta6ipXgTU6hslnlJ1R3G+a43JFSzfEGd VDa6L8Yg5DxBJxXQKz65olN4BqYRL1Tud26YM5l0lLinuUIvAhIwPDOrXELFo4fDWFqY MZDYC1l7aJBw79yPhZuLnVepzfw8COTSGftbKili+Yu9fODpq4e6nQvfBSBsxtGKQjdh f3GPs82Z8AcwtMqgIRWwnhKXo9EogwWyFbZ0hFuGB9aXTuM+F9KoeTX6fgANjU6mRydW Fw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2rrjf8sbv2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 09 Apr 2019 02:45:49 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 9 Apr 2019 02:45:47 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 9 Apr 2019 02:45:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nd1YyN9+mSYSCzPdi8pOXJqEkX3TEQ/vvtCKUidy6p0=; b=D64Nj60BxmJgR1ItMeVmXFAwaSU0rOW3lFx4bvWqulyqOEBMvQatjh08DJuH9+18lzs/+nqb8aoYjSJmBGVxv/QwR3VWfEZXQTgLXZbJ4Z1Sw8wayDt2ScSFBh3pjEp+Mind9c7ob34Vs21QMrFnxZkvwv2oiyx21F7g5gracyo= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1944.namprd18.prod.outlook.com (10.171.255.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.15; Tue, 9 Apr 2019 09:45:47 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1771.021; Tue, 9 Apr 2019 09:45:47 +0000 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "xueqin.lin@intel.com" <xueqin.lin@intel.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation Thread-Index: AQHU7rkC5StrGO0ZP0662a598/+VmA== Date: Tue, 9 Apr 2019 09:45:47 +0000 Message-ID: <20190409094543.26751-1-pbhagavatula@marvell.com> References: <20190408101236.18076-1-pbhagavatula@marvell.com> In-Reply-To: <20190408101236.18076-1-pbhagavatula@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR01CA0107.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:5d::25) To CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7a::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [115.113.156.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9dcdd39-ec2a-42ca-4eb5-08d6bcd02437 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB1944; x-ms-traffictypediagnostic: CY4PR1801MB1944: x-microsoft-antispam-prvs: <CY4PR1801MB19440D6C88D740B0DC41375BDE2D0@CY4PR1801MB1944.namprd18.prod.outlook.com> x-forefront-prvs: 000227DA0C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39850400004)(346002)(366004)(136003)(396003)(189003)(199004)(26005)(3846002)(476003)(2501003)(107886003)(97736004)(6436002)(316002)(6116002)(11346002)(6486002)(105586002)(2906002)(106356001)(2616005)(486006)(186003)(110136005)(53936002)(25786009)(446003)(68736007)(54906003)(305945005)(7736002)(478600001)(66066001)(102836004)(99286004)(81156014)(81166006)(14444005)(14454004)(5660300002)(36756003)(2201001)(71190400001)(6512007)(4326008)(86362001)(52116002)(6506007)(50226002)(4744005)(8936002)(71200400001)(256004)(1076003)(8676002)(386003)(76176011)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1944; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: CkCSTd4MgeGKyJLmFUsVsfRElU7wMqo6QVNiGmNN1SIfpI4KvrESAgU14xtnTikb21DeT1SRb8T1SEikqtar6YXrO0AhWKGeO8mQmEwJt92zvQjlrA9QXJTj6oIdMf5g7g+vGkDSQj3Wkf8ryWKTUVpQzCqRdtujsoPisDL6RSARCE13T2Fm+AGPuuYxbM1EyVqRocpIZKD/dm9kUWlM4F2RnLcLwlHPT0tCxKCdh8sDB29w2QZXpnG7LI1jzU/l1zjMZhRulWrfwMgnUeQi0D5yt8X/iUs6u9SDON4TBomdamKH0It1MtAK9QylktLslEeK+e+POwg/0i4Y4TDdKWcOwvECMf8/V/WYD67mizbnxbTGAgxfiWDe0OAI2CAIMAVLE5eWpb9PBWfkI+vrIk7je4Th6kdZpoKxbrBBzCU= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e9dcdd39-ec2a-42ca-4eb5-08d6bcd02437 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2019 09:45:47.2832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1944 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-09_03:, , signatures=0 Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
[v2] app/testpmd: fix ether header size calculation
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
| ci/Intel-compilation | success | Compilation OK |
| ci/intel-Performance-Testing | success | Performance Testing PASS |
| ci/mellanox-Performance-Testing | success | Performance Testing PASS |
Commit Message
Pavan Nikhilesh Bhagavatula
April 9, 2019, 9:45 a.m. UTC
From: Pavan Nikhilesh <pbhagavatula@marvell.com> Fix ether header size calculation in Tx only mode. Coverity issue: 337684 Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> --- v2 Changes: - Preserve relation between destination and destination size. (Bruce) app/test-pmd/txonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.21.0
Comments
On 4/9/2019 10:45 AM, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh <pbhagavatula@marvell.com> > > Fix ether header size calculation in Tx only mode. > > Coverity issue: 337684 > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to dpdk-next-net/master, thanks. @lei, can you please confirm the txonly mode on next-net?
> -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, April 10, 2019 4:59 AM > To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob > Kollanukkaran <jerinj@marvell.com>; Lin, Xueqin <xueqin.lin@intel.com>; > Richardson, Bruce <bruce.richardson@intel.com>; thomas@monjalon.net > Cc: dev@dpdk.org; Yao, Lei A <lei.a.yao@intel.com>; Wang, FengqinX > <fengqinx.wang@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix ether header size > calculation > > On 4/9/2019 10:45 AM, Pavan Nikhilesh Bhagavatula wrote: > > From: Pavan Nikhilesh <pbhagavatula@marvell.com> > > > > Fix ether header size calculation in Tx only mode. > > > > Coverity issue: 337684 > > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate > function") > > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Applied to dpdk-next-net/master, thanks. > > > @lei, can you please confirm the txonly mode on next-net? Hi, Ferruh The src mac of txonly mode is correct on next-net branch now. Need more regression test today to check if any other issue exist. Thanks. BRs Lei
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index 66e63788a..2d0e1a027 100644 --- a/app/test-pmd/txonly.c +++ b/app/test-pmd/txonly.c @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp, /* * Copy headers in first packet segment(s). */ - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0); + copy_buf_to_pkt(eth_hdr, sizeof(*eth_hdr), pkt, 0); copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt, sizeof(struct ether_hdr)); if (txonly_multi_flow) {